IETF Logo Mail Archive

Re: [Dots] AD review of draft-ietf-dots-data-channel-25

Roman Danyliw <rdd@cert.org> Wed, 13 February 2019 17:35 UTC

Return-Path: <rdd@cert.org>
X-Original-To: dots@ietfa.amsl.com
Delivered-To: dots@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7C8F3130F65; Wed, 13 Feb 2019 09:35:14 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2
X-Spam-Level:
X-Spam-Status: No, score=-2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cert.org
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1tQ5BMYVtLRZ; Wed, 13 Feb 2019 09:35:10 -0800 (PST)
Received: from taper.sei.cmu.edu (taper.sei.cmu.edu [147.72.252.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 33FB1130ED0; Wed, 13 Feb 2019 09:35:10 -0800 (PST)
Received: from korb.sei.cmu.edu (korb.sei.cmu.edu [10.64.21.30]) by taper.sei.cmu.edu (8.14.7/8.14.7) with ESMTP id x1DHZ8LL011343; Wed, 13 Feb 2019 12:35:08 -0500
DKIM-Filter: OpenDKIM Filter v2.11.0 taper.sei.cmu.edu x1DHZ8LL011343
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cert.org; s=yc2bmwvrj62m; t=1550079308; bh=1J7BWKWyTaI/N6PZfEFI8JUYQrFFsA4nAqRO3Mp2SqM=; h=From:To:CC:Subject:Date:References:In-Reply-To:From; b=ft/fpOkiqn8ro+kFwWLM6tFkXEzIKmppaKXyLz3Hl+5s7rKFneS9OYP5/wPvNQ3Cf WheDjDx4n+e/Z5kKMZlyhLYU/KM5ilXFuQs6go2GdCpyQQO/6hXwGJDDFl95M1zjo+ MIuxfI7IkMXPzDuENgk9BdQj69qsFhlitVKVp6ko=
Received: from CASSINA.ad.sei.cmu.edu (cassina.ad.sei.cmu.edu [10.64.28.249]) by korb.sei.cmu.edu (8.14.7/8.14.7) with ESMTP id x1DHZ2G1018979; Wed, 13 Feb 2019 12:35:02 -0500
Received: from MARATHON.ad.sei.cmu.edu ([10.64.28.250]) by CASSINA.ad.sei.cmu.edu ([10.64.28.249]) with mapi id 14.03.0435.000; Wed, 13 Feb 2019 12:35:02 -0500
From: Roman Danyliw <rdd@cert.org>
To: Benjamin Kaduk <kaduk@mit.edu>, "draft-ietf-dots-data-channel@ietf.org" <draft-ietf-dots-data-channel@ietf.org>
CC: "dots@ietf.org" <dots@ietf.org>
Thread-Topic: [Dots] AD review of draft-ietf-dots-data-channel-25
Thread-Index: AQHUw7uxZs45zX8IakO+sq0/OtQQsKXd96Qg
Date: Wed, 13 Feb 2019 17:35:01 +0000
Message-ID: <359EC4B99E040048A7131E0F4E113AFC01857C1DEB@marathon>
References: <20190213164622.GX56447@kduck.mit.edu>
In-Reply-To: <20190213164622.GX56447@kduck.mit.edu>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.64.22.6]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/dots/_3ow4nu0pa_FIkB6OPb4xyj_rL4>
Subject: Re: [Dots] AD review of draft-ietf-dots-data-channel-25
X-BeenThere: dots@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "List for discussion of DDoS Open Threat Signaling \(DOTS\) technology and directions." <dots.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dots>, <mailto:dots-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dots/>
List-Post: <mailto:dots@ietf.org>
List-Help: <mailto:dots-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dots>, <mailto:dots-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Feb 2019 17:35:21 -0000

Hi Ben and Data Channel Authors!

> -----Original Message-----
> From: Dots [mailto:dots-bounces@ietf.org] On Behalf Of Benjamin Kaduk
> Sent: Wednesday, February 13, 2019 11:46 AM
> To: draft-ietf-dots-data-channel@ietf.org
> Cc: dots@ietf.org
> Subject: [Dots] AD review of draft-ietf-dots-data-channel-25

> This is my AD review of the -25

[snip]
 
> Can someone (the shepherd?) confirm that an automated syntax checker
> has run over the JSON in examples?

I'm the shepherd.  I validated the YANG in Section 4.3, but forgot to do the JSON.  I just ran the JSON in Figures 11, 12, 13, 14, 16, 17, 19, 23, 24, 25, 27, 29, and 31 through https://jsonlint.com/.  All but Figure 16 came back fine.  

Per Figure 16, the following edit is necessary (i.e., add a quote around integer, s/integer/"integer"/)
OLD
           "target-port-range": [
             {
               "lower-port": integer,
               "upper-port": integer
             }
           ],
           "target-protocol": [
             integer
           ],
NEW
           "target-port-range": [
             {
               "lower-port": "integer",
               "upper-port": "integer"
             }
           ],
           "target-protocol": [
             "integer"
           ],
 
Roman

v2.28.0 | Report a Bug | By Email | System Status