Re: [Dots] Shepherd feedback on draft-ietf-dots-data-channel-21

<mohamed.boucadair@orange.com> Thu, 27 September 2018 05:36 UTC

Return-Path: <mohamed.boucadair@orange.com>
X-Original-To: dots@ietfa.amsl.com
Delivered-To: dots@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 66D27130DEE for <dots@ietfa.amsl.com>; Wed, 26 Sep 2018 22:36:41 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.599
X-Spam-Level:
X-Spam-Status: No, score=-2.599 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ht4vA9UdBuRe for <dots@ietfa.amsl.com>; Wed, 26 Sep 2018 22:36:39 -0700 (PDT)
Received: from orange.com (mta134.mail.business.static.orange.com [80.12.70.34]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 787D4126DBF for <dots@ietf.org>; Wed, 26 Sep 2018 22:36:39 -0700 (PDT)
Received: from opfednr00.francetelecom.fr (unknown [xx.xx.xx.64]) by opfednr20.francetelecom.fr (ESMTP service) with ESMTP id 42LNpY6XdZz1yMF; Thu, 27 Sep 2018 07:36:37 +0200 (CEST)
Received: from Exchangemail-eme2.itn.ftgroup (unknown [xx.xx.31.13]) by opfednr00.francetelecom.fr (ESMTP service) with ESMTP id 42LNpY5ZkszDq7s; Thu, 27 Sep 2018 07:36:37 +0200 (CEST)
Received: from OPEXCLILMA3.corporate.adroot.infra.ftgroup ([fe80::60a9:abc3:86e6:2541]) by OPEXCLILM6D.corporate.adroot.infra.ftgroup ([fe80::54f9:a6c3:c013:cbc7%19]) with mapi id 14.03.0415.000; Thu, 27 Sep 2018 07:36:37 +0200
From: <mohamed.boucadair@orange.com>
To: Roman Danyliw <rdd@cert.org>, "dots@ietf.org" <dots@ietf.org>
Thread-Topic: Shepherd feedback on draft-ietf-dots-data-channel-21
Thread-Index: AdRV19jHE2e2qdMcQo+LZPRf9LNaNgASazRA
Date: Thu, 27 Sep 2018 05:36:36 +0000
Message-ID: <787AE7BB302AE849A7480A190F8B93302DFE769C@OPEXCLILMA3.corporate.adroot.infra.ftgroup>
References: <359EC4B99E040048A7131E0F4E113AFC014C45627E@marathon>
In-Reply-To: <359EC4B99E040048A7131E0F4E113AFC014C45627E@marathon>
Accept-Language: fr-FR, en-US
Content-Language: fr-FR
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.168.234.4]
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/dots/xNg8E_6WeGPzMsyC0tBoD433faQ>
Subject: Re: [Dots] Shepherd feedback on draft-ietf-dots-data-channel-21
X-BeenThere: dots@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "List for discussion of DDoS Open Threat Signaling \(DOTS\) technology and directions." <dots.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dots>, <mailto:dots-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dots/>
List-Post: <mailto:dots@ietf.org>
List-Help: <mailto:dots-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dots>, <mailto:dots-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 27 Sep 2018 05:36:42 -0000

Hi Roman, 

The diagrams were generated using a command which allows to break long lines. This is why you can see in the draft, e.g.,

       |              |     |     |           +--:(range)
       |              |     |     |           |  +--rw lower-port
       |              |     |     |           |  |       inet:port-number
       |              |     |     |           |  +--rw upper-port
       |              |     |     |           |          inet:port-number
       |              |     |     |           +--:(operator)
       |              |     |     |              +--rw operator?
       |              |     |     |              |       operator
       |              |     |     |              +--rw port
       |              |     |     |                      inet:port-number


For the nits you reported, I have already tried both commands:  

pyang -f tree --tree-line-length 69 ...

and 

pyang -f tree --tree-line-length 50 ...

but with the same result. 

I suggest to leave this to be fixed by the RFC editor. 

Thanks you. 

Cheers,
Med

> -----Message d'origine-----
> De : Dots [mailto:dots-bounces@ietf.org] De la part de Roman Danyliw
> Envoyé : mercredi 26 septembre 2018 22:36
> À : dots@ietf.org
> Objet : [Dots] Shepherd feedback on draft-ietf-dots-data-channel-21
> 
> Hi!
> 
> In preparing my write-up for draft-ietf-dots-data-channel-21 I found no
> issues beyond one of formatting.  idnits 2.15.01 reported:
> 
> --[ snip idnits output ]--
> tmp/draft-ietf-dots-data-channel-21.txt(933): Line is too long: the offending
> characters are 'tor'
> tmp/draft-ietf-dots-data-channel-21.txt(934): Line is too long: the offending
> characters are ')?'
> tmp/draft-ietf-dots-data-channel-21.txt(937): Line is too long: the offending
> characters are 'r'
> tmp/draft-ietf-dots-data-channel-21.txt(939): Line is too long: the offending
> characters are 'r'
> tmp/draft-ietf-dots-data-channel-21.txt(944): Line is too long: the offending
> characters are 'r'
> tmp/draft-ietf-dots-data-channel-21.txt(946): Line is too long: the offending
> characters are 'ator)'
> tmp/draft-ietf-dots-data-channel-21.txt(947): Line is too long: the offending
> characters are 'operator'
> tmp/draft-ietf-dots-data-channel-21.txt(948): Line is too long: the offending
> characters are ')?'
> tmp/draft-ietf-dots-data-channel-21.txt(959): Line is too long: the offending
> characters are 'r'
> tmp/draft-ietf-dots-data-channel-21.txt(961): Line is too long: the offending
> characters are 'r'
> tmp/draft-ietf-dots-data-channel-21.txt(966): Line is too long: the offending
> characters are 'r'
> tmp/draft-ietf-dots-data-channel-21.txt(1003): Line is too long: the
> offending characters are 'tor'
> tmp/draft-ietf-dots-data-channel-21.txt(1004): Line is too long: the
> offending characters are ')?'
> tmp/draft-ietf-dots-data-channel-21.txt(1015): Line is too long: the
> offending characters are 'r'
> tmp/draft-ietf-dots-data-channel-21.txt(1017): Line is too long: the
> offending characters are 'r'
> tmp/draft-ietf-dots-data-channel-21.txt(1022): Line is too long: the
> offending characters are 'r'
> tmp/draft-ietf-dots-data-channel-21.txt(1024): Line is too long: the
> offending characters are 'ator)'
> tmp/draft-ietf-dots-data-channel-21.txt(1025): Line is too long: the
> offending characters are 'operator'
> tmp/draft-ietf-dots-data-channel-21.txt(1026): Line is too long: the
> offending characters are ')?'
> tmp/draft-ietf-dots-data-channel-21.txt(1029): Line is too long: the
> offending characters are 'r'
> tmp/draft-ietf-dots-data-channel-21.txt(1031): Line is too long: the
> offending characters are 'r'
> tmp/draft-ietf-dots-data-channel-21.txt(1036): Line is too long: the
> offending characters are 'r'
> 
>   ** There are 22 instances of too long lines in the document, the longest
>      one being 8 characters in excess of 72.
> --[ end ]--
> 
> To get more context on which were the offending lines:
> 
> --[ snip]--
> $ cat draft-ietf-dots-data-channel-21.txt | awk 'length($0) > 72 {print NR
> ":" $0}'
> 933:       |              |     |     |     +--rw source-port-range-or-
> operator
> 934:       |              |     |     |        +--rw (port-range-or-
> operator)?
> 937:       |              |     |     |           |  |       inet:port-number
> 939:       |              |     |     |           |          inet:port-number
> 944:       |              |     |     |                      inet:port-number
> 946:       |              |     |        +--:(destination-port-range-or-
> operator)
> 947:       |              |     |           +--rw destination-port-range-or-
> operator
> 948:       |              |     |              +--rw (port-range-or-
> operator)?
> 959:       |              |     |                 |  |       inet:port-number
> 961:       |              |     |                 |          inet:port-number
> 966:       |              |     |                            inet:port-number
> 1003:       |              |     |     |     +--rw source-port-range-or-
> operator
> 1004:       |              |     |     |        +--rw (port-range-or-
> operator)?
> 1015:       |              |     |     |           |  |       inet:port-
> number
> 1017:       |              |     |     |           |          inet:port-
> number
> 1022:       |              |     |     |                      inet:port-
> number
> 1024:       |              |     |        +--:(destination-port-range-or-
> operator)
> 1025:       |              |     |           +--rw destination-port-range-or-
> operator
> 1026:       |              |     |              +--rw (port-range-or-
> operator)?
> 1029:       |              |     |                 |  |       inet:port-
> number
> 1031:       |              |     |                 |          inet:port-
> number
> 1036:       |              |     |                            inet:port-
> number
> --[snip]--
> 
> Can these please be fixed in a -22 prior to requesting publication.
> 
> Thanks,
> Roman
> 
> _______________________________________________
> Dots mailing list
> Dots@ietf.org
> https://www.ietf.org/mailman/listinfo/dots