[dtn] Genart telechat review of draft-ietf-dtn-bpbis-21

Stewart Bryant via Datatracker <noreply@ietf.org> Fri, 31 January 2020 19:24 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: dtn@ietf.org
Delivered-To: dtn@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 89A75120842; Fri, 31 Jan 2020 11:24:12 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: Stewart Bryant via Datatracker <noreply@ietf.org>
To: <gen-art@ietf.org>
Cc: last-call@ietf.org, draft-ietf-dtn-bpbis.all@ietf.org, dtn@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.116.1
Auto-Submitted: auto-generated
Precedence: bulk
Reply-To: Stewart Bryant <stewart.bryant@gmail.com>
Message-ID: <158049865249.21219.7770941261141759152@ietfa.amsl.com>
Date: Fri, 31 Jan 2020 11:24:12 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/dtn/4qyoMdk8d0D13Juj3IihNIcLuco>
Subject: [dtn] Genart telechat review of draft-ietf-dtn-bpbis-21
X-BeenThere: dtn@ietf.org
X-Mailman-Version: 2.1.29
List-Id: "Delay Tolerant Networking \(DTN\) discussion list at the IETF." <dtn.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dtn>, <mailto:dtn-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dtn/>
List-Post: <mailto:dtn@ietf.org>
List-Help: <mailto:dtn-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dtn>, <mailto:dtn-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 31 Jan 2020 19:24:12 -0000

Reviewer: Stewart Bryant
Review result: Ready with Issues

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair. Please wait for direction from your
document shepherd or AD before posting a new version of the draft.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-dtn-bpbis-21
Reviewer: Stewart Bryant
Review Date: 2020-01-31
IETF LC End Date: None
IESG Telechat date: 2020-02-06

Summary:

This version is a major improvement on the version that I reviewed earlier. I
thank the authors for addressing my earlier review comments. There are a number
of minor issues that the authors ought to look at, particularly around IANA
allocation policy. Major issues: None

Minor issues:

[BPSEC] Birrane, E., "Bundle Security Protocol Specification", Work
        In Progress, October 2015.

SB> I think that this should be a reference to draft-ietf-dtn-bpsec

=======

In Section 10.3 the allocation policy has been changed to Standards Action
which seems wise given the size of the registry. However all the
registries  called up in 10.1..10.5 are all small and the authors ought
to consider upgrading them of at least a portion of them to a higher
bar than at present (they are specification required). Specification
required can be met by a specification that is not even publicly
accessible which can grab multiple entries. This is a dangerous position
to leave small the registries of a Standards Track  protocol.

I have only checked the registries specifically addressed by this specification
and the authors ought to check the other registries in the Bundle Protocol
Namespace to see if any of them are also vulnerable.

========
Nits/editorial comments:

Note that more robust protection of BP data integrity, as needed,

SB> I that should be ….,if needed,

=====

SB> Bpsec appears as BPsec and bpsec also the noun bpsec is not defined
I assume you mean the BPsec protocol or mechanism or similar.

=======
 The current Bundle Block Types namespace is augmented

SB> I think that strictly you should say:
SB> The current Bundle Block Types registry in the Bundle Protocol Namespace is
augmented.

This problem applies to the registries 10.2, 10.3, 10.4, and 10.5