Re: [dtn] [EXT] Re: AD review of draft-ietf-dtn-bpsec-default-sc-02

"R. Atkinson" <rja.lists@gmail.com> Fri, 14 May 2021 13:12 UTC

Return-Path: <rja.lists@gmail.com>
X-Original-To: dtn@ietfa.amsl.com
Delivered-To: dtn@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D3BAE3A326F for <dtn@ietfa.amsl.com>; Fri, 14 May 2021 06:12:25 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.098
X-Spam-Level:
X-Spam-Status: No, score=-2.098 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IzxF9CkJTikJ for <dtn@ietfa.amsl.com>; Fri, 14 May 2021 06:12:21 -0700 (PDT)
Received: from mail-qk1-x72b.google.com (mail-qk1-x72b.google.com [IPv6:2607:f8b0:4864:20::72b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 34E2D3A3270 for <dtn@ietf.org>; Fri, 14 May 2021 06:12:21 -0700 (PDT)
Received: by mail-qk1-x72b.google.com with SMTP id i67so28599754qkc.4 for <dtn@ietf.org>; Fri, 14 May 2021 06:12:21 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=7xF/FMFZiDLWX6zqW40vavjpS0nji2Tgitdaa/sbEaQ=; b=gEzbqE+exx21xIazT11HYYknNjyGuK1ZPzPK8kYFEpWzWq7XIeBF4YSwtn0/sNWlAb CI19+lPs9HX+EgYXmrE4LOOcLkgbD3sgvM0MoepYTa3G4JFwhwA0gcQMuSMbuIUSAr/n mDMi7a6qmeI/4/qUal/VC9KDg9qdu/YCXjd1nzyYJ/3glmyPn7RCMAeWuA9gy6nmJuz1 W633n8L2d3n4FCF4gQmBLulcki7ewgjN+B61SvtfIMaW78f2I+wSG3+JwYYvagply7/r 2IosEcxXjP32218FBK+82WRjXpjir+Y/vTvT9wr2TVD0Rpu55bGGKpOFIuF3BlGGI4qT ycxw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=7xF/FMFZiDLWX6zqW40vavjpS0nji2Tgitdaa/sbEaQ=; b=RdKPFIBBgi3zJRYiqpFv7gKvYo6N7dll/9mrrJ1YfuGSg036i8smDs8ArJ85zbWMOx FF7jCnMtZjApfmqh7+9WYxTuFgYgL+arm8eVwgXKVFr5RjP6keWic0eoqNtbVpq/C7qp oBsWs8aDdPaHbQM5AtwFZKvNWxClPL8aIAQtQaROB7+IVj6kZZrscgA44egF0UOcFI+x HOaNtgCp3utA68sSCaQzXAze1O1LLEuog9ITc+tvjJ3fkFLYou1WFJW5h5TObkZYSw2T SE8grHiC2sOnSMTkT8C9hjYfkZ54swJoJS3JWFiPiO6zxzwTdvmLMPbEtxnxKqxZ64f8 tjig==
X-Gm-Message-State: AOAM533MIRN9j4rqWhX6PZf1xkTVo6zzcHbpPvXH3Lh2Z4YWUXPiOKA8 CHAOqUZ96Wn6GbMls4IIuYj4f6C/BxQ=
X-Google-Smtp-Source: ABdhPJyM7UCSIMiHo1Yp+O8/1Gg5LMZe36//jJ9mqAL/Et8dxFImrJ4qIae8YWde0aSlz82uRrFc8g==
X-Received: by 2002:a37:5f41:: with SMTP id t62mr43458270qkb.458.1620997939464; Fri, 14 May 2021 06:12:19 -0700 (PDT)
Received: from [10.30.20.11] (pool-108-28-58-183.washdc.fios.verizon.net. [108.28.58.183]) by smtp.gmail.com with ESMTPSA id h10sm4767419qka.26.2021.05.14.06.12.17 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 May 2021 06:12:18 -0700 (PDT)
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.6\))
From: "R. Atkinson" <rja.lists@gmail.com>
In-Reply-To: <8c32964152f0472e9b21908802d73187@aplex01.dom1.jhuapl.edu>
Date: Fri, 14 May 2021 09:12:17 -0400
Cc: Martin Duke <martin.h.duke@gmail.com>, Zaheduzzaman Sarker <zaheduzzaman.sarker@ericsson.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <B923F182-768A-4FD1-92C7-6D3B5F56D016@gmail.com>
References: <CAM4esxRUTi+iLki95x6gRzaN7KfXr72bicKRrLxf=3_No8-PSQ@mail.gmail.com> <8c32964152f0472e9b21908802d73187@aplex01.dom1.jhuapl.edu>
To: DTN WG <dtn@ietf.org>
X-Mailer: Apple Mail (2.3608.120.23.2.6)
Archived-At: <https://mailarchive.ietf.org/arch/msg/dtn/J3Fl414paAaE9riU8JACuvWXEGo>
Subject: Re: [dtn] [EXT] Re: AD review of draft-ietf-dtn-bpsec-default-sc-02
X-BeenThere: dtn@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Delay Tolerant Networking \(DTN\) discussion list at the IETF." <dtn.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dtn>, <mailto:dtn-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dtn/>
List-Post: <mailto:dtn@ietf.org>
List-Help: <mailto:dtn-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dtn>, <mailto:dtn-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 14 May 2021 13:12:26 -0000

All,

All of my comments are non-blocking editorial requests.

My principle is simple.  With 30 years experience so far, every IETF protocol I am aware of eventually is implemented by a naive software person who is NOT involved in the IETF at all.  So if the current text raises questions about meaning/clarity/intent among anyone reviewing the document from an IETF context, it is highly likely those questions also will arise in the mind of the naive implementer who has to code this in future at some point.  

So best (IMHO) to clarify the text, even if there is no change to the meaning/intention.

> On May 12, 2021, at 19:08, Birrane, Edward J. <Edward.Birrane@jhuapl.edu> wrote:
> 
> Martin,
>  
>   Thank you for continuing the review!
>  
>   My apologies for the top post – I am having some problems with my e-mail client and HTML quoting. 
>  
>   (3.3.2):  AES-KW does not use an IV and wrapped keys are required to be 8 byte multiples so we won’t have padding. There is no additional info that needs to be in the BCB to assist with unwrap.  Key width comes from the AES Variant parameter.

Maybe please add the text above (or edited text to your taste) to the draft to improve readability/clarity for naive implementers who are not experts in key wrapping.

>   (3.3.3): Certainly not inconceivable! But we (DTNWG) can’t think of any that are motivating at this time.  I am concerned that adding this complexity would make interoperability harder if someone adds options later. The default security context is meant to be a simple, secure context (others are coming). 

If they are not explicitly prohibited in the draft, then I think a Registry needs to be created.  If the text is ambiguous, please either add clear new text with the prohibition xor add the Registry related text,

>   (4.1): This is a semantic thing. The authentication tag is not considered part of the cipher text itself (though some APIs may catenate them). This security context will try and place the authentication tag as a security result in the BCB itself (section 4.4.1). 

That text is great, but please place an edited version of that directly into the draft.  Ordinary software developers will not understand this ab initio; it needs to be stated clearly.

>   (6.1): Neither of these is meant to be normative. In a -07 I can correct the language to avoid must and may to avoid any misinterpretation.

My request would be to go through the draft and look at each instance of “may” or “MAY” and see whether it would be more clear to say “might” (lowercase; non-normative).

For non-native readers of English, it is very confusing that colloquial English uses the word “may” with 2 very different meanings:

(a) a possible event — “It may rain this afternoon.”
(b) permission - “Mary may skip school today.”

For the intended meaning of (a) above, it would be much more readable if the word “might” were substituted for “may”. 

[ Aside: I wish the RFC Editor would pursue this issue more often than it seems to.  Maybe the new WG on terminology can pick this issue up and run with it.  ]

Cheers,

Ran