[Ecn-in-quic] Pull request for adding ECN in QUIC

Magnus Westerlund <magnus.westerlund@ericsson.com> Tue, 22 May 2018 18:36 UTC

Return-Path: <magnus.westerlund@ericsson.com>
X-Original-To: ecn-in-quic@ietfa.amsl.com
Delivered-To: ecn-in-quic@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F141C12AF83 for <ecn-in-quic@ietfa.amsl.com>; Tue, 22 May 2018 11:36:04 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.31
X-Spam-Level:
X-Spam-Status: No, score=-4.31 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1ay2KaJ-Yzju for <ecn-in-quic@ietfa.amsl.com>; Tue, 22 May 2018 11:36:01 -0700 (PDT)
Received: from sesbmg22.ericsson.net (sesbmg22.ericsson.net [193.180.251.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C8A7312E88E for <ecn-in-quic@ietf.org>; Tue, 22 May 2018 11:36:00 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; d=ericsson.com; s=mailgw201801; c=relaxed/simple; q=dns/txt; i=@ericsson.com; t=1527014159; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=PohcIxeR9rqcUADMhRhgWk/XKidSBpU46logfxPdVfM=; b=PA9uJ5b62M2ztu0zqa48UibnM4M9vCtLHlOIbKjwmFtFtcAuPbsRxfkONMRAz/u+ kMprwYXbeXmPPBvpvmiYiUVbVytpeBsfTq+In+h6VAaBxlQ5RkTEHeDek+++YdOT u8xy3gwU44wN8uUp/vNZRs6ntekc2hWdq2QgWwtaqc0=;
X-AuditID: c1b4fb30-263479c00000169b-a7-5b04630e92f1
Received: from ESESSHC007.ericsson.se (Unknown_Domain [153.88.183.39]) by sesbmg22.ericsson.net (Symantec Mail Security) with SMTP id 07.FC.05787.E03640B5; Tue, 22 May 2018 20:35:59 +0200 (CEST)
Received: from [147.214.160.12] (153.88.183.153) by smtps.internal.ericsson.com (153.88.183.39) with Microsoft SMTP Server (TLS) id 14.3.382.0; Tue, 22 May 2018 20:35:30 +0200
To: "ecn-in-quic@ietf.org" <ecn-in-quic@ietf.org>
From: Magnus Westerlund <magnus.westerlund@ericsson.com>
Message-ID: <14d35624-b733-f045-2c1a-8a24ff85ba7f@ericsson.com>
Date: Tue, 22 May 2018 20:35:30 +0200
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0
MIME-Version: 1.0
Content-Type: text/plain; charset="windows-1252"; format="flowed"
Content-Transfer-Encoding: 8bit
Content-Language: en-GB
X-Originating-IP: [153.88.183.153]
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrJLMWRmVeSWpSXmKPExsUyM2K7ui5/Mku0waLzXBaN7avYHRg9liz5 yRTAGMVlk5Kak1mWWqRvl8CV8fn6ZaaCazwVL5rOsDQwzuPqYuTkkBAwkWh98Ia5i5GLQ0jg CKPEw6Z3UM5mRolD3ZNZQapEBAwlth14DGazCVhI3PzRyAZiCwvoSPTP/8EIYvMK2EvMO3mX BcRmEVCV+LzlAViNqECMxI+jXSwQNYISJ2c+AbI5OJiB6h9sLQMJMwvISzRvnc0MYYtLNH1Z CbZKSEBboqGpgxXiUCWJ6/Ous0xg5J+FZNIshEmzkEyahWTSAkaWVYyixanFSbnpRkZ6qUWZ ycXF+Xl6eaklmxiBAXhwy2+DHYwvnzseYhTgYFTi4RVKZIkWYk0sK67MPcQowcGsJML76RJT tBBvSmJlVWpRfnxRaU5q8SFGaQ4WJXFeC7/NUUIC6YklqdmpqQWpRTBZJg5OqQbGUpGdU/W/ rjpUd/6ZzaQzAdErNq4vf6pSrXLR7LyieMj/xhMerTG2qgoJJiXrbjc8OtB6N9Cls9f5+8Qb R1PO/pH+oFBeNdvXcDsTQ6Tb2avMu37ssF7137jlSGCt+1wp02PVLbZ+IZZGF5LUrYwd5gd5 NRf9VPvAKTCpcNq1braj19c/uOStxFKckWioxVxUnAgAoiO/YDwCAAA=
Archived-At: <https://mailarchive.ietf.org/arch/msg/ecn-in-quic/lBQEyoJzj_foicQNGK2CytTla3c>
Subject: [Ecn-in-quic] Pull request for adding ECN in QUIC
X-BeenThere: ecn-in-quic@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "ECN in the QUIC protocol discussion list." <ecn-in-quic.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ecn-in-quic>, <mailto:ecn-in-quic-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ecn-in-quic/>
List-Post: <mailto:ecn-in-quic@ietf.org>
List-Help: <mailto:ecn-in-quic-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ecn-in-quic>, <mailto:ecn-in-quic-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 22 May 2018 18:36:05 -0000

Design Team

I have produced a pull request based on our proposal for how to add ECN 
support in QUIC. It is based on the Wiki content, but I have written 
quite some glue and other changes. I like to send this out to the WG 
later the week. As it is in github the active contributors may start 
comment on it immediately. So please review and comment.

https://github.com/quicwg/base-drafts/pull/1372

There is one part in the transport draft that I don't think quite work, 
and that is Section 6.9.4.2.

    In the sub-sequent ACK or ACK_ECN received, the endpoint needs to
    track which packets that are acknowledged.  Only packets sent after
    connection migration are included in the number of ACKed packets and
    compared to the difference in the ECN counters received in the ACK
    compared to the locally stored state.

The issue I have is that this is not robust against cases where you 
might have acking of packets from prior to the connection migration 
point. Thus counting can be corrupted. Help apreciated.

Also the recovery part needs more than pseudo code, and that hasn't been 
written yet.

Cheers

Magnus Westerlund

----------------------------------------------------------------------
Network Architecture & Protocols, Ericsson Research
----------------------------------------------------------------------
Ericsson AB                 | Phone  +46 10 7148287
Torshamnsgatan 23           | Mobile +46 73 0949079
SE-164 80 Stockholm, Sweden | mailto: magnus.westerlund@ericsson.com
----------------------------------------------------------------------