Re: [Emu] I-D Action: draft-ietf-emu-tls-eap-types-09.txt

Alan DeKok <aland@deployingradius.com> Sat, 29 October 2022 12:07 UTC

Return-Path: <aland@deployingradius.com>
X-Original-To: emu@ietfa.amsl.com
Delivered-To: emu@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 366C6C14F722 for <emu@ietfa.amsl.com>; Sat, 29 Oct 2022 05:07:08 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.909
X-Spam-Level:
X-Spam-Status: No, score=-1.909 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01] autolearn=unavailable autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GoQG_nYgtLOG for <emu@ietfa.amsl.com>; Sat, 29 Oct 2022 05:07:03 -0700 (PDT)
Received: from mail.networkradius.com (mail.networkradius.com [62.210.147.122]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C12ACC14CF03 for <emu@ietf.org>; Sat, 29 Oct 2022 05:07:02 -0700 (PDT)
Received: from smtpclient.apple (135-23-95-173.cpe.pppoe.ca [135.23.95.173]) by mail.networkradius.com (Postfix) with ESMTPSA id 584A6B6; Sat, 29 Oct 2022 12:07:00 +0000 (UTC)
Authentication-Results: NetworkRADIUS; dmarc=none (p=none dis=none) header.from=deployingradius.com
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\))
From: Alan DeKok <aland@deployingradius.com>
In-Reply-To: <HE1PR0701MB3050E350E6C3A2A291AE331789359@HE1PR0701MB3050.eurprd07.prod.outlook.com>
Date: Sat, 29 Oct 2022 08:06:58 -0400
Cc: John Mattsson <john.mattsson=40ericsson.com@dmarc.ietf.org>, "emu@ietf.org" <emu@ietf.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <DA174BC8-A85A-481E-9992-45BD928DB6BC@deployingradius.com>
References: <166428153120.54333.17278955597896126770@ietfa.amsl.com> <HE1PR0701MB3050362A7979C272F7E285E989329@HE1PR0701MB3050.eurprd07.prod.outlook.com> <794E0C93-3068-4C2C-98B8-AE551D48AC00@deployingradius.com> <HE1PR0701MB3050E350E6C3A2A291AE331789359@HE1PR0701MB3050.eurprd07.prod.outlook.com>
To: John Mattsson <john.mattsson@ericsson.com>
X-Mailer: Apple Mail (2.3696.120.41.1.1)
Archived-At: <https://mailarchive.ietf.org/arch/msg/emu/Czp4-ytUZCLIs2WYJWuzWRFp5Rc>
Subject: Re: [Emu] I-D Action: draft-ietf-emu-tls-eap-types-09.txt
X-BeenThere: emu@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "EAP Methods Update \(EMU\)" <emu.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/emu>, <mailto:emu-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/emu/>
List-Post: <mailto:emu@ietf.org>
List-Help: <mailto:emu-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/emu>, <mailto:emu-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 29 Oct 2022 12:07:08 -0000

On Oct 29, 2022, at 7:46 AM, John Mattsson <john.mattsson@ericsson.com> wrote:
> I don’t remember any such WG consensus (but maybe I am missing something). What I can find in the mailing list archive is that several people pointed out that moving away from SHA-1 is a good idea, that there is no need to use SHA-1, but that the final decision is Microsoft’s:

  There was no agreement to change PEAP.  There have been no recommendations to change the document to address this issue.

  An implicit consensus to do nothing is still consensus.

> Might be that we are stuck with SHA-1, but irrespectively of why that is the case, I still think that draft-ietf-emu-tls-eap-types should clearly point out the fact that PEAP 1.3 uses SHA-1. I think this is important (and unexpected) information to readers of the document and users of the EAP method. My understanding is that TEAP 1.3 is not using SHA-1.

  The document is pretty clear on how the fields are calculated:

2.5.  PEAP

   When PEAP uses crypto binding, it uses a different key calculation
   defined in [PEAP-MPPE] which consumes inner EAP method keying
   material.  The pseudo-random function (PRF+) used in [PEAP-MPPE] is
   not taken from the TLS exporter, but is instead calculated via a
   different method which is given in [PEAP-PRF].  That derivation
   remains unchanged in this specification.

  It may be worth adding a one-sentence comment on the order of:

  Note that this derivation depends on SHA-1, which may be formally deprecated in the near future.

  Alan DeKok.