[eppext] AD review of draft-ietf-eppext-tmch-smd-03

Barry Leiba <barryleiba@computer.org> Fri, 20 November 2015 20:28 UTC

Return-Path: <barryleiba@gmail.com>
X-Original-To: eppext@ietfa.amsl.com
Delivered-To: eppext@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 059A41B3D51; Fri, 20 Nov 2015 12:28:45 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 0.621
X-Spam-Level:
X-Spam-Status: No, score=0.621 tagged_above=-999 required=5 tests=[BAYES_40=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FM_FORGED_GMAIL=0.622, FREEMAIL_FROM=0.001, SPF_PASS=-0.001] autolearn=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bePy3G7e2qOg; Fri, 20 Nov 2015 12:28:44 -0800 (PST)
Received: from mail-vk0-x22d.google.com (mail-vk0-x22d.google.com [IPv6:2607:f8b0:400c:c05::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D20BE1B3D50; Fri, 20 Nov 2015 12:28:40 -0800 (PST)
Received: by vkay187 with SMTP id y187so5257523vka.3; Fri, 20 Nov 2015 12:28:39 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:date:message-id:subject:from:to:cc:content-type; bh=GXtDVDcqASs5P98HCpiVVw8Ck11G704ehHzLmeQ1FZE=; b=Nwxn7DY7mN+gdeKDZEs6ewkSxa1zxBtmZsRv6y0bEEIUiL3PgXtxru5GlH5Wdy4k8l oOq6hEIj+jqu1oFNpYmErRd4M7g+BT7p4r5md2fwDAnxp5ZRmmeKI02igekMx/Qv2F6t JWFYDLi+Vl3PZdAF79TRYYNkcFFsruiRJqLLqTm5K/uYvXDXUAxHDwnExk6woESLrHGm lmj9+0buVeccDoEIgjWCB9xDD5Y+BacPHHAJ+8cjN495oTK2pxD3wk+UZn4caA1lAkUE IVp1C4Wd+hAP++FSxK1stPCAdqUkBH/P54fxpQ0sRLL0c/O0/kpkHHezd8VSGAmaMjFr JwcQ==
MIME-Version: 1.0
X-Received: by 10.31.107.193 with SMTP id k62mr1343714vki.27.1448051319869; Fri, 20 Nov 2015 12:28:39 -0800 (PST)
Sender: barryleiba@gmail.com
Received: by 10.31.182.135 with HTTP; Fri, 20 Nov 2015 12:28:39 -0800 (PST)
Date: Fri, 20 Nov 2015 15:28:39 -0500
X-Google-Sender-Auth: NozA1pW98IGJxosuFBtRUfE3hZQ
Message-ID: <CALaySJJ6f0uG2v0yh=7AbYq=WLnGSrzpFFBqHRXpDi6HREWtaQ@mail.gmail.com>
From: Barry Leiba <barryleiba@computer.org>
To: draft-ietf-eppext-tmch-smd@ietf.org
Content-Type: text/plain; charset=UTF-8
Archived-At: <http://mailarchive.ietf.org/arch/msg/eppext/ILawAHAXEJ2o6xrXs9UXR5qUtEU>
Cc: eppext <eppext@ietf.org>
Subject: [eppext] AD review of draft-ietf-eppext-tmch-smd-03
X-BeenThere: eppext@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: EPPEXT <eppext.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/eppext>, <mailto:eppext-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/eppext/>
List-Post: <mailto:eppext@ietf.org>
List-Help: <mailto:eppext-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/eppext>, <mailto:eppext-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Nov 2015 20:28:45 -0000

As with the keyrelay document, please accept my apology for the delay
in processing this.  And as with that document, my comments are just
the most minor editorial things, and I will request last call as soon
as I send this message.

-- Section 2.1 --
First, is it assumed that if an element is not marked as OPTIONAL,
it's REQUIRED?  Would it be good to state that at the top?

Second, I have a general aversion to saying, "X is OPTIONAL... except
that it's not optional in a particular situation."  (It's less
confusing, I think, to reverse that.)  What you really mean in the
first two "child elements" bullets is that you MUST specify at least
one of <mark:name> and <mark:org>.  It might be better to say it that
way.  Maybe this?:

OLD
   *  An OPTIONAL <mark:name> element that contains the name of the
      holder.  A <mark:name> MUST be specified in case <mark:org> is
      not specified.

   *  An OPTIONAL <mark:org> element that contains the name of the
      organization holder of the mark.  A <mark:org> MUST be
      specified in case <mark:name> is not specified.

NEW
   *  A <mark:name> element that contains the name of the holder.
      At least one of <mark:name> and <mark:org> MUST be specified,
      and <mark:name> is OPTIONAL if <mark:org> is specified.

   *  A <mark:org> element that contains the name of the organization
      holder of the mark.  At least one of <mark:name> and <mark:org>
      MUST be specified, and <mark:org> is OPTIONAL if <mark:name> is
      specified.

END

-- Section 2.5 --
It's a little odd to have this say "Appendix A" in the section title, no?

Is there any real value in including the entire, 2.5-page-long base64?
 Is it really intended that anyone will extract that from the document
and decode it?  Or is the point just to show how the base64 data is
wrapped in the encodedSignedMark element?  If so, why not just this?:

NEW
 <smd:encodedSignedMark
    xmlns:smd="urn:ietf:params:xml:ns:signedMark-1.0">
 PD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0iVVRGLTgiPz4KPHNtZDpzaWduZWRNYXJ
 rIHhtbG5zOnNtZD0idXJuOmlldGY6cGFyYW1zOnhtbDpuczpzaWduZWRNYXJrLTEuMCIgaW
 ... (base64 data elided for brevity) ...
 PC9zbWQ6c2lnbmVkTWFyaz4=
 </smd:encodedSignedMark>
END

--
Barry