Re: [Extra] Comments on draft-ietf-extra-sieve-special-use-03

Alexey Melnikov <alexey.melnikov@isode.com> Tue, 30 October 2018 20:15 UTC

Return-Path: <alexey.melnikov@isode.com>
X-Original-To: extra@ietfa.amsl.com
Delivered-To: extra@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C585812D4F0 for <extra@ietfa.amsl.com>; Tue, 30 Oct 2018 13:15:01 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.001
X-Spam-Level:
X-Spam-Status: No, score=-2.001 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=isode.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UT7Pq_qzB64M for <extra@ietfa.amsl.com>; Tue, 30 Oct 2018 13:15:00 -0700 (PDT)
Received: from statler.isode.com (Statler.isode.com [62.232.206.189]) by ietfa.amsl.com (Postfix) with ESMTP id 5709E1276D0 for <extra@ietf.org>; Tue, 30 Oct 2018 13:15:00 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1540930499; d=isode.com; s=june2016; i=@isode.com; bh=Fd0y315Y0H13A1pEmLsfQSpciedbdUb878//4cr8P5U=; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version: In-Reply-To:References:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description; b=E8GutGEUmm7lRDUmIN0ywbYCSzfgSs3kmbJV1+AOfv2mznICnsz2XJ9nuKcWaPXEGRMl5d 1NTD8V//b7C+6SkLqAnY9g1H9r12xdpBf4GJdXZ6SSpy0Kui9/zYD6bG8Zjna3qeWyEtoD vj0eCXP2F5+vQMAbJlORPRsYskvTWbk=;
Received: from [192.168.0.7] (cpc121086-nmal24-2-0-cust54.19-2.cable.virginm.net [77.97.145.55]) by statler.isode.com (submission channel) via TCP with ESMTPSA id <W9i7wQAu0h9c@statler.isode.com>; Tue, 30 Oct 2018 20:14:58 +0000
To: Stephan Bosch <stephan.bosch@dovecot.fi>, extra@ietf.org, Ned Freed <ned.freed@mrochek.com>
References: <a519d410-babd-36ee-8343-6fe3bea3a414@isode.com> <d9522e99-5078-01d5-3645-c3b7c8b36ba3@dovecot.fi>
From: Alexey Melnikov <alexey.melnikov@isode.com>
Openpgp: preference=signencrypt
Message-ID: <6b72363d-6f00-3ef7-2398-05690926b6f5@isode.com>
Date: Tue, 30 Oct 2018 20:15:00 +0000
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1
In-Reply-To: <d9522e99-5078-01d5-3645-c3b7c8b36ba3@dovecot.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-transfer-encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/extra/8wdfIYe5aOHAhgtMDV4RhV31Qpw>
Subject: Re: [Extra] Comments on draft-ietf-extra-sieve-special-use-03
X-BeenThere: extra@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Email mailstore and eXtensions To Revise or Amend <extra.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/extra>, <mailto:extra-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/extra/>
List-Post: <mailto:extra@ietf.org>
List-Help: <mailto:extra-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/extra>, <mailto:extra-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Oct 2018 20:15:02 -0000

Hi Stephan,

On 29/10/2018 12:06, Stephan Bosch wrote:
> Hi Alexey,
> 
> 
> Op 28-10-2018 om 16:07 schreef Alexey Melnikov:
>> Hi all,
>> I've just tried to implement this Sieve extension and I have a couple of
>> comments:
>>
>> 3.  Test "specialuse_exists"
>>
>>     Usage:  specialuse_exists [<mailbox: string>]
>>                               <special-use-flags: string-list>
>>
>> This defines an optional argument. According to the base Sieve RFC 5228,
>> optional arguments must be tagged:
>>
>>    2.6.1.  Positional Arguments
>>
>>     Positional arguments are given to a command that discerns their
>>     meaning based on their order.  When a command takes positional
>>     arguments, all positional arguments must be supplied and must be in
>>     the order prescribed.
>>
>>   and
>>
>>    2.6.3.  Optional Arguments
>>
>>     Optional arguments are exactly like tagged arguments except that they
>>     may be left out, in which case a default value is implied.  Because
>>     optional arguments tend to result in shorter scripts, they have been
>>     used far more than tagged arguments.
>>
>> So I don't think you can have "mailbox" being positional without a tag!
> 
> Then what about the entirety of the "imap4flags" extension?

Guilty as charged :-). I entirely forgot about that and the reason why I
haven't noticed is because my implementation doesn't support "variables"
extension, so variable name parameter to addflag/removeflag/setflag is
never allowed.

Any other opinions (Ned?). I just want to make sure that if we violating
some kind of architectural principle specified in the base Sieve script,
than we decide to do this deliberately. (Or maybe we just agree that
there is no architectural principle to begin with.)

> Lots of
> tag-less optional arguments can be found there. I am not against having
> some ":mailbox" tag here, but the current syntax does make things more
> concise.
> 
>> 4.  ":specialuse" Argument to "fileinto" Command
>>
>>     Usage:  fileinto [:specialuse <special-use-flag: string>]
>>                      <mailbox: string>
>>
>> Can I suggest that all special-use-flag strings should not include the
>> leading "\" character? It requires escaping in Sieve, so people might
>> make mistakes when writing scripts.
> 
> I have no strong opinion about that. Disadvantage of doing that is that
> it can be confusing for people with IMAP experience and it becomes
> inconsistent with imap4flags.

Yes, that is true. At the same time in JMAP we can do remove leading "\"
character from flag names as well.

So yes, I am not fully decided on this issue. Anybody else wants to comment?

> Anyone else want to pitch in?
> 
> Regards,
>