Re: [Extra] AD review of draft-ietf-extra-sieve-fcc-06.txt

Alexey Melnikov <alexey.melnikov@isode.com> Tue, 04 December 2018 11:22 UTC

Return-Path: <alexey.melnikov@isode.com>
X-Original-To: extra@ietfa.amsl.com
Delivered-To: extra@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D9009130EC1 for <extra@ietfa.amsl.com>; Tue, 4 Dec 2018 03:22:13 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2
X-Spam-Level:
X-Spam-Status: No, score=-2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=isode.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IvLvM3AdzInU for <extra@ietfa.amsl.com>; Tue, 4 Dec 2018 03:22:12 -0800 (PST)
Received: from waldorf.isode.com (waldorf.isode.com [62.232.206.188]) by ietfa.amsl.com (Postfix) with ESMTP id 99D5112875B for <extra@ietf.org>; Tue, 4 Dec 2018 03:22:12 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1543922531; d=isode.com; s=june2016; i=@isode.com; bh=oreW0jSXFDAfOLxTzqiqXgKv840E6zzlRJKflt5yazA=; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version: In-Reply-To:References:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description; b=Ue8HLw7XEFiH1e34kTRVQPgO0Nqmbpuvrm6MoQj0ZnwCOPQPkM3RWVQHjdOgKE+G/uPf5L TPSD1ddUtjvARdW81JyiKo6uGX7OfY/1eHF7eIFI3TbDtYrVUvYiJQcJYMwZH4CYp09F7a 1CfLGfkaKIMNOi1HbxXOBn2hI0XSXw4=;
Received: from [172.20.1.215] (dhcp-215.isode.net [172.20.1.215]) by waldorf.isode.com (submission channel) via TCP with ESMTPSA id <XAZjYwArG5Ze@waldorf.isode.com>; Tue, 4 Dec 2018 11:22:11 +0000
To: Ken Murchison <murch@fastmail.com>, extra <extra@ietf.org>
References: <2a2f0f33-b056-1a04-aa11-8b8d0a448a4c@isode.com> <fb5a5946-3c09-fa42-7f9e-fc0344e134da@fastmail.com> <c5144624-b0d3-ddbb-43ce-6b17184f4297@isode.com> <bc9de123-d536-1c02-2d67-276602a879c4@fastmail.com>
From: Alexey Melnikov <alexey.melnikov@isode.com>
Message-ID: <417269c0-1ca0-9d47-a140-4e4555bba38d@isode.com>
Date: Tue, 4 Dec 2018 11:21:34 +0000
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.0
In-Reply-To: <bc9de123-d536-1c02-2d67-276602a879c4@fastmail.com>
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="------------6064C9342A220FA0CB2F7492"
Content-Language: en-GB
Archived-At: <https://mailarchive.ietf.org/arch/msg/extra/KZ1xlpW-SMRYjDH0rNRcbx7rhsA>
Subject: Re: [Extra] AD review of draft-ietf-extra-sieve-fcc-06.txt
X-BeenThere: extra@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Email mailstore and eXtensions To Revise or Amend <extra.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/extra>, <mailto:extra-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/extra/>
List-Post: <mailto:extra@ietf.org>
List-Help: <mailto:extra-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/extra>, <mailto:extra-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Dec 2018 11:22:14 -0000

On 03/12/2018 23:15, Ken Murchison wrote:

> On 12/3/18 4:31 PM, Alexey Melnikov wrote:
>
>> Hi Ken,
>>
>> So in -07, I now see:
>>
>> 3.1.1.  Imap4flags Extension
>>
>>    Usage: :fcc <mailbox: string> [:flags <list-of-flags: string-list>]
>>
>> 3.1.2.  Mailbox Extension
>>
>>    Usage: :fcc <mailbox: string> [:create]
>>
>>
>> 3.1.3.  Special-Use Extension
>>
>>   Usage: :fcc <mailbox: string> [:specialuse <special-use-flag: string>]
>>
>>
>> Is your intention that :fcc always goes first? 
>
> No.
>
>> If not, you might want to clarify that.
>
> Ad will add text to that effect.
>

Great.

>> 3.2. Collected Grammar
>>
>>    For convenience, the "FCC" syntax element is defined here using ABNF
>>    [RFC5234] so that it can be augmented by other extensions.
>>
>>    FCC         = ":fcc" string *FCC-OPTS
>>
>> I am somewhat uncomfortable with the above, as it omits all 
>> whitespace delimiters between tokens. If you are going to keep this, 
>> you should add a comment explaining that this is done once lexical 
>> analyzer extracted different non-space elements.
>
>
> How about:
>
> FCC = ":fcc" string *(white-space FCC-OPTS)
>
You also need white-space after ":fcc". And in 2 other productions in 
the same section.
>
> Or would you prefer that I use text similar to what is in Section 8.2 
> of RFC5228:
>
> "The following is the grammar of Sieve after it has been lexically
>     interpreted.  No whitespace or comments appear below."

I think this would be the easiest way to address my concern.

Thank you,

Alexey