Re: [Extra] AD review of draft-ietf-extra-sieve-fcc-06.txt

Alexey Melnikov <alexey.melnikov@isode.com> Mon, 03 December 2018 21:31 UTC

Return-Path: <alexey.melnikov@isode.com>
X-Original-To: extra@ietfa.amsl.com
Delivered-To: extra@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 523E912E036 for <extra@ietfa.amsl.com>; Mon, 3 Dec 2018 13:31:39 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.001
X-Spam-Level:
X-Spam-Status: No, score=-2.001 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=isode.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id asyN1VLNblQ6 for <extra@ietfa.amsl.com>; Mon, 3 Dec 2018 13:31:38 -0800 (PST)
Received: from waldorf.isode.com (waldorf.isode.com [62.232.206.188]) by ietfa.amsl.com (Postfix) with ESMTP id EC0BB12D4ED for <extra@ietf.org>; Mon, 3 Dec 2018 13:31:37 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1543872697; d=isode.com; s=june2016; i=@isode.com; bh=z3vWAw7KVJgQAJv7kOUs7vDi9Q4LCkQ7BAnReIENe+U=; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version: In-Reply-To:References:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description; b=vrfrcCWXbHAWo1KwjT05p/Sdjt8b5e4zBvJ9ClDnz6r9HezZyX01KEoh4YAs8q7OCAY0E4 GmgANKs4OAZcg+7uVTaTNlnqRBNPISXC6Q0HeL1XhLhmx3TzzD0aQqk93zTIHaBzlAkgJe TXkvjJjxWvhlfp/yCvJ/gYBWzJhCsSM=;
Received: from [172.20.1.215] (dhcp-215.isode.net [172.20.1.215]) by waldorf.isode.com (submission channel) via TCP with ESMTPSA id <XAWguAArG7XM@waldorf.isode.com>; Mon, 3 Dec 2018 21:31:37 +0000
To: Ken Murchison <murch@fastmail.com>, extra <extra@ietf.org>
References: <2a2f0f33-b056-1a04-aa11-8b8d0a448a4c@isode.com> <fb5a5946-3c09-fa42-7f9e-fc0344e134da@fastmail.com>
From: Alexey Melnikov <alexey.melnikov@isode.com>
Message-ID: <c5144624-b0d3-ddbb-43ce-6b17184f4297@isode.com>
Date: Mon, 3 Dec 2018 21:31:00 +0000
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.0
In-Reply-To: <fb5a5946-3c09-fa42-7f9e-fc0344e134da@fastmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB
Content-transfer-encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/extra/PiayqQ8d1jMkmORh89gJDurIF7Y>
Subject: Re: [Extra] AD review of draft-ietf-extra-sieve-fcc-06.txt
X-BeenThere: extra@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Email mailstore and eXtensions To Revise or Amend <extra.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/extra>, <mailto:extra-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/extra/>
List-Post: <mailto:extra@ietf.org>
List-Help: <mailto:extra-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/extra>, <mailto:extra-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 03 Dec 2018 21:31:39 -0000

Hi Ken,

So in -07, I now see:

3.1.1.  Imap4flags Extension

    Usage: :fcc <mailbox: string> [:flags <list-of-flags: string-list>]

3.1.2.  Mailbox Extension

    Usage: :fcc <mailbox: string> [:create]


3.1.3.  Special-Use Extension

   Usage: :fcc <mailbox: string> [:specialuse <special-use-flag: string>]


Is your intention that :fcc always goes first? If not, you might want to 
clarify that.


3.2.  Collected Grammar

    For convenience, the "FCC" syntax element is defined here using ABNF
    [RFC5234] so that it can be augmented by other extensions.

    FCC         = ":fcc" string *FCC-OPTS

I am somewhat uncomfortable with the above, as it omits all whitespace 
delimiters between tokens. If you are going to keep this, you should add 
a comment explaining that this is done once lexical analyzer extracted 
different non-space elements.

Best Regards,

Alexey