Re: [Extra] Comments on draft-ietf-extra-sieve-special-use-03

Stephan Bosch <stephan.bosch@dovecot.fi> Mon, 29 October 2018 12:06 UTC

Return-Path: <stephan.bosch@dovecot.fi>
X-Original-To: extra@ietfa.amsl.com
Delivered-To: extra@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 82765130ED0 for <extra@ietfa.amsl.com>; Mon, 29 Oct 2018 05:06:46 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.2
X-Spam-Level:
X-Spam-Status: No, score=-4.2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wo6BT_ShA7Sx for <extra@ietfa.amsl.com>; Mon, 29 Oct 2018 05:06:45 -0700 (PDT)
Received: from mail.dovecot.fi (wursti.dovecot.fi [94.237.32.243]) by ietfa.amsl.com (Postfix) with ESMTP id D84BB130EC0 for <extra@ietf.org>; Mon, 29 Oct 2018 05:06:44 -0700 (PDT)
Received: from [192.168.1.104] (lab.inertia-technology.com [217.119.239.130]) by mail.dovecot.fi (Postfix) with ESMTPSA id E4B5B2B3C8D; Mon, 29 Oct 2018 14:06:32 +0200 (EET)
To: Alexey Melnikov <alexey.melnikov@isode.com>, extra@ietf.org
References: <a519d410-babd-36ee-8343-6fe3bea3a414@isode.com>
From: Stephan Bosch <stephan.bosch@dovecot.fi>
Message-ID: <d9522e99-5078-01d5-3645-c3b7c8b36ba3@dovecot.fi>
Date: Mon, 29 Oct 2018 13:06:23 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <a519d410-babd-36ee-8343-6fe3bea3a414@isode.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Archived-At: <https://mailarchive.ietf.org/arch/msg/extra/V_xkLBKrfoyYaWcROIZZl8R7yx4>
Subject: Re: [Extra] Comments on draft-ietf-extra-sieve-special-use-03
X-BeenThere: extra@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Email mailstore and eXtensions To Revise or Amend <extra.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/extra>, <mailto:extra-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/extra/>
List-Post: <mailto:extra@ietf.org>
List-Help: <mailto:extra-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/extra>, <mailto:extra-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 29 Oct 2018 12:06:46 -0000

Hi Alexey,


Op 28-10-2018 om 16:07 schreef Alexey Melnikov:
> Hi all,
> I've just tried to implement this Sieve extension and I have a couple of
> comments:
>
> 3.  Test "specialuse_exists"
>
>     Usage:  specialuse_exists [<mailbox: string>]
>                               <special-use-flags: string-list>
>
> This defines an optional argument. According to the base Sieve RFC 5228,
> optional arguments must be tagged:
>
>    2.6.1.  Positional Arguments
>
>     Positional arguments are given to a command that discerns their
>     meaning based on their order.  When a command takes positional
>     arguments, all positional arguments must be supplied and must be in
>     the order prescribed.
>
>   and
>
>    2.6.3.  Optional Arguments
>
>     Optional arguments are exactly like tagged arguments except that they
>     may be left out, in which case a default value is implied.  Because
>     optional arguments tend to result in shorter scripts, they have been
>     used far more than tagged arguments.
>
> So I don't think you can have "mailbox" being positional without a tag!

Then what about the entirety of the "imap4flags" extension? Lots of 
tag-less optional arguments can be found there. I am not against having 
some ":mailbox" tag here, but the current syntax does make things more 
concise.

> 4.  ":specialuse" Argument to "fileinto" Command
>
>     Usage:  fileinto [:specialuse <special-use-flag: string>]
>                      <mailbox: string>
>
> Can I suggest that all special-use-flag strings should not include the
> leading "\" character? It requires escaping in Sieve, so people might
> make mistakes when writing scripts.

I have no strong opinion about that. Disadvantage of doing that is that 
it can be confusing for people with IMAP experience and it becomes 
inconsistent with imap4flags.

Anyone else want to pitch in?

Regards,

-- 

Stephan Bosch
Senior Developer

Phone: +49 2761 75252 00  Fax: +49 2761 75252 30
Email: stephan.bosch@dovecot.fi


-------------------------------------------------------------------------------------
Open-Xchange AG,  Rollnerstr. 14, 90408 Nuremberg, District Court Nuremberg HRB 24738
Managing Board: Rafael Laguna de la Vera, Carsten Dirks, Uwe Reumuth
Chairman of the Board: Richard Seibt

Dovecot Oy, Lars Sonckin Kaari 10, 02600 Espoo, Finland
Managing Director: Markku Kenttä
Chairman of the Board: Timo Sirainen
Board Member: Carsten Dirks

-------------------------------------------------------------------------------------