Re: [Extra] AD review of draft-ietf-extra-imap-fetch-preview-00

Michael Slusarz <michael.slusarz@open-xchange.com> Thu, 14 February 2019 02:49 UTC

Return-Path: <michael.slusarz@open-xchange.com>
X-Original-To: extra@ietfa.amsl.com
Delivered-To: extra@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 52263130EBE for <extra@ietfa.amsl.com>; Wed, 13 Feb 2019 18:49:21 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.3
X-Spam-Level:
X-Spam-Status: No, score=-4.3 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=open-xchange.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BRchEQi9ftJZ for <extra@ietfa.amsl.com>; Wed, 13 Feb 2019 18:49:19 -0800 (PST)
Received: from mx4.open-xchange.com (alcatraz.open-xchange.com [87.191.39.187]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B9E70130DE4 for <extra@ietf.org>; Wed, 13 Feb 2019 18:49:19 -0800 (PST)
Received: from open-xchange.com (imap.open-xchange.com [10.20.30.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx4.open-xchange.com (Postfix) with ESMTPS id 9F93B6A258; Thu, 14 Feb 2019 03:49:17 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=open-xchange.com; s=201705; t=1550112557; bh=aNOZckM2QfPMKHC4xjlaFyaN/qDiopEdTSY+ussA55c=; h=Date:From:To:In-Reply-To:References:Subject:From; b=iZrJipxdPYkwc3NGEtu9wc7w3jTIskVEsaLPmdDZfBZiU/exmSld97GAC+H82jt9x zZdsUL7cBeccRF+n7jLAOhe9cknCVRTAxojmyzv9opIpsskkp/mN258Oy9VKFkGsHJ rCfKVSSAR0aSIWjYY1w2/3fb9X7gEUXYB5GOKjnQT/BTOHsAvzxIggNfhBSsksS+rC GRCtkYTLJ2W7smu7/HoOa4x6LcJn6339iLQSYlpSpnkYj1BCcYefrR4DnMg3y5tM1U yKu7TtgxaugvcicL04uK31fI5iprTVCHnNzx5O38RgGAgVYsQPfpK38NFnnHS1qohP 3KkwX9XaU6QXQ==
Received: from appsuite-gw1.open-xchange.com (appsuite-gw1.open-xchange.com [10.20.28.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by open-xchange.com (Postfix) with ESMTPSA id 8FB983C0856; Thu, 14 Feb 2019 03:49:17 +0100 (CET)
Date: Wed, 13 Feb 2019 19:49:17 -0700 (MST)
From: Michael Slusarz <michael.slusarz@open-xchange.com>
To: Alexey Melnikov <alexey.melnikov@isode.com>, extra@ietf.org
Message-ID: <440537508.14285.1550112557514@appsuite.open-xchange.com>
In-Reply-To: <a083d6e1-d522-6944-4895-da731551312f@isode.com>
References: <8c0e5e45-5646-f609-354a-077594228b9d@isode.com> <1755730477.52872.1548118101625@appsuite.open-xchange.com> <b4a48153-0d51-4ec6-00a5-6a30743d9de0@isode.com> <a083d6e1-d522-6944-4895-da731551312f@isode.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-Priority: 3
Importance: Medium
X-Mailer: Open-Xchange Mailer v7.10.1-Rev7
X-Originating-Client: open-xchange-appsuite
Archived-At: <https://mailarchive.ietf.org/arch/msg/extra/evVLbgZbss06H4u_J2DnJLVGX-o>
Subject: Re: [Extra] AD review of draft-ietf-extra-imap-fetch-preview-00
X-BeenThere: extra@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Email mailstore and eXtensions To Revise or Amend <extra.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/extra>, <mailto:extra-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/extra/>
List-Post: <mailto:extra@ietf.org>
List-Help: <mailto:extra-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/extra>, <mailto:extra-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Feb 2019 02:49:21 -0000

> On January 23, 2019 at 8:11 AM Alexey Melnikov <alexey.melnikov@isode.com> wrote:
> 
> 1 small comment on the latest version:
> 
> On 22/01/2019 10:57, Alexey Melnikov wrote:
> > On 22/01/2019 00:48, Michael Slusarz wrote:
> >>> On January 14, 2019 at 4:59 AM Alexey Melnikov 
> >>> <alexey.melnikov@isode.com> wrote:
>   [snip]
> >>>
> >>>> In Section 7:
> >>>>
> >>>>     The following syntax specification uses the augmented Backus-Naur
> >>>>     Form (BNF) as described in ABNF [RFC5234].  It includes 
> >>>> definitions
> >>>>     from IMAP [RFC3501].
> >>>>
> >>>>       capability        =/ "PREVIEW=FUZZY"
> >>>>
> >>>> This doesn't quite much what you specify in Section 1.
> >>>> Maybe change it to:
> >>>>
> >>>>          capability        =/ "PREVIEW=" preview-alg
> >>>> ?
> >>> That looks correct to me.
> 
> You forgot to include this change in the latest revision of the document.

Added to latest draft.

Additionally, on further review, realized that any future modifier would also need to be listed as a CAPABILITY. (LAZY doesn't need to be listed, as it is implied with PREVIEW=FUZZY).  So I altered the capability string to:

     capability        =/ "PREVIEW=" (preview-alg / preview-mod-ext)

michael