[Extra] Comments on draft-ietf-extra-sieve-special-use-03

Alexey Melnikov <alexey.melnikov@isode.com> Sun, 28 October 2018 15:07 UTC

Return-Path: <alexey.melnikov@isode.com>
X-Original-To: extra@ietfa.amsl.com
Delivered-To: extra@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 664DA128CE4 for <extra@ietfa.amsl.com>; Sun, 28 Oct 2018 08:07:11 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.001
X-Spam-Level:
X-Spam-Status: No, score=-2.001 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=isode.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cD0Iij6hIi_E for <extra@ietfa.amsl.com>; Sun, 28 Oct 2018 08:07:10 -0700 (PDT)
Received: from waldorf.isode.com (waldorf.isode.com [62.232.206.188]) by ietfa.amsl.com (Postfix) with ESMTP id D5A64127333 for <extra@ietf.org>; Sun, 28 Oct 2018 08:07:09 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1540739229; d=isode.com; s=june2016; i=@isode.com; bh=MOFSqLim8r8ZfygxIM6vsCj74Hd/M70mbuPEBGHFkM8=; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version: In-Reply-To:References:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description; b=Ht9FlNB59f35gr/DpfLL9cbG9H9hb51zFqxxQjMxbZcTWH+7s31JXa/aWOP97Z2UsSl8yb 0oyR/d6nJx0kbyk5uVPL07uJCx458yxa9oWesa8ZRaUqLQ3vc9omhktWPhWPrguAQAV+8a V16RORN3gfgoLonQwbDVm2L/I5IHfm8=;
Received: from [192.168.0.7] (cpc121086-nmal24-2-0-cust54.19-2.cable.virginm.net [77.97.145.55]) by waldorf.isode.com (submission channel) via TCP with ESMTPSA id <W9XQnAArG8O2@waldorf.isode.com>; Sun, 28 Oct 2018 15:07:09 +0000
To: extra@ietf.org
From: Alexey Melnikov <alexey.melnikov@isode.com>
Openpgp: preference=signencrypt
Message-ID: <a519d410-babd-36ee-8343-6fe3bea3a414@isode.com>
Date: Sun, 28 Oct 2018 15:07:10 +0000
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-transfer-encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/extra/mY-vATaLf8wFwGKZ5dESjnQVod0>
Subject: [Extra] Comments on draft-ietf-extra-sieve-special-use-03
X-BeenThere: extra@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Email mailstore and eXtensions To Revise or Amend <extra.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/extra>, <mailto:extra-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/extra/>
List-Post: <mailto:extra@ietf.org>
List-Help: <mailto:extra-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/extra>, <mailto:extra-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 28 Oct 2018 15:07:12 -0000

Hi all,
I've just tried to implement this Sieve extension and I have a couple of
comments:

3.  Test "specialuse_exists"

   Usage:  specialuse_exists [<mailbox: string>]
                             <special-use-flags: string-list>

This defines an optional argument. According to the base Sieve RFC 5228,
optional arguments must be tagged:

  2.6.1.  Positional Arguments

   Positional arguments are given to a command that discerns their
   meaning based on their order.  When a command takes positional
   arguments, all positional arguments must be supplied and must be in
   the order prescribed.

 and

  2.6.3.  Optional Arguments

   Optional arguments are exactly like tagged arguments except that they
   may be left out, in which case a default value is implied.  Because
   optional arguments tend to result in shorter scripts, they have been
   used far more than tagged arguments.

So I don't think you can have "mailbox" being positional without a tag!

4.  ":specialuse" Argument to "fileinto" Command

   Usage:  fileinto [:specialuse <special-use-flag: string>]
                    <mailbox: string>

Can I suggest that all special-use-flag strings should not include the
leading "\" character? It requires escaping in Sieve, so people might
make mistakes when writing scripts.

Best Regards,
Alexey