Re: [Gen-art] Review: draft-ietf-codec-oggopus-10

"Timothy B. Terriberry" <tterribe@xiph.org> Fri, 15 January 2016 23:52 UTC

Return-Path: <tterribe@xiph.org>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 746FC1B33DC; Fri, 15 Jan 2016 15:52:17 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -5.313
X-Spam-Level:
X-Spam-Status: No, score=-5.313 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HELO_MISMATCH_ORG=0.611, HOST_MISMATCH_COM=0.311, RCVD_IN_DNSWL_HI=-5, SPF_SOFTFAIL=0.665] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Li8kWziT1UH9; Fri, 15 Jan 2016 15:52:15 -0800 (PST)
Received: from smtp.mozilla.org (mx1.scl3.mozilla.com [63.245.214.155]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C0EED1B33D5; Fri, 15 Jan 2016 15:52:15 -0800 (PST)
Received: from localhost (localhost6.localdomain [127.0.0.1]) by mx1.mail.scl3.mozilla.com (Postfix) with ESMTP id 3DE81C30C1; Fri, 15 Jan 2016 23:52:15 +0000 (UTC)
X-Virus-Scanned: amavisd-new at mozilla.org
Received: from smtp.mozilla.org ([127.0.0.1]) by localhost (mx1.mail.scl3.mozilla.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id k46MPbjlK82S; Fri, 15 Jan 2016 23:52:15 +0000 (UTC)
Received: from [100.111.131.226] (unknown [104.135.3.226]) (Authenticated sender: tterriberry@mozilla.com) by mx1.mail.scl3.mozilla.com (Postfix) with ESMTPSA id 01AC5C30B3; Fri, 15 Jan 2016 23:52:15 +0000 (UTC)
Message-ID: <5699862E.7040001@xiph.org>
Date: Fri, 15 Jan 2016 15:52:14 -0800
From: "Timothy B. Terriberry" <tterribe@xiph.org>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:29.0) Gecko/20100101 SeaMonkey/2.26
MIME-Version: 1.0
To: "Joel M. Halpern" <jmh@joelhalpern.com>, Ralph Giles <giles@thaumas.net>
References: <569820FC.7050309@nostrum.com> <56997225.9000405@joelhalpern.com> <569983AB.9020704@thaumas.net> <56998526.2020508@joelhalpern.com>
In-Reply-To: <56998526.2020508@joelhalpern.com>
Content-Type: text/plain; charset="UTF-8"; format="flowed"
Content-Transfer-Encoding: 7bit
Archived-At: <http://mailarchive.ietf.org/arch/msg/gen-art/-0zQYaHqdARFmFDHlG9Gs8hU3mQ>
Cc: General Area Review Team <gen-art@ietf.org>, draft-ietf-codec-oggopus.all@ietf.org, IETF discussion list <ietf@ietf.org>
Subject: Re: [Gen-art] Review: draft-ietf-codec-oggopus-10
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Jan 2016 23:52:17 -0000

Joel M. Halpern wrote:
> On the minor note, I had not realized those were already relevant
> parameters.  Anyone using this can reasonably be expected to know that,
> so it is not a big deal.  Given that it would only take one sentence, it
> might be nice to add the statement anyway.

We can certainly add text to point out that this is a limitation of RFC 
6716, e.g., "The duration of an Opus packet as defined in RFC 6716 can 
be any multiple..."

For 48 kHz, we might say, "It is possible to run an Opus decoder at 
other sampling rates, but all of them evenly divide 48 kHz. Therefore, 
the value in the granule position field always counts samples assuming a 
48 kHz decoding rate..."