Re: [Gen-art] Gen-art LC review of draft-ietf-nfsv4-minorversion2-dot-x-39

Tom Haynes <thomas.haynes@primarydata.com> Thu, 17 December 2015 02:19 UTC

Return-Path: <thomas.haynes@primarydata.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 12E271A0089 for <gen-art@ietfa.amsl.com>; Wed, 16 Dec 2015 18:19:32 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.901
X-Spam-Level:
X-Spam-Status: No, score=-1.901 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, SPF_PASS=-0.001] autolearn=unavailable
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id O3sCtzyX9-3s for <gen-art@ietfa.amsl.com>; Wed, 16 Dec 2015 18:19:29 -0800 (PST)
Received: from mail-pf0-x230.google.com (mail-pf0-x230.google.com [IPv6:2607:f8b0:400e:c00::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 52E591A0076 for <gen-art@ietf.org>; Wed, 16 Dec 2015 18:19:29 -0800 (PST)
Received: by mail-pf0-x230.google.com with SMTP id o64so21966113pfb.3 for <gen-art@ietf.org>; Wed, 16 Dec 2015 18:19:29 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=primarydata-com.20150623.gappssmtp.com; s=20150623; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=OFc3x/Epu7vSz+nEa2+JfdMimLQHvNohW0UaGU48/Jk=; b=Fl3DbHw0rdWJszDs98MiZVyQAReES6rPywph7KU1J6HIW217c09wFk5XtMxBSTGGpE d0VqkixJ/0r7za7ytNCYrT5R1M00xeYIAPoEIOSfOBQ6GrADEmpq6dL8SXz05zuCEyvp a3VAMu4XvAnWRdWXG41r6fZPvUy6q0+t/+EpU9YLC9gDkPcWh0TFuDB7VR4irD9gxRE1 SvzMNTJsjpcTjuPIJ5a9MiYNaiCw6xXioeOVw407A1zDgiw8rMtHEuUev5zKK//1ZBLV 8mntza/ZwdetfnR+qDIZUKdW60LK6e9fVv3tBpthKP0WP93drzmj3gke5NIsw0btKBI9 U0TQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:content-type:mime-version:subject:from :in-reply-to:date:cc:content-transfer-encoding:message-id:references :to; bh=OFc3x/Epu7vSz+nEa2+JfdMimLQHvNohW0UaGU48/Jk=; b=dQtjVEZ5WZnPIfSX5sOkmNBbwlKB1IMChok8u3aM2uxJ/he8GgvnooJoefKMzdhWUg IDhM9zipx90BvBaBPKMBCOh6GNua6Gqz3MTNj687sz5cuPzyzXIUw0s9yN82PP093tFB uviTDxNtfib/eAAiXY+AOliJ8seCFV9xKAxdy+AGuDCL5eMbYSKnXf9yQv1P3U3WpjGm zHvYYMXGXvzdaUUIED3TCG54/yMkPnL7Y+PaEx7awiImAhyCOE53Fs5XI1T1xDEMDX8v BlviQLjuYSwvgg8Igo/AZERCMWFYxhN5rEtnTkW5X6bzbr2wmOUh6A6si9hw1ixgM7AU cchg==
X-Gm-Message-State: ALoCoQmpf/bfJqI5vc3RV5RtkvO/a5BlyNvw9zRB0TpJhcYdhVD5B0kiB4k5EJ8ekhOgzP9tb75LsSCsVjlt6QTAh2Uw6+iGOQ==
X-Received: by 10.98.15.152 with SMTP id 24mr1896389pfp.57.1450318768951; Wed, 16 Dec 2015 18:19:28 -0800 (PST)
Received: from kinslayer.corp.primarydata.com (63-157-6-18.dia.static.qwest.net. [63.157.6.18]) by smtp.gmail.com with ESMTPSA id rz10sm11834397pac.29.2015.12.16.18.19.27 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 16 Dec 2015 18:19:28 -0800 (PST)
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 9.2 \(3112\))
From: Tom Haynes <thomas.haynes@primarydata.com>
In-Reply-To: <566E10D8.3040002@dial.pipex.com>
Date: Wed, 16 Dec 2015 18:19:25 -0800
Content-Transfer-Encoding: quoted-printable
Message-Id: <224DB6F8-608F-44E1-8D72-0BDAB8CA3120@primarydata.com>
References: <566E10D8.3040002@dial.pipex.com>
To: Elwyn Davies <elwynd@dial.pipex.com>
X-Mailer: Apple Mail (2.3112)
Archived-At: <http://mailarchive.ietf.org/arch/msg/gen-art/-B_TTyTqXWspCzYzUlIvblEiVrk>
Cc: General area reviewing team <gen-art@ietf.org>, draft-ietf-nfsv4-minorversion2-dot-x.all@ietf.org
Subject: Re: [Gen-art] Gen-art LC review of draft-ietf-nfsv4-minorversion2-dot-x-39
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 17 Dec 2015 02:19:32 -0000

> On Dec 13, 2015, at 4:44 PM, Elwyn Davies <elwynd@dial.pipex.com> wrote:
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.
> 
> Document: draft-ietf-nfsv4-minorversion2-dot-x-39.txt
> Reviewer: Elwyn Davies
> Review Date: 2015-12-13
> IETF LC End Date: 2015-12-09
> IESG Telechat date: (if known) -
> 
> Summary: Ready with nits.  The XDR specification appears to be a superset of the v4.1 XDR specification and combines a correction of the five remaining discrepancies between v4.1 and v4.0bis ( definition and use of the NFS4_OTHER_SIZE constant, addition and use of the ascii_REQUIRED4 type, modification of the typedef of linktext4). The additions of the 4.2 interface appears to match the specification in draft-ietf-nfsv4-minorversion2-39 except for two attribute typedef  items mentioned below.  One discrepancy would have no operational effect as the type used in the other draft  is an alias for the type used here but the clone_blksize error changes the size of the type.
> 
> I have checked that the extracted code is accepted by rpcgen and generates files as expected.
> 
> Major issues:
> None
> 
> Minor issues:
> None



Hi Elwyn,

Thanks for the review - sorry for the delay in responding, I’m just now surfacing from my job. :-)

Responses inline.

> 
> Nits/editorial comments:
> Observation:  It might be useful to note that this XDR specification is fully upwards compatible with the v4.0bis with the minor exception of the clientaddr4 structure which has been replaced by (strictly, aliased to) netaddr4 which has the same members with the same purposes but the names have changed (r_netid -> na_r_netid, r_addr ->na_r_addr).  This effectively fully reconverges the v4.0bis and v4.1 strands of the XDR.
> 

Shamelessly stolen almost verbatim!

> Line 1145: In draft-ietf-nfsv4-minorversion2-39 we have typedef length4 fattr4_space_freed
>                    whereas in this draft we have                           typedef uint64_t fattr4_space_freed

Fixed this in the XDR document.

> 
> Line 1149: In draft-ietf-nfsv4-minorversion2-39 we have typedef length4 fattr4_clone_blksize
>                    whereas in this draft we have                           typedef uint32_t fattr4_clone_blksize


And for this one, I made the change to uint32_t in draft-ietf-nfsv4-minorversion2-39 .

Thanks again!
Tom