Re: [Gen-art] Genart last call review of draft-ietf-calext-valarm-extensions-04

Ken Murchison <murch@fastmail.com> Mon, 15 February 2021 12:27 UTC

Return-Path: <murch@fastmail.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A48443A121B; Mon, 15 Feb 2021 04:27:14 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.198
X-Spam-Level:
X-Spam-Status: No, score=-0.198 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, NICE_REPLY_A=-0.001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=fastmail.com header.b=nFj5CVMn; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=lHB1Eyv1
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RoxQEih8G9aB; Mon, 15 Feb 2021 04:27:13 -0800 (PST)
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2D1933A1219; Mon, 15 Feb 2021 04:27:13 -0800 (PST)
Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 2C8005C009B; Mon, 15 Feb 2021 07:27:12 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Mon, 15 Feb 2021 07:27:12 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-type:content-transfer-encoding; s=fm2; bh=s 12W5IjmeldeaoKkJurQTHBnYWOQqhhuFCevbXbu2ZA=; b=nFj5CVMno4T3j7kq6 S72Rjv1XisXUnZDYaz8fJ29Yui16aZ25VNfDliQYuX8g4obSCKH6Goq3qXaB0h3A L6WhM5QmL9NTBX5SIJ2bulKFdfealoYHh2l7XwIGsfmn90/2xGnN/lvVxkzcRRgt E7KMU08QJ2ZMjxBMZ3P+PCiQYJNUEAP2RqSp9Ws4DRzLcBd45IVT8QDSdoKOLG1S RWl3TO0sSc3rG5vqUBb3mQjajjUN0dTPzaA6AL4haBvsN7a5tcW5fm4aHLt3vegy R2zZcnF5yXsRFJzPzpjXspV2PRCith2wGI5f59c75OT+mBVJww4CDjRMBVQTeBaM GU21Q==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=s12W5IjmeldeaoKkJurQTHBnYWOQqhhuFCevbXbu2 ZA=; b=lHB1Eyv1QwXo6Msix4xCEKM/Twgx+dh6Szq2xxvOL1pOhSxuctWlc4E0O 4fC3eNYBFlOajze8xRn3TBYWG18dlcJ4XLw1KlDUSZV638ON2v+Ueu7P3hxnRUT2 2ww2F6yNs2/U97w+Q4FCbbTtqNQA5cyhwrPupihkbAPqTrOHotArDiPMB0y04qIv qy8bTU4OnypcyW2A+fT4IBBr2P6i6JR+ciA58fG41rnEq0rpu9Tgypvmg6LeaZwJ Ae48MYXyMZ0hXKEmBf61F4XZgk1ofj5wTM1Hi8zOT1hVRKyNhudZOnjinQZbv3hb jjIzLB0/wmJXsOD0TAZcUU/O1/b7w==
X-ME-Sender: <xms:n2gqYLYENYmEohNkb2IDPXeZqz1evsn35hAU-yvQfcb25mZ9esGDVQ> <xme:n2gqYKahjIHaj1suKpA5M6LxNiT1puFZCUPj_1ft9keglzU6ohg9q8t6gEZucvayu P7o-WrPGZzQDw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrieekgdefjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepuffvfhfhkffffgggjggtgfesthekre dttdefjeenucfhrhhomhepmfgvnhcuofhurhgthhhishhonhcuoehmuhhrtghhsehfrghs thhmrghilhdrtghomheqnecuggftrfgrthhtvghrnhepvdeutedugeeiffeitedvhfeiud etvdegjeekkedutedvvddvudetjeevgffhvdeknecuffhomhgrihhnpehivghtfhdrohhr ghenucfkphepjeegrdejjedrkeehrddvhedtnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhhurhgthhesfhgrshhtmhgrihhlrdgtohhm
X-ME-Proxy: <xmx:n2gqYN9PhHIBZI87B7zuF6x-3VETEQYtRXuGgUps9AJ5V0rsfhweaw> <xmx:n2gqYBrIj-qSzYccKE5BZTkoWChSH58HD0H8FJjgSFxdz1zCOluJzg> <xmx:n2gqYGpTO00pUYAs8m34WT0GVZEHT-qsZjgj5li94CR9uL4lVFOQlw> <xmx:oGgqYN2jkW5C43gcgmWcMp4yGjhN9ZUJLxrYg4kha8ApcfGiD-A_Wg>
Received: from [192.168.1.22] (cpe-74-77-85-250.buffalo.res.rr.com [74.77.85.250]) by mail.messagingengine.com (Postfix) with ESMTPA id 7F69D240057; Mon, 15 Feb 2021 07:27:11 -0500 (EST)
To: Roni Even <ron.even.tlv@gmail.com>, gen-art@ietf.org
Cc: calsify@ietf.org, draft-ietf-calext-valarm-extensions.all@ietf.org, last-call@ietf.org
References: <161338513250.5032.11173671129331374190@ietfa.amsl.com>
From: Ken Murchison <murch@fastmail.com>
Message-ID: <a87b7942-9976-39c5-43dd-23f4acfa9a6a@fastmail.com>
Date: Mon, 15 Feb 2021 07:27:10 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0
MIME-Version: 1.0
In-Reply-To: <161338513250.5032.11173671129331374190@ietfa.amsl.com>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/-MLxNOJA8yJxBUIysfbNFTFZC7M>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-calext-valarm-extensions-04
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 15 Feb 2021 12:27:15 -0000

Hi Roni,

Thanks for the review.  Your comment is addressed below.


On 2/15/21 5:32 AM, Roni Even via Datatracker wrote:
> Reviewer: Roni Even
> Review result: Ready with Nits
>
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
>
> For more information, please see the FAQ at
>
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
>
> Document: draft-ietf-calext-valarm-extensions-??
> Reviewer: Roni Even
> Review Date: 2021-02-15
> IETF LC End Date: 2021-02-16
> IESG Telechat date: Not scheduled for a telechat
>
> Summary:
> The document is ready for publication as standard track RFC with nits
>
> Major issues:
>
> Minor issues:
>
> Nits/editorial comments:
>
> 1. The structured-location is optional so if it is not specified for proximity
> I assume that it implies current location?


STRUCTURED-LOCATION is optional because its not used for PROXIMITY: 
[DIS]CONNECT.  I've made the following change to the text:

              <t hangText="Description:">This property is used to
              indicate that an alarm has a location-based trigger. Its
              value identifies the direction of motion used to trigger
-            the alarm. One or more location values are set using
+            the alarm. One or more location values MUST be set using
              "STRUCTURED-LOCATION" properties.</t>

Is this sufficient?

-- 
Kenneth Murchison
Senior Software Developer
Fastmail US LLC