IETF Logo Mail Archive

Re: [Gen-art] Genart last call review of draft-ietf-lamps-cmp-algorithms-12

Lars Eggert <lars@eggert.org> Wed, 25 May 2022 09:01 UTC

Return-Path: <lars@eggert.org>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F294CC14F608; Wed, 25 May 2022 02:01:31 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.095
X-Spam-Level:
X-Spam-Status: No, score=-2.095 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_BLOCKED=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=eggert.org
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CSuSwS4a1tEl; Wed, 25 May 2022 02:01:28 -0700 (PDT)
Received: from mail.eggert.org (mail.eggert.org [91.190.195.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1E0A5C14F6F8; Wed, 25 May 2022 02:01:25 -0700 (PDT)
Received: from smtpclient.apple (unknown [IPv6:2a00:ac00:4000:400:e91e:c034:a8d7:562e]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.eggert.org (Postfix) with ESMTPSA id 0745B1DB724; Wed, 25 May 2022 12:01:12 +0300 (EEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eggert.org; s=dkim; t=1653469273; bh=lAWN0Tw8uyx1MVtkZw94oLXk8muWMyPy3KuFjPf+xAk=; h=Subject:From:In-Reply-To:Date:Cc:References:To; b=AGyFWmY7JwNJ2YeALO09XpMAyKtDWzDzmxpE2XNXQIshg4DZOYyZ0SH8PDAd86/Ok nakmtOyfmd+BDOvUqdUkBudMec/dgC3if1B3l6q+n6O4twp1B8rZmoqeJy6V0y9Xl8 84VBrKiza6BMqWV5nXvF8F93u33GZfGb27kJW+es=
Content-Type: multipart/signed; boundary="Apple-Mail=_942FFA43-C582-4414-9A41-43C3B95D7468"; protocol="application/pgp-signature"; micalg="pgp-sha512"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.100.31\))
From: Lars Eggert <lars@eggert.org>
In-Reply-To: <165182926726.21673.10146825579223111190@ietfa.amsl.com>
Date: Wed, 25 May 2022 12:01:12 +0300
Cc: gen-art@ietf.org, spasm@ietf.org, last-call@ietf.org, draft-ietf-lamps-cmp-algorithms.all@ietf.org
Message-Id: <92EF6982-9D3B-4FA5-AFAB-7335BD2F35C9@eggert.org>
References: <165182926726.21673.10146825579223111190@ietfa.amsl.com>
To: Dan Romascanu <dromasca@gmail.com>
X-MailScanner-ID: 0745B1DB724.A3ECC
X-MailScanner: Not scanned: please contact your Internet E-Mail Service Provider for details
X-MailScanner-From: lars@eggert.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/-yk35wgWL7PmRKyIU_LkAELg_Lc>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-lamps-cmp-algorithms-12
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 25 May 2022 09:01:32 -0000

Dan, thank you for your review. I have entered a No Objection ballot for this document.

Lars


> On 2022-5-6, at 12:27, Dan Romascanu via Datatracker <noreply@ietf.org> wrote:
> 
> Reviewer: Dan Romascanu
> Review result: Ready with Nits
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-ietf-lamps-cmp-algorithms-12
> Reviewer: Dan Romascanu
> Review Date: 2022-05-06
> IETF LC End Date: 2022-05-11
> IESG Telechat date: Not scheduled for a telechat
> 
> Summary:
> 
> Ready with nits.
> 
> This document updates RFC 4210 describing the conventions for using concrete
> cryptographic algorithms with the Certificate Management Protocol (CMP), which
> is used to enroll and further manage the lifecycle of X.509 certificates. Its
> reading requires expertise and familiarity with previously published documents.
> The document is ready. I pointed to a few nits, most of them improvements on
> readability and orientation.
> 
> Major issues:
> 
> Minor issues:
> 
> Nits/editorial comments:
> 
> 1. It would be useful to provide references for terms at first occurrence. For
> example Section 2 directly mentions OOBCertHash, CertStatus, Challenge,
> PBMParameter, DHBMParameter, etc. without providing a reference.
> 
> 2. Section 2.2 - provide reference for X.509 at first occurrence (probably
> [RFC4210])
> 
> 3. For clarity and in order to avoid confusions it would be useful to expand MAC
> 
> 4. For clarity it would be useful to position Table 3 to start at top of the
> page to avoid split at printing
> 
> 
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art

v2.23.0 | Report a Bug | By Email