Re: [Gen-art] [Jsonpath] Genart last call review of draft-ietf-jsonpath-base-17

Glyn Normington <glyn.normington.work@gmail.com> Thu, 10 August 2023 21:30 UTC

Return-Path: <glyn.normington.work@gmail.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2206EC1522D7; Thu, 10 Aug 2023 14:30:10 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.104
X-Spam-Level:
X-Spam-Status: No, score=-2.104 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3LPnXU1gF_pf; Thu, 10 Aug 2023 14:30:07 -0700 (PDT)
Received: from mail-pg1-x536.google.com (mail-pg1-x536.google.com [IPv6:2607:f8b0:4864:20::536]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2B5ACC19E111; Thu, 10 Aug 2023 14:28:59 -0700 (PDT)
Received: by mail-pg1-x536.google.com with SMTP id 41be03b00d2f7-563f752774fso899324a12.1; Thu, 10 Aug 2023 14:28:59 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691702938; x=1692307738; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=EIi16dQCqlgBtrfoBmEXM+0qrlvONODNUIWNOO6z8s4=; b=Z/FcCUDsY7tQzZaaGQzGklx7z9l9q/YOIIRihkPuwyYgVD3XUTpeEpopRQXEdPU9Cx tjTIRvolweGzknMSxGmDc9nLuJKqzjiJmC4ZIf0chi4xvzgGhemxwG70e1nNBlvHYG0t xZ6fMawXGVdROFPkNzmmbW8/P901sur1EgsA/S1+IEMYG5c3C7uxdHOY3sXNsDOQWf/2 cxq4Pq+1TVej4LZDjtrRXNfNaQ4EzLVkAYFiFt47HV6rXU4SrjSosc+vCQwzoOqTaLii /Q02jXAaqwA4xnUCJIfPcB2ztUlCGG8+Q9DafQTNYSxcXyOdJL0e8B8jvOA8Rh43wzkx d3cw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691702938; x=1692307738; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EIi16dQCqlgBtrfoBmEXM+0qrlvONODNUIWNOO6z8s4=; b=CR5t/kK452l54DToTWFMNoiSJS8zNPdbFAm6y/oty30JzS4KOvy5LXKGnRcdaUF7AV HWTlpuHGqulqRmXp+f6VsVJBOIC4muBJ3hhsTty1PGZMekZEwx5c/WyyMghwGCVt53aJ es6vCJpXMk+EgNPN/CNyMRAEC3svmcyxhRT6BPTmG7xCSRWuYBMC9yDnmA+qCa7iA8kQ I1eOKBGl6LgBDBI9vdkknSMrlD0Tp0+M1x31GHEmKC6zLYqILBYT3CxJqdBqukVsfZjy lMRQqdWM/vQF4F9RwarV6eEetuFnOwSCnYnZCo9KTkSlRw3eM/esoMJInXcqGXkxXF+T isyg==
X-Gm-Message-State: AOJu0Ywf/Us4kM4qQdMSkVCDYfArbjoNHtyrgZfY0xSPDtHHKeVknfPH xAg57YgcV5V+FxVCKuP4ckM/kKMkNxQAipJtQfE3WkAWmm4=
X-Google-Smtp-Source: AGHT+IEaPkPtfNcxl4/98c7ZlE45cKt8oOiisEEmWwtF6Oxmc5E9Q4L1H55v8XSIzXXOkaHZBDRBgZ1Cf/PtP4/22ck=
X-Received: by 2002:a17:90b:4a84:b0:268:323e:99a2 with SMTP id lp4-20020a17090b4a8400b00268323e99a2mr2978708pjb.4.1691702938083; Thu, 10 Aug 2023 14:28:58 -0700 (PDT)
MIME-Version: 1.0
References: <169169150183.43222.18081751127010886819@ietfa.amsl.com>
In-Reply-To: <169169150183.43222.18081751127010886819@ietfa.amsl.com>
From: Glyn Normington <glyn.normington.work@gmail.com>
Date: Thu, 10 Aug 2023 22:31:10 +0100
Message-ID: <CANH0Gb+sb3ZXq0Og3m6n7n6Wp1CAs3stKRi5OQPtacWBTHbUJw@mail.gmail.com>
To: Linda Dunbar <linda.dunbar@futurewei.com>
Cc: gen-art@ietf.org, draft-ietf-jsonpath-base.all@ietf.org, jsonpath@ietf.org, last-call@ietf.org
Content-Type: multipart/alternative; boundary="000000000000b0a6730602984898"
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/0-46rHIEa1r7CteO2EWYHgsYiPk>
Subject: Re: [Gen-art] [Jsonpath] Genart last call review of draft-ietf-jsonpath-base-17
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Aug 2023 21:30:10 -0000

Hi Linda

Thanks for your review. Detailed responses inline.

As for the need for a standard, I think the WG Charter makes that clear:

"JSONPath was originally described by Stefan Goessner [...] but has never
had an official specification of any kind, and the 39+
implementations, while mostly compatible, differ in certain behaviors."

Regards,
Glyn

On Thu, 10 Aug 2023 at 19:19, Linda Dunbar via Datatracker <noreply@ietf.org>
wrote:

> Reviewer: Linda Dunbar
> Review result: Not Ready
>
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
>
> For more information, please see the FAQ at
>
> <https://wiki.ietf.org/en/group/gen/GenArtFAQ>.
>
> Document: draft-ietf-jsonpath-base-17
> Reviewer: Linda Dunbar
> Review Date: 2023-08-10
> IETF LC End Date: 2023-08-09
> IESG Telechat date: Not scheduled for a telechat
>
> Summary:
>
> The document specifies a method to parse the JSON objects to get values and
> specifies the syntax to retrieve a list of values. The document reads well.
>

Actually, the document does not specify how JSON documents are parsed, in
the sense of producing a syntax tree from a JSON document.


> However, like any software programs, errors can be encountered at run time
> even
> after careful review.
>

Section 2.1 of the document acknowledges that run time errors can occur,
e.g. because of resource depletion. As for bugs in implementations: those
need not concern the specification.


>
> Major issues:
> The major issue is that this document should not be “Standard Track”
> because:
> 1.      Existing parsers for JSON data don’t need to change to comply with
> the
> syntax specified in this document.


I don't understand this point. JSONPath is query support strictly layered
on top of JSON parsing.


> 2.      Like SQL, this document specified
> syntax may change as more ways being developed by implementers to parse the
> JSON objects.


I don't understand this point either as it addresses JSON parsing rather
than a query layer.


> 3.      It is not clear why IANA registration is needed.
>

Because, as we have seen in the WG, the five function extensions defined by
the document will need to be augmented. It is normal in such situations to
use IANA registration.


>
> Minor issues:
>
> Nits/editorial comments:
>
> Thanks, Linda Dunbar
>
>
> --
> JSONpath mailing list
> JSONpath@ietf.org
> https://www.ietf.org/mailman/listinfo/jsonpath
>