[Gen-art] GEN-Art LC review of draft-ietf-jose-cfrg-curves-05

"Roni Even" <ron.even.tlv@gmail.com> Mon, 08 August 2016 20:41 UTC

Return-Path: <ron.even.tlv@gmail.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6711B12B049; Mon, 8 Aug 2016 13:41:04 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.699
X-Spam-Level:
X-Spam-Status: No, score=-2.699 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wClB1_BwupsN; Mon, 8 Aug 2016 13:41:02 -0700 (PDT)
Received: from mail-wm0-x230.google.com (mail-wm0-x230.google.com [IPv6:2a00:1450:400c:c09::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 40E8C12B03F; Mon, 8 Aug 2016 13:40:59 -0700 (PDT)
Received: by mail-wm0-x230.google.com with SMTP id i5so164196948wmg.0; Mon, 08 Aug 2016 13:40:59 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:mime-version:thread-index :content-language; bh=U814r17fh4JgZWkX2o/ROB2Cu6MKuEeqKsw/yLBwkPI=; b=xWBq9HYhNGliNgN6FyKjcyq4L5eiyYnCj2zXGpBvf4WX1gO3fuxypACquqgplXI7w1 8UQi3JjCDbMY2UdzJcA+ok7/UHCnQIyKnEteQELkVjE1JkMfa5rxq1orUydSuxb9FMC3 QwVWLt+Q8XE/nEBKHOdFJoGYkJu/aNgG6my69Hzd/BJoxmT7926ky226EpPHQoJOQPTP OY0Hago8mzCk0e4zqAl+aS8qzG/irFrYJ/1hxQcKObGch/uwSNzRcZLlza3JufQpCfDV hFFUVuhtzPOqBrfFRNkkxWtonca5bAfuwFNAI4gBAFLgExViHn7niF07Mz5X1NIUsYiL 1KSA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :thread-index:content-language; bh=U814r17fh4JgZWkX2o/ROB2Cu6MKuEeqKsw/yLBwkPI=; b=FBcqFTDNKVlz2IbkZZ+a7bOVZhBUVGuhu3jclNbiR78+dorHqHO3EVZpQR4IA6R5zq Q3whh2qgyz1bkw8G2DvH20SN9EquLyCUbL+EplugqFe9ETyyAyMxrIkVmi5uLvuoDq+O z6LaVLPhUal51PLvZ33uxpwokxFtsJSh1fhHv5xA1r7dkFsQkriyM4Z+wc4+f2aZVLnW 2FWHpn1XtqpHIRLwKc2k5Gx5tyFif/ITrh6yRNwVMFu/kCvm7l2r92WBzYcRvsclvfT6 PiDMuCKp/dwJYNifHbpCsYpMj4kfida1wtaqtGiL+bV/PCIAtRMVODvfw43iyz3w3huo dIYg==
X-Gm-Message-State: AEkoouuG3P7jCfMN79l2U/6lRYOduoTJagb4oGKNDv+6zscTjtAnyK+tWifxY19J2gk+gw==
X-Received: by 10.28.26.5 with SMTP id a5mr19259500wma.27.1470688857265; Mon, 08 Aug 2016 13:40:57 -0700 (PDT)
Received: from RoniPC (bzq-79-176-39-238.red.bezeqint.net. [79.176.39.238]) by smtp.gmail.com with ESMTPSA id k186sm25347800wmd.13.2016.08.08.13.40.55 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 08 Aug 2016 13:40:56 -0700 (PDT)
From: "Roni Even" <ron.even.tlv@gmail.com>
To: <draft-ietf-jose-cfrg-curves.all@ietf.org>
Date: Mon, 8 Aug 2016 23:40:43 +0300
Message-ID: <010f01d1f1b5$22c31580$68494080$@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="----=_NextPart_000_0110_01D1F1CE.481110D0"
X-Mailer: Microsoft Outlook 14.0
Thread-Index: AdHxtQtW9TcPtDuhRR6Aj4U4csABzA==
Content-Language: he
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/0EzN5WChE4ZRT4ME2kASBI-XNDA>
Cc: gen-art@ietf.org, ietf@ietf.org
Subject: [Gen-art] GEN-Art LC review of draft-ietf-jose-cfrg-curves-05
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Aug 2016 20:41:04 -0000

I am the assigned Gen-ART reviewer for this draft. For background on
Gen-ART, please see the FAQ at
<http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.

Please resolve these comments along with any other Last Call comments you
may receive.

Document:  draft-ietf-jose-cfrg-curves-05

Reviewer: Roni Even

Review Date:2016-8-8

IETF LC End Date: 2016-8-12

IESG Telechat date: 

 

Summary: This draft is ready for publication as a standard track RFC.

 

 

Major issues:

 

Minor issues:

 

Nits/editorial comments:

1.	In the introduction "This document defines how those are to be used
algorithms in JOSE in interoperable manner." Change to "This document
defines how to use those algorithms in JOSE in interoperable manner."
2.	Section 1 "This document defines the conventions to be used" change
to "This document defines the conventions to use"
3.	I find the sentence "(Trying to apply ECDSA to those curves leads to
nasty corner-cases and produces odd   results.)"  may need some explanation
or reference.
4.	In the last paragraph of section 1 you have "the" twice.