Re: [Gen-art] review of draft-ietf-ecrit-additional-data-34.txt
Randall Gellens <randy@qti.qualcomm.com> Wed, 16 September 2015 19:43 UTC
Return-Path: <randy@qti.qualcomm.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1AAAB1A01C6 for <gen-art@ietfa.amsl.com>; Wed, 16 Sep 2015 12:43:05 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.011
X-Spam-Level:
X-Spam-Status: No, score=-9.011 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, GB_I_LETTER=-2, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PtJaUJn6LxEh for <gen-art@ietfa.amsl.com>; Wed, 16 Sep 2015 12:43:03 -0700 (PDT)
Received: from wolverine02.qualcomm.com (wolverine02.qualcomm.com [199.106.114.251]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 29DCE1A019B for <gen-art@ietf.org>; Wed, 16 Sep 2015 12:43:03 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=qti.qualcomm.com; i=@qti.qualcomm.com; q=dns/txt; s=qcdkim; t=1442432583; x=1473968583; h=message-id:in-reply-to:references:date:to:from:subject: cc:mime-version; bh=M0JQAQvUkfPtI/W3FHWCQSWj9ITlWsI9TJJpyyYuCbc=; b=JPifGQMzKcxs45q2i1dd/QWTgN7AoL6C6nUcco57mb3ynYpvm9GL9Uqc PxlTKoQQDSuuCYEO1JmTUjAHvEETHU0eLH4mu03HkwaTnAP7ctZcf7173 +wjVVxpTIlK6XB2Q/vvCj+ZK9PwCKW6AccRTeShlnnB3iv4a2oNChV3I5 w=;
X-IronPort-AV: E=McAfee;i="5700,7163,7926"; a="231896579"
Received: from ironmsg04-l.qualcomm.com ([172.30.48.19]) by wolverine02.qualcomm.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 16 Sep 2015 12:43:03 -0700
X-IronPort-AV: E=Sophos;i="5.17,541,1437462000"; d="scan'208";a="977099701"
Received: from nasanexm02f.na.qualcomm.com ([10.85.0.87]) by Ironmsg04-L.qualcomm.com with ESMTP/TLS/RC4-SHA; 16 Sep 2015 12:43:02 -0700
Received: from [99.111.97.136] (10.80.80.8) by nasanexm02f.na.qualcomm.com (10.85.0.87) with Microsoft SMTP Server (TLS) id 15.0.1076.9; Wed, 16 Sep 2015 12:43:01 -0700
Message-ID: <p0624061dd21f768ea19a@[99.111.97.136]>
In-Reply-To: <46064B02-E72A-441F-8DFF-7DF82669BE13@piuha.net>
References: <201509021019.t82AJwfk041328@givry.fdupont.fr> <46064B02-E72A-441F-8DFF-7DF82669BE13@piuha.net>
X-Mailer: Eudora for Mac OS X
Date: Wed, 16 Sep 2015 12:43:00 -0700
To: Jari Arkko <jari.arkko@piuha.net>, Francis Dupont <Francis.Dupont@fdupont.fr>
From: Randall Gellens <randy@qti.qualcomm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; format="flowed"
X-Random-Sig-Tag: 1.0b28
X-Random-Sig-Tag: 1.0b28
X-Originating-IP: [10.80.80.8]
X-ClientProxiedBy: NASANEXM01E.na.qualcomm.com (10.85.0.31) To nasanexm02f.na.qualcomm.com (10.85.0.87)
Archived-At: <http://mailarchive.ietf.org/arch/msg/gen-art/0n5gX93RlYaPLxR0yTY_8QQYN9s>
Cc: General Area Review Team <gen-art@ietf.org>, draft-ietf-ecrit-additional-data.all@tools.ietf.org
Subject: Re: [Gen-art] review of draft-ietf-ecrit-additional-data-34.txt
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Sep 2015 19:43:05 -0000
I've addressed all of Francis' comments (which I appreciate) and also reviewed all lowercase instances of the key words. At 2:03 PM +0200 9/3/15, Jari Arkko wrote: > Thanks for your review, Francis! > > Can the authors check the comments? Thanks. > > With regards to RFC 2119 keywords, if I understand the point correctly, > I wouldn't worry too much about the appearance of lower case keywords, > if they indeed are meant to be just English and not keywords. That is the > current practice since a long time ago. I don't think we need additional > text in the document to explain this. However, if there is a case where these > really are meant to be keywords, then they should, I think, be in capital > letters. > > Thanks, > > Jari > > On 02 Sep 2015, at 12:19, Francis Dupont <Francis.Dupont@fdupont.fr> wrote: > >> I am the assigned Gen-ART reviewer for this draft. The General Area >> Review Team (Gen-ART) reviews all IETF documents being processed >> by the IESG for the IETF Chair. Please treat these comments just >> like any other last call comments. >> >> For more information, please see the FAQ at >> >> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>. >> >> Document: draft-ietf-ecrit-additional-data-34.txt >> Reviewer: Francis Dupont >> Review Date: 20150828 >> IETF LC End Date: 20150824 >> IESG Telechat date: 20150903 >> >> Summary: Almost Ready >> >> Major issues: None >> >> Minor issues: >> This document uses and even redefines RFC 2119 keywords outside the >> *formal* wording of RFC 2119: quoting the RFC 2119 (Abstract): >> "These words are often capitalized." >> This formally means a keyword in lower case is still a keyword which >> must (MUST :-) be interpreted as described in RFC 2119. IMHO this is >> for very old IETF documents: any IETF document published less than 20 >> years ago uses full upper case keywords when they have to be interpreted >> so this statement in the RFC 2119 Abstract is more source of confusion >> than clarification. >> If it can be accepted I propose to add an exception for this document >> saying that RFC 2119 keywords are capitalized. >> >> Nits/editorial comments: >> - Abstract page 1: every emergency call carry -> carries >> >> - 1 page 4: every emergency call carry -> carries >> >> - 2 page 6: the place where I suggest to add that RFC 2119 keywords >> are capitalized and in general keywords are case sensitive. >> >> - 4.1.4 page 13: an example of a "may" and a "should" which are not >> RFC 2119 keywords but only common English. >> >> - 4.2.1 page 18: neccessarily -> necessarily >> >> - 4.3.8 page 27: defined . -> defined. >> >> - 5.2 page 36 and 5.3 page 38: >> I am afraid the provided-by construct in the example is unbalanced >> (i.e., <provided-by -> <provided-by>) >> >> - 8 page 62, 9 page 65 (twice): as security and privacy considerations >> can be read independently I suggest to replace the 3 "may"s by >> equivalent wordings ("can", "be allowed to", etc). >> >> - 10.1.9 page 70: registation -> registration >> >> - 10.4 pages 72 - 76 (many): >> The IESG <ietf@ietf.org> -> The IESG <iesg@ietf.org> >> >> - 10.6 page 82: ectit@ietf.org -> ecrit@ietf.org >> >> - 11 page 83: benefitted -> benefited >> >> Note I didn't check the schemas (even you had the nice attention to >> provide them directly, cf appendix B). I reviewed the 33 version >> (so at the exception of spelling errors I gave the 33.txt page numbers) >> and verified the 33-34 diff. >> >> Regards >> >> Francis.Dupont@fdupont.fr >> >> _______________________________________________ >> Gen-art mailing list >> Gen-art@ietf.org >> https://www.ietf.org/mailman/listinfo/gen-art > > > Content-Transfer-Encoding: 7bit > Content-Disposition: attachment; filename="signature.asc" > Content-Type: application/pgp-signature; name="signature.asc" > Content-Description: Message signed with OpenPGP using GPGMail > > Attachment converted: TiLand:signature 637.asc ( / ) (02AA4317) -- Randall Gellens Opinions are personal; facts are suspect; I speak for myself only -------------- Randomly selected tag: --------------- An algorithm must be seen to be believed. -- Donald Knuth
- [Gen-art] review of draft-ietf-ecrit-additional-d… Francis Dupont
- Re: [Gen-art] review of draft-ietf-ecrit-addition… Jari Arkko
- Re: [Gen-art] review of draft-ietf-ecrit-addition… Randall Gellens
- Re: [Gen-art] review of draft-ietf-ecrit-addition… Randall Gellens