Re: [Gen-art] Genart last call review of draft-ietf-mmusic-msrp-usage-data-channel-21

Christer Holmberg <christer.holmberg@ericsson.com> Thu, 13 August 2020 13:36 UTC

Return-Path: <christer.holmberg@ericsson.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A0D4A3A0C2D; Thu, 13 Aug 2020 06:36:26 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.102
X-Spam-Level:
X-Spam-Status: No, score=-2.102 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ql9yRMs-_7kc; Thu, 13 Aug 2020 06:36:24 -0700 (PDT)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2040.outbound.protection.outlook.com [40.107.20.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3D1323A0C2F; Thu, 13 Aug 2020 06:36:24 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BFkiSi84xrEm9Nw4k3NAjGxzo205wIp9ZjEvDSLClNGHA3cnKSuYGPJX3RdDec9/xtQEICrASOluForm4HR0RDalRbmZ8ROym+bHDu0B/Nxyud5ru0HWnktq0ovQR7RzZeLW7IYvqSmaMJmDm+rQ/Emb7eHII7WKJrVUp3eqhkCHNq8nHgVoFaFlkVKRK1YaqVlH4XcQIrQDkY7NuPXszURlv00Zm6INNKt3+l2hFIbw2SUreSmWX2YkR8vyfwTU9X7x/HDzvIeQuzRdxlmTLLhKPe4C8WZ+JUYKY25UwfKGyz7Y7Djp1/SsFgWnrir0cPNB5lJliEl26y8hSdM9rw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SZlj6Ks+qgjCiCX/g2ZoALRT+FQj7ucQrDOccr4T7Rs=; b=m30BwquP/zAg2JMcmZG9R3cbboHCEtuirh1RZvlLNDe8nBXCufzNm4XlSNBERKgCV3cOu3w66VMvzkbFiepsRPaJhnKO9jsHnGDZ9wWGXNAOc0aHcQRDP32cyd75bdX9tezJ9XBMcT3Wn8ad6mM+IChHXMNMc2Zg4ZJVgxjIhQonjBUAZ6sCOqYewNxwtgKtUpUsBbckC83FrsR4QXoYrYhhf3dzU4LG+Gi4qfCwg8fGLscEqmsKyljYOb11gQjjIv9oqoVpns2YEjQSSE6ApMl0vAam3ayXtdsIUDRbm8T+t912oSZmkXFARbAKneDD39lqmFx869AUCKf9Ie+Alg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ericsson.com; dmarc=pass action=none header.from=ericsson.com; dkim=pass header.d=ericsson.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SZlj6Ks+qgjCiCX/g2ZoALRT+FQj7ucQrDOccr4T7Rs=; b=S/rlrcBnIJx2Pok6BIQj6f9RFXEhbFoozPeVXdfzfRZHi/CDatm/EFsDtqnp27JrTS3wvCFpDQIh7hAvOcRiztrCSFQrqD3uzp4loFvrYISK6anGzFfJAhTzZh5RTU3d9wiphdSwxmW4IIGPaH73NA1ZmQZGznOpvX1jSSNEa/4=
Received: from AM0PR07MB3860.eurprd07.prod.outlook.com (2603:10a6:208:4c::18) by AM0PR07MB4020.eurprd07.prod.outlook.com (2603:10a6:208:50::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.13; Thu, 13 Aug 2020 13:36:18 +0000
Received: from AM0PR07MB3860.eurprd07.prod.outlook.com ([fe80::187b:7fe6:cc5a:eb00]) by AM0PR07MB3860.eurprd07.prod.outlook.com ([fe80::187b:7fe6:cc5a:eb00%5]) with mapi id 15.20.3283.015; Thu, 13 Aug 2020 13:36:18 +0000
From: Christer Holmberg <christer.holmberg@ericsson.com>
To: Alissa Cooper <alissa@cooperw.in>, Brian E Carpenter <brian.e.carpenter@gmail.com>
CC: "gen-art@ietf.org" <gen-art@ietf.org>, "draft-ietf-mmusic-msrp-usage-data-channel.all@ietf.org" <draft-ietf-mmusic-msrp-usage-data-channel.all@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>, "mmusic@ietf.org" <mmusic@ietf.org>
Thread-Topic: [Gen-art] Genart last call review of draft-ietf-mmusic-msrp-usage-data-channel-21
Thread-Index: AQHWWJ10s19LL8LqLkyup5236uCREKkFKsQAgADS44CAL2ihAIAA1eDw
Date: Thu, 13 Aug 2020 13:36:18 +0000
Message-ID: <AM0PR07MB3860571361028EEE5AFFFDA393430@AM0PR07MB3860.eurprd07.prod.outlook.com>
References: <159459362316.14150.6160122631877971567@ietfa.amsl.com> <AM7PR07MB7012B935296554B783A0995393600@AM7PR07MB7012.eurprd07.prod.outlook.com> <1f035833-3efe-3444-3387-1c8feac48538@gmail.com> <D2525A5A-F7E8-45AD-9B5D-8C6BB31F31DA@cooperw.in>
In-Reply-To: <D2525A5A-F7E8-45AD-9B5D-8C6BB31F31DA@cooperw.in>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: cooperw.in; dkim=none (message not signed) header.d=none;cooperw.in; dmarc=none action=none header.from=ericsson.com;
x-originating-ip: [188.127.223.154]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 192a2076-22f5-4474-f1ed-08d83f8ddbb3
x-ms-traffictypediagnostic: AM0PR07MB4020:
x-microsoft-antispam-prvs: <AM0PR07MB402086969BAB6BDB44EA088693430@AM0PR07MB4020.eurprd07.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 2jWjCA2h/94W+xwgjcxwgEkJmVg5pTe4/ghY62+fLkL0Uq4OWI+YW13aoKykntQJfO8KqiLT2VXidOXNeNQOlzsURoI5zfz7d2DxEF8fnq8QIzaBug7FL7QbyvIy1OqnN47wMraEodeZX0zQM5ukn6ZsnITSv6vfpEPLVzY+j8ozvAEO36hrCF1RQVIkX6/VOPdGFsi2JOEpeRNaxwPb2qvBi8N5QvBa2CM+ZcJFGtH6X1EDzGatRM2NK0h09efS/fLvEVShs3ROexMrQIUvaLvZg8J3pZ43xociHXZpYX6Yif9MF+4j7bbP/fEtm1TMBl85OMseK+6SbfYQgea4GkVBBkWogfaOGsgMbhemYcsU/FemPqEkemcC/ZXQ212P4ojlfLCJEqq/dJjb/gdZyA==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR07MB3860.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(396003)(376002)(136003)(39860400002)(346002)(76116006)(66556008)(66446008)(66476007)(83380400001)(316002)(7696005)(66946007)(5660300002)(71200400001)(6506007)(2906002)(86362001)(53546011)(64756008)(8936002)(8676002)(186003)(9686003)(52536014)(44832011)(55016002)(54906003)(966005)(4326008)(478600001)(26005)(33656002)(110136005); DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata: 7JX85AAJ8tgr0Wu3d5i7sUVRLE2dXUN/xLnIMWQJhfb78ui/+3d962oqEQgLGlzCu7WSQFTziS0KZDihwtPSLgC29QyzcjL3ryewhY5lmnBl684fZOIFu9N9FkMEDqwoiGu9Y96lDNdfwrbgOTM7KmOcjXYOueD+qbD8TRt3TVKJByL5aSniSjcxo4hA91gEi3A0koD1z4pB14k7Qr8cuH7zowpGgEd4szx36SW4ZsQ2Cy/YyTr4yj2SgrQ0r2/AmLv3lGKEkFzwIp97NutuQrl2HLKbA+SUxZrvbAdi7KTPsBwzMj4LFp0FkZPSvOn4mImEc7D5aHcVCVwlYS1j0PmInezsJn8S6j6A2Oqe27khtZuOiTZLxUTe2+T1VFyPixq/aepEY6g8WEIG8PdgMKaEnNzB5/qz1jA5BKMVldz2eQcCahKmGe62UQm2PeG3SRBzEJME2ubMXVPMmWtoGqZ3BXApLl/AYkgwBRExu56z5ODQp0+qJ5a3S/Ke1Zyf7B6/JP/VHZ/i9n0UVHQRbJwFlICy7SzqoqZT7Gwaao1w5K3d8giQg+tI07dXMFqE9++1NzvMl5vM5WXdJVMqPyExPZvGN/Gqi1QBlYWAs6sEACm8v19KJf6fb8RyYi7RnAzrojYQJBtBs/4QZbcuww==
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: ericsson.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR07MB3860.eurprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 192a2076-22f5-4474-f1ed-08d83f8ddbb3
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Aug 2020 13:36:18.0867 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: CDmasji3kwVlIdIgBMyX6Iuf+SyrLlRNpEsHvaRBJL1vNeGh6gZZfcWC4lmVtorammzIjiri3pXOiI9oXUYVdJ9sgH7fGodLxZy6G0khVAE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR07MB4020
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/jwWCJHv1YyIanmKW50V78f1C6RI>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-mmusic-msrp-usage-data-channel-21
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Aug 2020 13:36:27 -0000

Thank You, Alissa!

Regards,

Christer

-----Original Message-----
From: Alissa Cooper <alissa@cooperw.in> 
Sent: torstai 13. elokuuta 2020 3.51
To: Brian E Carpenter <brian.e.carpenter@gmail.com>
Cc: Christer Holmberg <christer.holmberg@ericsson.com>om>; gen-art@ietf.org; draft-ietf-mmusic-msrp-usage-data-channel.all@ietf.org; last-call@ietf.org; mmusic@ietf.org
Subject: Re: [Gen-art] Genart last call review of draft-ietf-mmusic-msrp-usage-data-channel-21

Brian, thanks for your review. Christer, thanks for addressing Brian’s comments. I entered a No Objection ballot.

Alissa


> On Jul 13, 2020, at 4:51 PM, Brian E Carpenter <brian.e.carpenter@gmail.com> wrote:
> 
> Thanks Christer, that all looks good to me,
> 
> Regards
>   Brian
> 
> On 13-Jul-20 20:58, Christer Holmberg wrote:
>> Hi Brian,
>> 
>> Thank You for the review! Please see inline.
>> 
>> 
>> Nits:
>> -----
>> 
>>>> 4.1.  MSRP URI
>>>> ....
>>>>    transport  /= "dc"
>>>> 
>>>> I see that RFC7977 takes a slightly different approach to updating the ABNF:
>>>> 
>>>>    transport  =  "tcp" / "ws" / 1*ALPHANUM
>>>> 
>>> The advantage of listing out
>>> 
>>> transport  =  "tcp" / "ws" / "dc" / 1*ALPHANUM
>>> 
>>> would be that the reader sees the full list.
>> 
>> The MMUSIC WG has previously decided to take the approach of only writing the new value, using the "/=" format.
>> 
>> ---
>> 
>>>>                 ; Add "dc" to existing transports per [RFC4975]
>>>> 
>>>> I suggest
>>>> 
>>>>                ; Add "dc" to existing transports per Section 9 of 
>>>> [RFC4975]
>> 
>> Will modify as suggested.
>> 
>> ---
>> 
>>>> 4.6.  Session Closing
>>>> 
>>>>  The SDP answerer must ensure that no dcmap or dcsa attributes are  
>>>> present in the SDP answer if no corresponding attributes are 
>>>> present  in the received SDP offer.
>>>> 
>>>> Should that be MUST?
>> 
>> The reason for "must" is that is referring to generic data channel SDP O/A procedures.
>> 
>> I suggest to remove the paragraph.
>> 
>> ---
>> 
>>>> B2BUA
>>>> 
>>>> Define the acronym please.
>> 
>> We normally don't do that in MMUSIC specifications. Also, it is on the IETF list of well-known acronyms.
>> 
>> Having said that, I am fine to enhance it on first occurrence: 'Back-to-Back User Agent (B2BUA)'
>> 
>> ---
>> 
>>>> 9.2.  Subprotocol Identifier MSRP
>>>> 
>>>>  A reference to this document is added to the subprotocol 
>>>> identifier  "msrp" in the "WebSocket Subprotocol Name Registry"
>>>> 
>>>> s/this document/RFCXXXX/
>> 
>> Will modify as suggested.
>> 
>> ---
>> 
>>>> 11.  CHANGE LOG
>>>> 
>>>> Mark this section for deletion by the RFC Editor
>> 
>> I think the RFC Editor will delete it by default, but we can add explicit text.
>> 
>> Regards,
>> 
>> Christer
>> 
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art