Re: [Gen-art] Gen-ART review of draft-ietf-isis-remaining-lifetime-02

Jari Arkko <jari.arkko@piuha.net> Wed, 17 August 2016 20:12 UTC

Return-Path: <jari.arkko@piuha.net>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C5BF112D15A for <gen-art@ietfa.amsl.com>; Wed, 17 Aug 2016 13:12:14 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.147
X-Spam-Level:
X-Spam-Status: No, score=-3.147 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RP_MATCHES_RCVD=-1.247] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EE_D57bQnqeN for <gen-art@ietfa.amsl.com>; Wed, 17 Aug 2016 13:12:10 -0700 (PDT)
Received: from p130.piuha.net (p130.piuha.net [IPv6:2a00:1d50:2::130]) by ietfa.amsl.com (Postfix) with ESMTP id 958E112D5D0 for <gen-art@ietf.org>; Wed, 17 Aug 2016 13:12:04 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by p130.piuha.net (Postfix) with ESMTP id D6CC52CEE6; Wed, 17 Aug 2016 23:12:03 +0300 (EEST) (envelope-from jari.arkko@piuha.net)
X-Virus-Scanned: amavisd-new at piuha.net
Received: from p130.piuha.net ([127.0.0.1]) by localhost (p130.piuha.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3vEs5rUCT5hB; Wed, 17 Aug 2016 23:12:03 +0300 (EEST)
Received: from [127.0.0.1] (p130.piuha.net [IPv6:2a00:1d50:2::130]) by p130.piuha.net (Postfix) with ESMTP id B2CDB2CC9C; Wed, 17 Aug 2016 23:12:02 +0300 (EEST) (envelope-from jari.arkko@piuha.net)
Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\))
Content-Type: multipart/signed; boundary="Apple-Mail=_8E03EEDC-6A7E-4767-818A-D64F382078DC"; protocol="application/pgp-signature"; micalg="pgp-sha512"
X-Pgp-Agent: GPGMail
From: Jari Arkko <jari.arkko@piuha.net>
In-Reply-To: <7594FB04B1934943A5C02806D1A2204B4BBC35CF@ESESSMB208.ericsson.se>
Date: Wed, 17 Aug 2016 22:11:25 +0200
Message-Id: <2E350EE4-2E0E-4896-A4C8-4E21154BC8A2@piuha.net>
References: <7594FB04B1934943A5C02806D1A2204B4BBB6B37@ESESSMB208.ericsson.se> <89d171e8f3b446eb99274208b6987993@XCH-ALN-001.cisco.com> <7594FB04B1934943A5C02806D1A2204B4BBC3533@ESESSMB208.ericsson.se> <8da3a59b3f2a4131b964101e773fb08d@XCH-ALN-001.cisco.com> <7594FB04B1934943A5C02806D1A2204B4BBC35CF@ESESSMB208.ericsson.se>
To: Christer Holmberg <christer.holmberg@ericsson.com>
X-Mailer: Apple Mail (2.1878.6)
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/11s6Vf8VbgT4Lff2kb6BZ3fAKAM>
Cc: "Les Ginsberg (ginsberg)" <ginsberg@cisco.com>, "gen-art@ietf.org" <gen-art@ietf.org>, "draft-ietf-isis-remaining-lifetime.all@tools.ietf.org" <draft-ietf-isis-remaining-lifetime.all@tools.ietf.org>
Subject: Re: [Gen-art] Gen-ART review of draft-ietf-isis-remaining-lifetime-02
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Aug 2016 20:12:14 -0000

Thanks, all.

Jari

On 08 Aug 2016, at 19:40, Christer Holmberg <christer.holmberg@ericsson.com> wrote:

> That should work :)
> 
> Thanks!
> 
> Regards,
> 
> Christer
> 
> From: Les Ginsberg (ginsberg) [mailto:ginsberg@cisco.com]
> Sent: 08 August 2016 20:39
> To: Christer Holmberg <christer.holmberg@ericsson.com>; gen-art@ietf.org; draft-ietf-isis-remaining-lifetime.all@tools.ietf.org
> Subject: RE: Gen-ART review of draft-ietf-isis-remaining-lifetime-02
> 
> Christer –
> 
> I will place a reference in the Introduction – something like:
> 
> “[ISO10589} defines the format of a Link State PDU (LSP) which includes a Remaining Lifetime field…”
> 
> Hope that will suffice.
> 
>    Les
> 
> 
> From: Christer Holmberg [mailto:christer.holmberg@ericsson.com]
> Sent: Monday, August 08, 2016 10:28 AM
> To: Les Ginsberg (ginsberg); gen-art@ietf.org; draft-ietf-isis-remaining-lifetime.all@tools.ietf.org
> Subject: RE: Gen-ART review of draft-ietf-isis-remaining-lifetime-02
> 
> Hi,
> 
> >Thanx for your review.
> >
> >ISO 10589 is the base specification for IS-IS and there is a reference to it in the document.
> >This is where you will find details about Link State PDUs.
> >
> >I would be reluctant to include any sort of summary description of an LSP in this document out of fear that it might be seen as differing from the base protocol specification.
> 
> I think it would be useful to place that reference also in the Abstract, and in the problem statement, before you start talking about the LSP.
> 
> You don’t have to add an LSP description, simply a reference so that it is easy for me to know where to get more information - without having to look for the reference elsewhere in the document :)
> 
> Regards,
> 
> Christer
> 
> 
> From: Christer Holmberg [mailto:christer.holmberg@ericsson.com]
> Sent: Saturday, August 06, 2016 10:03 AM
> To: gen-art@ietf.org; draft-ietf-isis-remaining-lifetime.all@tools.ietf.org
> Subject: RE: Gen-ART review of draft-ietf-isis-remaining-lifetime-02
> 
> I am the assigned Gen-ART reviewer for this draft. For background on Gen-ART, please see the FAQ at <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>
> Document:                       draft-ietf-isis-remaining-lifetime-02
> Reviewer:                         Christer Holmberg
> Review Date:                   6 August 2016
> IETF LC End Date:            15 August 2016
> IETF Telechat Date:        N/A
> 
> Summary:
> The document is well written, and almost ready for publication as a standards track RFC, but I have a couple of editorial comments that I’d like the authors to address.
> Major Issues:    None
> Minor Issues:    None
> Editorial Issues:
> The Abstract says:
> “Corruption of the Remainining Lifetime Field in a Link State PDU can go undetected.  In certain scenarios this may cause or exacerbate flooding storms.  It is also a possible denial of service attack vector.  This document defines a backwards compatible solution to this problem.”
> …and the first sentence of the Problem Statement says:
> “Each Link State PDU (LSP) includes a Remaining Lifetime field.”
> I have no idea what a Link State PDU is, and there is no introduction to what the draft is all about. The text jumps direction into the work.
> So, please add a reference to Link State PDU (LSP), and please give a little bit of introduction text what context/environment this is all about. I assume there is some core document which describes the context/environment where the Link State PDU is used?
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art