Re: [Gen-art] Gen-ART Telechat review of draft-ietf-mpls-entropy-lsp-ping-04

"Carlos Pignataro (cpignata)" <cpignata@cisco.com> Thu, 01 September 2016 14:58 UTC

Return-Path: <cpignata@cisco.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2E5D112DA01; Thu, 1 Sep 2016 07:58:26 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -15.07
X-Spam-Level:
X-Spam-Status: No, score=-15.07 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.548, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EqZ0yDXoap93; Thu, 1 Sep 2016 07:58:23 -0700 (PDT)
Received: from alln-iport-1.cisco.com (alln-iport-1.cisco.com [173.37.142.88]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9886D12D9FD; Thu, 1 Sep 2016 07:58:23 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=9456; q=dns/txt; s=iport; t=1472741903; x=1473951503; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=Tq8dWnu3RVX+PlPEO3qy7K0wGYKRfcZzt0t8vh83ZzU=; b=KFUaQCQhd3ChDUyfUPVrOThIAMmYwCKkh6jzoHhJv6C1b6u8iI7YP2JR +yjSWU+xYt9qOD0JmQUSIaNXjwKE5GyakFcqhCQ60AVWskKj6h1ASKW1I xhHzdcsS3XeCw4p0eGcm/xg/8H8HpUxVP3bP3dreu654n3plIwKh/TGCl 0=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0AAAgDmQMhX/4UNJK1TCoNQAQEBAQEeV?= =?us-ascii?q?3wHuCKCAiSFeAIcgTI4FAECAQEBAQEBAV4nhGEBAQQBIxFABQULAgEIFAQCAiY?= =?us-ascii?q?CAgIwFRABAQQOBYhACA6tfox1AQEBAQEBAQEBAQEBAQEBAQEBAQEBHIEFhSqBe?= =?us-ascii?q?IJVhBiDKiuCLwWZUAGGH4kRgW1OhA+DNIVZjEiDeAEeNoQxcAGFbH8BAQE?=
X-IronPort-AV: E=Sophos;i="5.30,268,1470700800"; d="scan'208";a="318299565"
Received: from alln-core-11.cisco.com ([173.36.13.133]) by alln-iport-1.cisco.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 01 Sep 2016 14:58:22 +0000
Received: from XCH-RTP-019.cisco.com (xch-rtp-019.cisco.com [64.101.220.159]) by alln-core-11.cisco.com (8.14.5/8.14.5) with ESMTP id u81EwMPv020807 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Thu, 1 Sep 2016 14:58:22 GMT
Received: from xch-rtp-020.cisco.com (64.101.220.160) by XCH-RTP-019.cisco.com (64.101.220.159) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Thu, 1 Sep 2016 10:58:21 -0400
Received: from xch-rtp-020.cisco.com ([64.101.220.160]) by XCH-RTP-020.cisco.com ([64.101.220.160]) with mapi id 15.00.1210.000; Thu, 1 Sep 2016 10:58:21 -0400
From: "Carlos Pignataro (cpignata)" <cpignata@cisco.com>
To: Peter Yee <peter@akayla.com>
Thread-Topic: Gen-ART Telechat review of draft-ietf-mpls-entropy-lsp-ping-04
Thread-Index: AdICbbJffWdSxfkPQGK4Jw+nhlOBgACFRvkA
Date: Thu, 1 Sep 2016 14:58:21 +0000
Message-ID: <2BD09917-8C7A-41F4-A651-BB846C6D5562@cisco.com>
References: <012901d2026e$44e1c2f0$cea548d0$@akayla.com>
In-Reply-To: <012901d2026e$44e1c2f0$cea548d0$@akayla.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.150.21.184]
Content-Type: text/plain; charset="utf-8"
Content-ID: <485E09B08C422B49B8E02D404D876405@emea.cisco.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/1PKVLVYQZEXoISbhTqLL-hoNAiM>
Cc: General area reviewing team <gen-art@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>, "draft-ietf-mpls-entropy-lsp-ping.all@ietf.org" <draft-ietf-mpls-entropy-lsp-ping.all@ietf.org>
Subject: Re: [Gen-art] Gen-ART Telechat review of draft-ietf-mpls-entropy-lsp-ping-04
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Sep 2016 14:58:26 -0000

Dear Peter,

Many thanks for taking the time to go through the document with an editorial fine-tooth comb.

Although your summary, labeled [Ready with nits], says:
> I really have no problems with the documents other than some mostly
> inconsequential nits.

I took the time to fix every single one of the small nits you identified. That’s the least we could do, out of respect of you taking the time and helping the document improve.

Our working copy incorporates fixes to all these nits. Thank you.

I must share with you that the real value of your thorough review is in the Major and Minor categories, and that General-Area technical review — not in the editorial nit identification. It was excruciatingly hard to identify some of these nits, given that you use “Page x, Section y.z, n-th bullet point, m-th sentence” locators, which are not present in the (submitted) XML source. I expect the RFC Editor might find a couple more, as part of the copy edit, at that final stage before publication when it makes more sense.

Thanks again,

— Carlos.



> On Aug 29, 2016, at 11:26 PM, Peter Yee <peter@akayla.com> wrote:
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area Review
> Team (Gen-ART) reviews all IETF documents being processed by the IESG for
> the IETF Chair. Please wait for direction from your document shepherd or AD
> before posting a new version of the draft.  For background on Gen-ART,
> please see the FAQ at
> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>
> 
> Document: draft-ietf-mpls-entropy-lsp-ping-04
> Reviewer: Peter Yee
> Review Date: August 26, 2016
> IETF LC End Date: August 26, 2016
> IESG Telechat date: September 1, 2016
> 
> Summary: This draft is basically ready for publication as a Proposed
> Standard, but has some nits that should be fixed before publication. [Ready
> with nits]
> 
> This draft expands the ability to perform MPLS LSP Ping and Traceroute
> operations in the presence of Entropy Labels when LSRs use disparate load
> balancing methods.
> 
> I really have no problems with the documents other than some mostly
> inconsequential nits.
> 
> The items below are the same as given in the LC review.
> 
> Major issues: None
> 
> Minor issues: None
> 
> Nits:
> 
> General:
> 
> Page 3, Section 1.1: delete the periods after each definition.
> 
> Change "ELI/EL pushing" to "ELI/EL-pushing".
> 
> Specific:
> 
> Page 1, Abstract, 1st paragraph, 3rd sentence: expand LSRs here as this is
> the first use of the term.  Put LSRs in parenthesis.
> 
> Page 1, Abstract, 1st paragraph, 4th and 5th sentences: change "non-EL
> based" to "non-EL-based".
> 
> Page 3, FEC definition: change "Equivalent" to "Equivalence".
> 
> Page 4, Section 1.2 , 2nd paragraph, last sentence: append a comma after
> "e.g.".
> 
> Page 4, Section 1.2, 3rd paragraph, second sentence: change "to not be"  to
> "not being".
> 
> Page 4, Section 1.2, 1st bullet point, 1st sentence: insert "the" before
> "label".
> 
> Page 5, Section 2, 2nd paragraph, 2nd sentence: append a comma after "y".
> 
> Page 5, Section 2, 3rd paragraph, 5th sentence: change "(outgoing
> interface)" to "(outgoing) interface".
> 
> Page 6, 1st sentence: insert "The" before "Current" after making it lower
> case.  Insert "the" before "following".
> 
> Page 6, 3rd bullet point, 1st sentence: delete the comma after "ECMP".
> 
> Page 6, 4th bullet item, 1st sentence: delete the comma after "ECMP".
> Insert "the" before "associated".
> 
> Page 6, 3rd asterisk bullet item: change "based on EL" to "based on the EL".
> 
> Page 6, 4th asterisk bullet item: insert "an" before "ELI".
> 
> Page 7, Section 3, 1st paragraph, 1st sentence: change the space between
> "label" and "based" to a hyphen.
> 
> Page 7, Section 4, 2nd paragraph, 1st sentence: change "PW-FEC" to "PW FEC".
> 
> Page 9, Section 6, 1st paragraph, 2nd sentence: append a comma after "one".
> 
> Page 9, L flag definition, 2nd sentence: insert "to one" before "in the echo
> reply".  Or consider working with the definition of "set" to mean "using a
> value of one" and "clear" to mean using a value of "zero" as you have done
> in other parts of the document.
> 
> Page 9, E flag definition, 2nd sentence: insert "to one" before "in the echo
> reply".
> 
> Page 11, Associated Label Multipath Information definition, 1st asterisk
> bullet item: change "16 bit" to "16-bit".
> 
> Page 12, 1st and 2nd asterisk bullet points: there is no previous mention of
> an "IP Associated Label Multipath Information".  You probably want to drop
> "IP" to match Figure 2.  Whatever you decide, make the change consistently
> throughout the document as there are other instances of "IP Associated Label
> Multipath Information", some in mixed case.  This is the only nit of real
> consequence.
> 
> Page 12, 3rd bullet item: insert "an" before "echo".  Insert "the" before
> "DS".
> 
> Page 13, Section 9, 1st paragraph after numbered items, 1st sentence: change
> "to not" to "not to".  (That just seems to read more smoothly;
> grammatically, it's fine.)
> 
> Page 13, Section 9, 1st asterisk bullet point: insert "the" before
> "following".
> 
> Page 13, Section 9, 2nd bullet item, 1st paragraph, 2nd sentence: change "to
> consider" to "considering".  Change "return" to "returning".
> 
> Page 14, Section 9.1 and 9.2 titles: change "IP Based" to "IP-based".
> 
> Page 15, 1st two asterisk bullet points: unless it is a well-known term in
> the LSP Ping/Traceroute literature, change "returning" to "returned".  (I
> couldn't find anything in RFC 4379, RFC 6424, or RFC 6790 that mentions
> "returning" as a term of art.)
> 
> Page 15, Section 9.4 title: change "Label Based" to "Label-based".
> 
> Page 16, Section 9.5 title: change "Label Based" to "Label-based".
> 
> Page 16, Section 9.5, 3rd and 4th asterisk bullet points: change "returning"
> to "returned".
> 
> Page 16, Section 9.5, 5th asterisk bullet point: insert "the" before "Label
> Multipath Information".
> 
> Page 17, Section 10, 1st paragraph, 1st sentence: change "purpose" to
> "purposes".
> 
> Page 17, items b and c: insert "the" before "label" twice in each sentence.
> Append a space after the "greater than" symbol.
> 
> Page 17, "N labels" items (numbered 1 and 2): I'm not sure how to parse
> these sentences.  Perhaps inserting "the" before "label stack" and "a"
> before "flow label" helps them to make sense, but I'm still not sure what is
> meant here.  This may simply reflect my ignorance regarding MPLS LSP Ping
> and Traceroute.
> 
> Page 18, 2nd bullet item: move the period before " (not a recommended
> practice)".
> 
> Page 18, 7th bullet item: append "the" after "exceed".
> 
> Page 19, 1st paragraph: change "supports" to "support".
>