[Gen-art] Genart last call review of draft-ietf-lamps-documentsigning-eku-04

Dale Worley via Datatracker <noreply@ietf.org> Sun, 07 August 2022 20:45 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: gen-art@ietf.org
Delivered-To: gen-art@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 54341C15C506; Sun, 7 Aug 2022 13:45:20 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Dale Worley via Datatracker <noreply@ietf.org>
To: <gen-art@ietf.org>
Cc: draft-ietf-lamps-documentsigning-eku.all@ietf.org, last-call@ietf.org, spasm@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 8.12.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <165990512033.41551.11873246377263870533@ietfa.amsl.com>
Reply-To: Dale Worley <worley@ariadne.com>
Date: Sun, 07 Aug 2022 13:45:20 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/1T23l8-kN8pEMqnQvh1ir3MsGVw>
Subject: [Gen-art] Genart last call review of draft-ietf-lamps-documentsigning-eku-04
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.39
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 07 Aug 2022 20:45:20 -0000

Reviewer: Dale Worley
Review result: Ready with Nits

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document:  draft-ietf-lamps-documentsigning-eku-04
Reviewer:  Dale R. Worley
Review Date:  2022-08-07
IETF LC End Date:  2022-08-11
IESG Telechat date:  (none)

Summary:

    This draft is basically ready for publication, but has nits that
    should be fixed before publication.

The technical content of the draft is quite good, but there is an
editorially critical issue regarding the allocation of the
identifiers.  There are three places where "to be done" identifiers
are specified:

3.1.  Including the Extended Key Purpose for Document Signing in

     id-kp-documentSigning  OBJECT IDENTIFIER  ::=  { id-kp XX }

8.2.  Informative References

Appendix A.  ASN.1 Module
     DocSignEKU { iso(1) identified-organization(3) dod(6) internet(1)
       security(5) mechanisms(5) pkix(7) id-mod(0)
       id-mod-docsign-eku(TBD1) }

     id-kp-documentSigning OBJECT IDENTIFIER ::= { id-kp TBD2 }

However, section 7 "IANA Considerations" does not explicitly mention
any of these substitutions.  Compare with
e.g. draft-ietf-curdle-cms-chacha20-poly10305.  Section 7 does say
that assignments need to be made to the appropriate registries but
provides no reference or "Note to the Editor" what substitutions need
to be made in the text.  Also, "XX" must be the same as "TBD2", but
that is not specified.

There is also a redundant specification at the end of section 7,

   No further action is necessary by IANA.

Given that the previous sentences in the paragraph state that there
are two actions and then enumerate them, adding a statement that there
are no others is redundant.

[END]