Re: [Gen-art] Gen-ATR review of draft-ietf-ccamp-ospf-availability-extension-07

"jouni.nospam" <jouni.nospam@gmail.com> Mon, 17 October 2016 15:20 UTC

Return-Path: <jouni.nospam@gmail.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 588D212945A; Mon, 17 Oct 2016 08:20:55 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.7
X-Spam-Level:
X-Spam-Status: No, score=-2.7 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id L6ZAkkqR4j5g; Mon, 17 Oct 2016 08:20:53 -0700 (PDT)
Received: from mail-pf0-x235.google.com (mail-pf0-x235.google.com [IPv6:2607:f8b0:400e:c00::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1B87D1297CC; Mon, 17 Oct 2016 08:20:53 -0700 (PDT)
Received: by mail-pf0-x235.google.com with SMTP id e6so80233048pfk.3; Mon, 17 Oct 2016 08:20:53 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=L3uFrJBIpy5Kfu6GpFTolvWiR5Ms1GPHPZMcID6/RMA=; b=GZIWfjto906BgBGT1gtYZRCEGF5JmJyUx4Nj80n/9qylppD+aLLNFDBO/ctMJ/zWTx UKPUns2w7MMq9GT6m9J8AC4pnY5c9+aG0QheIRxLa1HttUSnwR95iS8ZpsI3AmlB4KpW 6SfvfUawO9Lj6FV/QLOaBAj6UtOnBIJOzJ16hm4OliTQ3bWWUNPNK93I/20Xx1jRMC0S rI58EQRC4idzvk+XpLmg9OS1hfhmWzuJsNrKjpQcPRHaBQ17CElub6qOA1699226pf9o NlAsm2QCxIR/f/7BIwzCZxcAhrOqREq4DYLsOUsNiWAqPFuSWDGKPVyfyz/3oHnUzB2I /U8g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=L3uFrJBIpy5Kfu6GpFTolvWiR5Ms1GPHPZMcID6/RMA=; b=DYztzEajDh+JRvAirJFRy1glQoqAXwrkjQf5Cj4tf/X6C3J1Cp+uFV5hpqWOb+cYly OloVKT+dQpU89ZJ6Xubq2QZ1Npt3H1o9RjCYqcWb/7cbNMVT6AZ4tYUN4zZjDl+rcmb9 kZdQF7D8rvxSih//GK9V7Zas3yi+ufpWz8OoEprUXgaHuOBT8pKBe2UMkniA/YNvyJ7r MKBM+qGEtP++i1k8Z0E2u558vynkWdb3/DdgqyPvSAZ5ygJHFOr244M2kDK0knJ1FHfY e3j6ZKAMiHmo3871C2HzF3hd/7GANvliVuIK7uBWgvmM1SvkO89ctiA9KwtNfygRKfZs aMqA==
X-Gm-Message-State: AA6/9Rkqb7/0KmRArdWWDFAftylnJEEK6NLpA3xtGl4V+D6XB+PIJZ4Nf8kBiRnTrCJR9w==
X-Received: by 10.98.61.85 with SMTP id k82mr38544519pfa.7.1476717652648; Mon, 17 Oct 2016 08:20:52 -0700 (PDT)
Received: from dhcpw3-sj1-44.sj.broadcom.com ([216.31.219.19]) by smtp.gmail.com with ESMTPSA id fl4sm49053668pad.39.2016.10.17.08.20.51 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 17 Oct 2016 08:20:51 -0700 (PDT)
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
From: "jouni.nospam" <jouni.nospam@gmail.com>
In-Reply-To: <9C5FD3EFA72E1740A3D41BADDE0B461F9CE1F3DA@szxema506-mbs.china.huawei.com>
Date: Mon, 17 Oct 2016 08:20:50 -0700
Content-Transfer-Encoding: quoted-printable
Message-Id: <B9164531-55D4-4655-B6D6-ACC44BB52BF3@gmail.com>
References: <499E4913-F08F-439A-82CA-68F91F507E5D@gmail.com> <9C5FD3EFA72E1740A3D41BADDE0B461F9CE1F3DA@szxema506-mbs.china.huawei.com>
To: "Yemin (Amy)" <amy.yemin@huawei.com>
X-Mailer: Apple Mail (2.3124)
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/1fA88AnTwncRAvGOzGD8fFIrm-g>
Cc: "gen-art@ietf.org" <gen-art@ietf.org>, "draft-ietf-ccamp-ospf-availability-extension.all@ietf.org" <draft-ietf-ccamp-ospf-availability-extension.all@ietf.org>
Subject: Re: [Gen-art] Gen-ATR review of draft-ietf-ccamp-ospf-availability-extension-07
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 17 Oct 2016 15:20:56 -0000

Hi,


> On Oct 17, 2016, at 1:06 AM, Yemin (Amy) <amy.yemin@huawei.com> wrote:
> 
> Hi Jouni,
> 
> Thanks very much for the comments. I fixed the nits in the draft. 
> 
> Regarding the Switching Capability-specific information field, we had the discussion in WG, and here's the summary/conclusion:
> It's decided that this document will just define the availability TLV, and a new draft will define its technology specific usage.  

Ok, thanks for sharing this. This document had no mention or guidance of this kind of decision. I would have assumed some text since the extension defined in this document is seemingly backwards incompatible without some glue. As the text is now, is not sufficient.

I would appreciate text along lines that can be found in Section 3 of RFC7688 with an addition of the details you point out below regarding the allocation of new Switching-capability types. Also, it would not hurt describing (with the Switching-capability types text) how the situation where an existing non-TLV Switching Capability-specific information and the new TLV-based information have to coexist.. or whether that kind format is not supported.

- Jouni


> For example, for the SCSI which supports TLV(e.g., OTN/WSON), a new type code is needed to make use of availability TLV. 
> For the SCSI who doesn’t support TLV(e.g., PSC), a new SC types is needed. 
> 
> BR,
> Amy
> 
> -----Original Message-----
> From: jouni.nospam [mailto:jouni.nospam@gmail.com] 
> Sent: Monday, October 17, 2016 5:50 AM
> To: gen-art@ietf.org
> Cc: draft-ietf-ccamp-ospf-availability-extension.all@ietf.org
> Subject: Gen-ATR review of draft-ietf-ccamp-ospf-availability-extension-07
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair.  Please treat these comments just like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.
> 
> Document: draft-ietf-ccamp-ospf-availability-extension-07
> Reviewer: Jouni Korhonen
> Review Date:        2016-10-16
> IETF LC End Date:   2016-10-24
> IESG Telechat date: 2016-11-03
> 
> Summary:
> 
> Document is ready with nits.
> 
> Major issues:
> 
> None.
> 
> Minor issues:
> 
> It is not clear to me how the ISCD Availability sub-TLV is encoded into RFC4203 Switching Capability-specific information field. This is because RFC4203 lists specific encodings depending on “Switching Cap” field and those encoded information fields seem not to be TLVs. I would like to see some text that deals with switching cap, its relation to the TLV described in this document and the coexistence with existing capability specific information fields described in RFC4203. If I did not understand something regarding the encoding that is supposed to be trivial I am happy to told that ;)
> 
> Nits/editorial comments:
> 
> o Line 21: ISCD is not expanded.
> o Line 142: unnecessary extra space in "a < availability”.
> o Line 150: Space needed before the reference "protocol[ETPAI].”
> o Line 142-.. TE is never expanded or part of the list acronyms.
> o Lines 176-178: formatting issue with indentation, line spacing  and
>  line endings (not a fullstop but ‘;’).
> o Line 162: TLV is never expanded or  part of the list acronyms.
> 
> __________________________________________