[Gen-art] Gen-ART Review of draft-ietf-l2vpn-vpls-pe-etree-10

Russ Housley <housley@vigilsec.com> Fri, 13 November 2015 17:28 UTC

Return-Path: <housley@vigilsec.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 89C691B2D59; Fri, 13 Nov 2015 09:28:39 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -101.9
X-Spam-Level:
X-Spam-Status: No, score=-101.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, USER_IN_WHITELIST=-100] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id X9mZFVbv3_cQ; Fri, 13 Nov 2015 09:28:36 -0800 (PST)
Received: from odin.smetech.net (x-bolt-wan.smeinc.net [209.135.219.146]) by ietfa.amsl.com (Postfix) with ESMTP id 096911B2D6D; Fri, 13 Nov 2015 09:28:36 -0800 (PST)
Received: from localhost (unknown [209.135.209.5]) by odin.smetech.net (Postfix) with ESMTP id 94E77F2416C; Fri, 13 Nov 2015 12:28:25 -0500 (EST)
X-Virus-Scanned: amavisd-new at smetech.net
Received: from odin.smetech.net ([209.135.209.4]) by localhost (ronin.smeinc.net [209.135.209.5]) (amavisd-new, port 10024) with ESMTP id ubsj15QvIYwX; Fri, 13 Nov 2015 12:27:00 -0500 (EST)
Received: from [192.168.2.104] (pool-108-51-128-219.washdc.fios.verizon.net [108.51.128.219]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by odin.smetech.net (Postfix) with ESMTP id BBB07F2417D; Fri, 13 Nov 2015 12:28:04 -0500 (EST)
Mime-Version: 1.0 (Apple Message framework v1085)
Content-Type: text/plain; charset=us-ascii
From: Russ Housley <housley@vigilsec.com>
In-Reply-To: <46A1A261-E9F4-414D-AAD8-9C85A8B53283@vigilsec.com>
Date: Fri, 13 Nov 2015 12:27:54 -0500
Content-Transfer-Encoding: 7bit
Message-Id: <9ED27C8A-52FE-4E5B-AAF0-7F9F92D826C5@vigilsec.com>
References: <46A1A261-E9F4-414D-AAD8-9C85A8B53283@vigilsec.com>
To: draft-ietf-l2vpn-vpls-pe-etree.all@ietf.org
X-Mailer: Apple Mail (2.1085)
Archived-At: <http://mailarchive.ietf.org/arch/msg/gen-art/2S7-6vXHyxQ1UUeb5NSBzEVyaTs>
Cc: IETF Gen-ART <gen-art@ietf.org>, IETF <ietf@ietf.org>
Subject: [Gen-art] Gen-ART Review of draft-ietf-l2vpn-vpls-pe-etree-10
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Nov 2015 17:28:39 -0000

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair. Please wait for direction from your
document shepherd or AD before posting a new version of the draft.

For more information, please see the FAQ at
<http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.

Document: draft-ietf-l2vpn-vpls-pe-etree-10
Reviewer: Russ Housley
Review Date: 2015-11-13
IETF LC End Date: 2015-11-24
IESG Telechat date: unknown

Summary:  Almost Ready


Major Concerns: None


Minor Concerns:

Sections 4.1 and 5.3.1 inclues a reference to [802.1Q-2011].  Should
this be the 2014 version of the document?  If not, please add the
informative reference for [802.1Q-2011].


Other Editorial Comments:

The Abstract should appear on the title page.

Section 3 needs a reference for MEF 6.1:
s/Specification MEF 6.1/Specification MEF 6.1 [MEF6.1]/
Also, [MEF6.1] needs to be added as a normative reference.

Section 3 needs a reference for IEEE 802.1Q-2003:
s/B.1.3 of IEEE 802.1Q-2003/B.1.3 of IEEE 802.1Q-2003 [802.1Q-2003]/
Also, please add an informative reference for [802.1Q-2003].

Third level section headings do not have space between the section
number and the section title.  For example:
s/5.3.1.PW Processing/5.3.1. PW Processing/

In Fig 4, there is room to shift the figure to the right, this will
allow the "AC" labels to fit better on the left:

              +----------------------------------------+
              |           VPLS-capable PE model        |
              |   +---------------+          +------+  |
              |   |               |==========|TVSI-1|------------
   +---+  AC  |   |               ------------      |------------ PWs
   |CE |----------|     Bridge    ------------      |------------
   +---+      |   |               | Root &   +------+  |
              |   |     Module    | Leaf VLAN   o      |
              |   |               |             o      |
              |   |               |             o      |
              |   |               |             o      |
              |   |               |             o      |
   +---+  AC  |   |               |   VLAN-n +------+  |
   |CE |----------|               ------------VSI-n |-------------
   +---+      |   |               |==========|      |------------- PWs
              |   |               |     ^    |      |-------------
              |   +---------------+     |    +------+  |
              |                         |              |
              +-------------------------|--------------+
                            LAN emulation Interface

          Figure 4  A VPLS PE Model for E-Tree with a Single T-VSI