Re: [Gen-art] Review of draft-ietf-mmusic-msid-13

"Matt Miller (mamille2)" <mamille2@cisco.com> Wed, 15 June 2016 22:38 UTC

Return-Path: <mamille2@cisco.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3D6E212D0EF; Wed, 15 Jun 2016 15:38:06 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -15.947
X-Spam-Level:
X-Spam-Status: No, score=-15.947 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.426, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JaQ2m3LB4KFc; Wed, 15 Jun 2016 15:38:04 -0700 (PDT)
Received: from alln-iport-2.cisco.com (alln-iport-2.cisco.com [173.37.142.89]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3117412D0D9; Wed, 15 Jun 2016 15:38:04 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=3407; q=dns/txt; s=iport; t=1466030284; x=1467239884; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=DzLNnKAoh75KY6MMqQc3ujqqyR0mkVuqKa8SeIEiE8c=; b=VA5lCLni4qrvzfPiikkLwpg4cz+hwOXVVNZeMGRtE7DjzypTIa53GYJQ Exb5BEPapQKPIelVGs4pOrcBLIkziPtk+hnnWaUVSSmDwKV7NGIOAWNHl 8/eZjRMAuMkD9SJQ9kEuv/HnjZS4Td4mUB1fv5rTP3WNPTVdkbCGNsfjw 0=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0AYAgCH2GFX/4MNJK1dgz5WfQa6ZoF6FwuFdQKBNDgUAQEBAQEBAWUnhEsBAQEDAQEBATc0CwULAgEIFAQeECcLJQIEDgWIKAgOv0ABAQEBAQEBAQEBAQEBAQEBAQEBAQEciB6CVoQdERKDLIIvBZhnAgGGBIgkgWlOhASIZ49zAR42ggccgUxuAYhERH8BAQE
X-IronPort-AV: E=Sophos;i="5.26,477,1459814400"; d="scan'208";a="284627941"
Received: from alln-core-1.cisco.com ([173.36.13.131]) by alln-iport-2.cisco.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 15 Jun 2016 22:37:45 +0000
Received: from XCH-ALN-001.cisco.com (xch-aln-001.cisco.com [173.36.7.11]) by alln-core-1.cisco.com (8.14.5/8.14.5) with ESMTP id u5FMbjB4029075 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Wed, 15 Jun 2016 22:37:45 GMT
Received: from xch-aln-002.cisco.com (173.36.7.12) by XCH-ALN-001.cisco.com (173.36.7.11) with Microsoft SMTP Server (TLS) id 15.0.1104.5; Wed, 15 Jun 2016 17:37:44 -0500
Received: from xch-aln-002.cisco.com ([173.36.7.12]) by XCH-ALN-002.cisco.com ([173.36.7.12]) with mapi id 15.00.1104.009; Wed, 15 Jun 2016 17:37:44 -0500
From: "Matt Miller (mamille2)" <mamille2@cisco.com>
To: Jari Arkko <jari.arkko@piuha.net>
Thread-Topic: [Gen-art] Review of draft-ietf-mmusic-msid-13
Thread-Index: AQHRthyK4tf414akHk+R/Z/fjPh+J5/ri4sAgAAJHgA=
Date: Wed, 15 Jun 2016 22:37:44 +0000
Message-ID: <74EA3075-7D73-406E-BAFE-95EFED61DF95@cisco.com>
References: <2AAAC8A1-2B21-443B-88E8-FE2617DA6C82@cisco.com> <1EAC760B-D06E-46BC-A285-7C8DD23AC172@piuha.net>
In-Reply-To: <1EAC760B-D06E-46BC-A285-7C8DD23AC172@piuha.net>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.129.24.122]
Content-Type: text/plain; charset="us-ascii"
Content-ID: <5A02A4068B87AE4F808421E394F398EA@emea.cisco.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/2oXKIw00Hd4EyP9UK9i8I81Elm4>
Cc: "gen-art@ietf.org" <gen-art@ietf.org>, "draft-ietf-mmusic-msid.all@ietf.org" <draft-ietf-mmusic-msid.all@ietf.org>
Subject: Re: [Gen-art] Review of draft-ietf-mmusic-msid-13
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Jun 2016 22:38:06 -0000

-14 addressed all of my previous nits.  I just noticed one nit in -14:

* In Section 3. "Procedures", "si2gnal" should be "signal".

There is one outdated reference (draft-ietf-mmusic-sdp-bundle-negotiation, -29 vs -30), that I assume will be addressed before publication.


- m&m

Matt Miller
Cisco Systems, Inc.



> On Jun 15, 2016, at 4:05 PM, Jari Arkko <jari.arkko@piuha.net> wrote:
> 
> Thanks! Were these comments noted by the authors? Or possibly even addressed in -14?
> 
> Jari
> 
> On 25 May 2016, at 03:29, Matt Miller (mamille2) <mamille2@cisco.com> wrote:
> 
>> I am the assigned Gen-ART reviewer for this draft. The General Area Review
>> Team (Gen-ART) reviews all IETF documents being processed by the IESG for
>> the IETF Chair.  Please treat these comments just like any other last call
>> comments.
>> 
>> For more information, please see the FAQ at
>> 
>> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.
>> 
>> Document: draft-ietf-mmusic-msid-13
>> Reviewer: Matthew A. Miller
>> Review Date: 2016-05-24
>> IETF LC End Date: 2016-05-24
>> IESG Telechat date: N/A
>> 
>> Summary:
>> 
>> This document is ready for publication as a Proposed Standard once
>> some minor editorial nits are address.
>> 
>> Major issues:  NONE
>> 
>> Minor issues:  NONE
>> 
>> Nits/editorial comments:
>> 
>> * idnits is complaining that something smells of code that isn't bounded.
>> However, I think it is clear that the "suspicious text" is the detailed
>> SDP example, and is already clearly noted as such.
>> 
>> * idnits warns of a number of outdated references, which I assume will
>> be updated with the next revision of this document or by the RFC Editor:
>> 
>> - draft-ietf-mmusic-sdp-mux-attributes-02
>> - draft-ietf-rtcweb-jsep-07
>> - draft-ietf-mmusic-sdp-bundle-negotiation-07
>> - draft-ietf-rtcweb-overview-10
>> 
>> * In Section 1.1. "Structure Of This Document", there is a spacing issue
>> in "WebRTC[I-D.ietf-rtcweb-overview] ."
>> 
>> * In Section 2. "The Msid Mechanism", there is an extra "." in
>> "... defined in [W3C.WD-webrtc-20150210]., and to ...".
>> 
>> * In Section 3.1. "Handling of non-signalled tracks", some of the
>> phrasing in the third paragraph seems awkward to me.  Might I suggest
>> the following instead:
>> 
>>  When MSID is used, the only time this can happen is when, after the
>>  initial negotiation, a negotiation is performed where the answerer
>>  adds a MediaStreamTrack to an already established connection and
>>  starts sending data before the answer is received by the offerer.
>>  For initial negotiation, packets won't flow until the ICE candidates
>>  and fingerprints have been exchanged, so this is not an issue.
>> 
>> * Also in Section 3.1. "Handling of non-signalled tracks", I think the
>> sentence after the bullet list ought to be split in two between "entered"
>> and "If":
>> 
>>  The process above may involve a considerable amount of buffering
>>  before the stable state is entered.  If the implementation wishes to
>>  limit this buffering, it MUST signal to the user that media has been
>>  discarded.
>> 
>> _______________________________________________
>> Gen-art mailing list
>> Gen-art@ietf.org
>> https://www.ietf.org/mailman/listinfo/gen-art
>