Re: [Gen-art] Gen-ART review of draft-ietf-isis-remaining-lifetime-02

Christer Holmberg <christer.holmberg@ericsson.com> Sat, 06 August 2016 17:03 UTC

Return-Path: <christer.holmberg@ericsson.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1B14D12B04B for <gen-art@ietfa.amsl.com>; Sat, 6 Aug 2016 10:03:05 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.21
X-Spam-Level:
X-Spam-Status: No, score=-4.21 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, T_KAM_HTML_FONT_INVALID=0.01] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id evKTUlU3nRlm for <gen-art@ietfa.amsl.com>; Sat, 6 Aug 2016 10:03:03 -0700 (PDT)
Received: from sessmg22.ericsson.net (sessmg22.ericsson.net [193.180.251.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 12D2412B046 for <gen-art@ietf.org>; Sat, 6 Aug 2016 10:03:02 -0700 (PDT)
X-AuditID: c1b4fb3a-c7bff700000009bd-3f-57a61844dbd8
Received: from ESESSHC001.ericsson.se (Unknown_Domain [153.88.183.21]) by (Symantec Mail Security) with SMTP id 31.B6.02493.44816A75; Sat, 6 Aug 2016 19:03:01 +0200 (CEST)
Received: from ESESSMB208.ericsson.se ([169.254.8.233]) by ESESSHC001.ericsson.se ([153.88.183.21]) with mapi id 14.03.0301.000; Sat, 6 Aug 2016 19:02:59 +0200
From: Christer Holmberg <christer.holmberg@ericsson.com>
To: "gen-art@ietf.org" <gen-art@ietf.org>, "draft-ietf-isis-remaining-lifetime.all@tools.ietf.org" <draft-ietf-isis-remaining-lifetime.all@tools.ietf.org>
Thread-Topic: Gen-ART review of draft-ietf-isis-remaining-lifetime-02
Thread-Index: AdHwAkwUcT4hVHRjR9KTLedJakLzFg==
Date: Sat, 06 Aug 2016 17:02:59 +0000
Message-ID: <7594FB04B1934943A5C02806D1A2204B4BBB6B37@ESESSMB208.ericsson.se>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [153.88.183.148]
Content-Type: multipart/alternative; boundary="_000_7594FB04B1934943A5C02806D1A2204B4BBB6B37ESESSMB208erics_"
MIME-Version: 1.0
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrALMWRmVeSWpSXmKPExsUyM2K7qK6rxLJwg8MnxS3OfrjCanH11WcW ByaPJUt+Mnl8ufyZLYApissmJTUnsyy1SN8ugSvj1ILkgo3uFY3TNzA3ML6y62Lk5JAQMJHY 9GoRexcjF4eQwHpGieMzDkI5ixklPqzfwNTFyMHBJmAh0f1PGyQuIjCPUWLlnZWMIN3CAi4S CycsZgaxRQRcJc483s0GYetJ/Or7AGazCKhIrN/fC1bDK+Arcfz3eXYQm1FATOL7qTVMIDaz gLjErSfzmSAuEpBYsuc8M4QtKvHy8T9WCFtJonHJE1aI+nyJyb+usEHMFJQ4OfMJywRGwVlI Rs1CUjYLSRlEXEdiwe5PbBC2tsSyha+ZYewzBx4zIYsvYGRfxShanFpcnJtuZKSXWpSZXFyc n6eXl1qyiREYDwe3/LbawXjwueMhRgEORiUeXoUrS8KFWBPLiitzDzFKcDArifD+4F0WLsSb klhZlVqUH19UmpNafIhRmoNFSZzX/6ViuJBAemJJanZqakFqEUyWiYNTqoGRj3kvE8tepi9V X9aFnj/9Pn1JvcqXYwoZm288F/V5EMOTlzA5RYInR09R6hDLypP//Aqnr53z0p/3rdHT5XUX v2yd4pXjc1uy5nmXyuOVZds8l/VaVF/L7PmlLzYtfQvDhVfhJe1Hd/OvkV1/PXfXdWvfnsXX Dm6ecGH1vKaN37b4tWl7n/3RoMRSnJFoqMVcVJwIAN1JV0yDAgAA
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/41lbRGWdXD4h9fxHb8nu3-VFOR8>
Subject: Re: [Gen-art] Gen-ART review of draft-ietf-isis-remaining-lifetime-02
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 06 Aug 2016 17:03:05 -0000

I am the assigned Gen-ART reviewer for this draft. For background on Gen-ART, please see the FAQ at <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>
Document:                       draft-ietf-isis-remaining-lifetime-02
Reviewer:                         Christer Holmberg
Review Date:                   6 August 2016
IETF LC End Date:            15 August 2016
IETF Telechat Date:        N/A

Summary:
The document is well written, and almost ready for publication as a standards track RFC, but I have a couple of editorial comments that I'd like the authors to address.
Major Issues:    None
Minor Issues:    None
Editorial Issues:
The Abstract says:
"Corruption of the Remainining Lifetime Field in a Link State PDU can go undetected.  In certain scenarios this may cause or exacerbate flooding storms.  It is also a possible denial of service attack vector.  This document defines a backwards compatible solution to this problem."
...and the first sentence of the Problem Statement says:
"Each Link State PDU (LSP) includes a Remaining Lifetime field."
I have no idea what a Link State PDU is, and there is no introduction to what the draft is all about. The text jumps direction into the work.
So, please add a reference to Link State PDU (LSP), and please give a little bit of introduction text what context/environment this is all about. I assume there is some core document which describes the context/environment where the Link State PDU is used?