Re: [Gen-art] Review of draft-ietf-mmusic-sctp-sdp-22

Christer Holmberg <christer.holmberg@ericsson.com> Mon, 06 February 2017 09:15 UTC

Return-Path: <christer.holmberg@ericsson.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DA9B9129CC1; Mon, 6 Feb 2017 01:15:57 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.221
X-Spam-Level:
X-Spam-Status: No, score=-4.221 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oJ1-5txFrgQt; Mon, 6 Feb 2017 01:15:56 -0800 (PST)
Received: from sessmg23.ericsson.net (sessmg23.ericsson.net [193.180.251.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E85B9129CC2; Mon, 6 Feb 2017 01:15:55 -0800 (PST)
X-AuditID: c1b4fb2d-fb9fc980000059d1-67-58983ec96827
Received: from ESESSHC011.ericsson.se (Unknown_Domain [153.88.183.51]) by (Symantec Mail Security) with SMTP id 89.1F.22993.9CE38985; Mon, 6 Feb 2017 10:15:53 +0100 (CET)
Received: from ESESSMB209.ericsson.se ([169.254.9.76]) by ESESSHC011.ericsson.se ([153.88.183.51]) with mapi id 14.03.0319.002; Mon, 6 Feb 2017 10:15:52 +0100
From: Christer Holmberg <christer.holmberg@ericsson.com>
To: Brian E Carpenter <brian.e.carpenter@gmail.com>, "gen-art@ietf.org" <gen-art@ietf.org>
Thread-Topic: Review of draft-ietf-mmusic-sctp-sdp-22
Thread-Index: AQHSf18vg7KvnMe4fUWDAsU2eyafs6Faa6TQgABKiACAAQ+dAA==
Date: Mon, 06 Feb 2017 09:15:50 +0000
Message-ID: <D4BE0BC4.177A8%christer.holmberg@ericsson.com>
References: <148626499152.2778.12224491829240452688.idtracker@ietfa.amsl.com> <7594FB04B1934943A5C02806D1A2204B4BFE5BE2@ESESSMB209.ericsson.se> <dcc818aa-5283-a521-98f2-0fae9f43ae8f@gmail.com>
In-Reply-To: <dcc818aa-5283-a521-98f2-0fae9f43ae8f@gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/14.7.1.161129
x-originating-ip: [153.88.183.146]
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <5EBCF2F9A4AA4F4D83A06CA03DA20AED@ericsson.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrJIsWRmVeSWpSXmKPExsUyM2K7se5JuxkRBrduWFm0XdzHZLGpfxOL xdVXn1kspi5/zOLA4rFz1l12jyVLfjIFMEVx2aSk5mSWpRbp2yVwZUzY08FYsFGqYk5rUAPj dpEuRk4OCQETicWtZ9m6GLk4hATWMUq86N3HCOEsYpS4emgRSxcjBwebgIVE9z9tkAYRgRiJ nS+6mEBqmAUaGCUOnGxiBEkIA02a0v6aEaLIVOLmsuVMELaTxMv+NmYQm0VARaKvfRmYzStg LTHp+GcWiGVHGCV6L5wEa+YUsJU41HUZzGYUEJP4fmoN2CBmAXGJW0/mM0GcLSCxZM95Zghb VOLl43+sILaogJ7E8udroOJKEj82XGKB6NWTuDF1ChvIM8xAi8//koYIa0ssW/ga6h5BiZMz n7BMYBSfhWTbLCTdsxC6ZyHpnoWkewEj6ypG0eLU4uLcdCNjvdSizOTi4vw8vbzUkk2MwAg8 uOW37g7G1a8dDzEKcDAq8fB+sJ0eIcSaWFZcmXuIUYKDWUmEN9ByRoQQb0piZVVqUX58UWlO avEhRmkOFiVxXrOV98OFBNITS1KzU1MLUotgskwcnFINjOvSVy2b8PL6em7hmsjmF1IsDX1X 2QTWbzDbJx74/sxpI+522XV9RmnP15w1XJU76f5U/58KP19EPXN+s3al1bHY06brndM2q86o n32qvPmOZp7dzClut39mOq7YLMCkYfjOc962qz6dMVNu/JDWenFvffZJzbkSncGJ7tc0u8y7 nA0+mMlpliixFGckGmoxFxUnAgBG3FYOvAIAAA==
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/4MJxS4Tq-oxihiJxiNdKnp60a4Q>
Cc: "draft-ietf-mmusic-sctp-sdp.all@ietf.org" <draft-ietf-mmusic-sctp-sdp.all@ietf.org>, "mmusic@ietf.org" <mmusic@ietf.org>
Subject: Re: [Gen-art] Review of draft-ietf-mmusic-sctp-sdp-22
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Feb 2017 09:15:58 -0000

Hi,

I¹ve created a pull request with the changes based on Brian¹s comments.

https://github.com/cdh4u/draft-sctp-sdp/pull/10


Regards,

Christer


On 05/02/17 21:05, "Brian E Carpenter" <brian.e.carpenter@gmail.com> wrote:

>Hi Christer,
>On 06/02/2017 03:14, Christer Holmberg wrote:
>> Hi Brian,
>> 
>> Thanks for your review! Please see inline.
>> 
>> ...
>> 
>> Comments:
>> ---------
>> 
>>> Two points I noted in the writeup:
>>> "There are existing implementations of earlier versions of the
>>>document..."
>>>
>>> Excellent, but I wonder why we don't see Implementation Status
>>>sections under RFC 6982 in more Last Call drafts.
>> 
>> Perhaps a topic for an IETF chairs lunch presentation?
>
>Or at least a short reminder!
>
>> 
>> I have to admit that I did not know about 6982 (now obsoleted by 7942).
>>My suggestion would to not collect that information for this draft at
>>this point of time, as it could take some time.
>
>Agreed.
>
>>> "IPv6 address examples are not necessary since IP version differences
>>>are immaterial to the purpose of the specification."
>>>
>>> It's just as easy to give an IPv6 example though, and more future
>>>proof.
>> 
>> I can modify the address in the example, from IPv4 to v6.
>
>As you wish.
>
>> Minor issue: (almost a nit)
>> ------------
>> 
>> 1.  Introduction
>> ...
>>>>   NOTE: Due to the characteristics of TCP, usage of 'TCP/DTLS/SCTP'
>>>>   will always force ordered and reliable delivery of the SCTP
>>>>   packets, which limits the usage of the SCTP options.  Therefore, it
>>>>is
>>>>   RECOMMENDED that TCP is only used in situations where UDP traffic
>>>>   is blocked.
>>>
>>> Why would one choose 'TCP/DTLS/SCTP' rather than just 'TCP/TLS'? I
>>>don't object to it being specified, but since you
>>> don't support multihoming or multiple associations, what is the use
>>>case, in a few words?
>> 
>> SCTP supports multiple SCTP streams over a single association, and you
>>can still use that with 'TCP/DTLS/SCTP'. E.g, the WebRTC Data Channel
>>protocol uses two streams to realize a data channel.
>
>OK.
>
>(I now remember that I raised essentially the same question when reviewing
>draft-ietf-clue-datachannel. Actually I'm glad to see SCTP proving
>useful.)
>
>> I could modify the first sentence as following:
>> 
>>         "NOTE: Due to the characteristics of TCP, while multiple SCTP
>>streams
>>          can still be used, usage of 'TCP/DTLS/SCTP' will always
>>force...."
>
>OK
>
>> 
>> Nits:
>> -----
>> 
>>>> 4.4.2.  SDP Media Description values
>>>>
>>>>      m= line parameter        parameter value(s)
>>>>     
>>>> ------------------------------------------------------------------
>>>>      <media>:                 "application"
>>>>      <proto>:                 "UDP/DTLS/SCTP" or "TCP/DTLS/SCTP"
>>>>      <port>:                  UDP port number (for "UDP/DTLS/SCTP")
>>>>                               TCP port number (for ""UDP/DTLS/SCTP")
>>>
>>> I think the last line should be: TCP port number (for "TCP/DTLS/SCTP")
>> 
>> Correct. Will be fixed.
>> 
>>> There is some inconsistency in the use of quotation marks:
>>>"UDP/DTLS/SCTP" or 'UDP/DTLS/SCTP'
>> 
>> I'll fix that. I will use single quotes.
>
>Thanks,
>    Brian