IETF Logo Mail Archive

Re: [Gen-art] Genart last call review of draft-ietf-core-senml-13

Alissa Cooper <alissa@cooperw.in> Thu, 19 April 2018 01:45 UTC

Return-Path: <alissa@cooperw.in>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E778F12D877; Wed, 18 Apr 2018 18:45:35 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.7
X-Spam-Level:
X-Spam-Status: No, score=-2.7 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=cooperw.in header.b=H3H86Q2I; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=MF77tJL6
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 84_ncaTvHvye; Wed, 18 Apr 2018 18:45:34 -0700 (PDT)
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D1942127871; Wed, 18 Apr 2018 18:45:33 -0700 (PDT)
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 44BE021990; Wed, 18 Apr 2018 21:45:33 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Wed, 18 Apr 2018 21:45:33 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cooperw.in; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=P7Iipe5SytsJbNVGdKcn8zEqhMjD/ isVxMq8Kqx4g8o=; b=H3H86Q2IUfWU2FPYUvIlxHP0AOlxv5TGui+DIcTRdIaMM XlC7eaUkM/axe3uq92Yr1R8Qz9UHaINMLOJEOdu+nkL7Wqrh7lY+o2ipAC0Fh0R6 cRGoVqw7UWHyfe0SbvNwHeJEYsZ3tc8itn4SgZjrxFdODOyP1mHTOV2HyLf8GoxW UHkYFvApUlC9l0WsIFSxNBMaKnGEpsYg7mfPoADByHImC7c7JO/1ldeU1UR9kjNA iaFroS2m71knyY9v24Pz2YwQ0PXtQUI7qyFKwmmOSRHZEuz2ql7SJGRwFfI45ams bl6+My33OquNbSl4Hu98eQjTHQnAhB0f0nkgQ7N1w==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=P7Iipe 5SytsJbNVGdKcn8zEqhMjD/isVxMq8Kqx4g8o=; b=MF77tJL6UBwunA97dtXYPM CzEXkqiuh0/sEN7lRaiPmRjYqdbTGQqX5kalhsft6vcnPhOzLiGi90QjtIw+hdf9 cVubfHCQJO9SNfjoLrfOKrOAxVRpVQtKfA60JmTIUJF3TD6MM4R1HjZ4/90dMk/z /XmFRHhso09YIo+0wNAIpx438uxjRQoVCrN1WUDh019oj5bVu/ZPBgTikWHorHPp 6whvc+NrNQtF/PInrE7nKeQTvFIrukxawqq2/Jb3E/132vHwuenk95lyoU3kunvm l8PXFioo8juSvdRAgsus+fVNP4CG7slvGa2M0l0bXaoKflFfZNEevnrR3CecVsfw ==
X-ME-Sender: <xms:vfTXWr1bUvGcaJT8X9G5YfG2m7scE0hUDDqAu84BffMINZx2yJblTQ>
Received: from rtp-alcoop-nitro2.cisco.com (unknown [173.38.117.67]) by mail.messagingengine.com (Postfix) with ESMTPA id CDB0FE4350; Wed, 18 Apr 2018 21:45:32 -0400 (EDT)
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
From: Alissa Cooper <alissa@cooperw.in>
In-Reply-To: <16FAE862-3F10-4325-AB87-5DF31FBADF09@ericsson.com>
Date: Wed, 18 Apr 2018 21:45:32 -0400
Cc: Roni Even <ron.even.tlv@gmail.com>, "gen-art@ietf.org" <gen-art@ietf.org>, "core@ietf.org" <core@ietf.org>, "draft-ietf-core-senml.all@ietf.org" <draft-ietf-core-senml.all@ietf.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <D794B7A5-54BA-4773-9AFE-4484569686C1@cooperw.in>
References: <152221578820.29905.10455247933119493699@ietfa.amsl.com> <16FAE862-3F10-4325-AB87-5DF31FBADF09@ericsson.com>
To: Ari Keränen <ari.keranen@ericsson.com>
X-Mailer: Apple Mail (2.3124)
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/4t7BphjflgBjUnGU_YwX7F0WqPI>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-core-senml-13
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Apr 2018 01:45:36 -0000

Roni, thanks for your reviews. Ari, thanks for making the fixes. I have entered a Yes ballot.

Alissa

> On Mar 30, 2018, at 7:03 AM, Ari Keränen <ari.keranen@ericsson.com> wrote:
> 
> Thank you for the review Roni! Good catches. 
> 
> Seems we forgot to update the EXI example offsets when regenerated the examples. I made a PR to include these fixes in the next revision: https://github.com/core-wg/senml-spec/pull/102/files
> 
> 
> Cheers,
> Ari
> 
>> On 28 Mar 2018, at 8.43, Roni Even <ron.even.tlv@gmail.com> wrote:
>> 
>> Reviewer: Roni Even
>> Review result: Ready with Nits
>> 
>> I am the assigned Gen-ART reviewer for this draft. The General Area
>> Review Team (Gen-ART) reviews all IETF documents being processed
>> by the IESG for the IETF Chair.  Please treat these comments just
>> like any other last call comments.
>> 
>> For more information, please see the FAQ at
>> 
>> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
>> 
>> Document: draft-ietf-core-senml-??
>> Reviewer: Roni Even
>> Review Date: 2018-03-27
>> IETF LC End Date: 2018-03-30
>> IESG Telechat date: 2018-04-19
>> 
>> Summary:
>> The document is ready for publication as a standard track RFC with nits
>> 
>> Major issues:
>> 
>> Minor issues:
>> 
>> Nits/editorial comments:
>> 
>> 1. in section 5.1.6 "another devices" should be "other devices" or "another
>> device" 2. in section 8  "It can simply hard code the output replacing the
>> 1-wire device ID starting at byte 0x20 and going to byte 0x2F with it's device
>> ID". I think that the offset ix 0x10 to 0x1f
>> 
>> 
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art

v2.23.0 | Report a Bug | By Email