Re: [Gen-art] Genart last call review of draft-ietf-idr-bgp-ls-flex-algo-09
Ketan Talaulikar <ketant.ietf@gmail.com> Fri, 19 August 2022 01:47 UTC
Return-Path: <ketant.ietf@gmail.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 95A3DC1524D0; Thu, 18 Aug 2022 18:47:14 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.105
X-Spam-Level:
X-Spam-Status: No, score=-2.105 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zH4pXbZP4X-l; Thu, 18 Aug 2022 18:47:13 -0700 (PDT)
Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 68878C152712; Thu, 18 Aug 2022 18:46:24 -0700 (PDT)
Received: by mail-ed1-x536.google.com with SMTP id b16so3990408edd.4; Thu, 18 Aug 2022 18:46:24 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=whx6sdTPqV6GHLwuQrkyWCo0hJ8RNptwZd/fTdkHrAg=; b=pULdkvDbHNjhPA9Iy5PBomLcvIZBrB3X71LKjawydkcyX8uL/4qna4YBjc2E5qc1XN q9iQ+sW9mQZvhgPBRvxFLbnGl71kO1CF2dfdGUToEM3Ef3iWmAwUaAZqJqre9M7oztSL P3LKPSutZ0M8ZfyQo23U8mk5kcgk8WcbqcRlG6GK4qZdqL85Qp+Ir1U0dwpSLNfxtwnu tRCZlIkyglHGGRYtQlsKXWoq+WlNl8/twWmpeo8a4kvsnW8GX9AA5qECLERrag2yT69g ush+oP6jVCH4bbTAVZ5pp/wJVAHhKg9HTSmAx/pQojeSgsgKefd/SNxnKAeofDC4nM0Y Qo5Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=whx6sdTPqV6GHLwuQrkyWCo0hJ8RNptwZd/fTdkHrAg=; b=GlfxWcjkn/Mu/T1kWRR6/4LEErhq8eZIrGkRDvLtEvioETM2jOJ6YCFbl0Py8WNPZP h67fnaiedVB01M9JNsWOlTUZ6v2Vbld5gwGUvSEsAGcFQswas5FULyzQ8Oysn0+Q71tA 8exnQc8yf1BgUqX1OwzofkENi9LvhzT82cyWWMoxGSR9/OpKGN61m7y4gtfQcHwuoo9R iH6PQhlQfPbyyVpsWGT+eKkMhsJ4TJ3AOEI52DqMV7PpekViANhLUGYPaBBKZEQ5VJM2 2SldF3qiC3oHpOCps1Sz+i+tRA7jeAhR89DZQIHccE/wTSjq3oDaLJhKK5P00ZSH+9sq yBmw==
X-Gm-Message-State: ACgBeo3FFP7WvRX1TNWoUPY5+oGh4fzZ0s0DB2WYEfm/EUI7Az2Brulw mCraOgxThmT0H4EVXgd9WoN1E/qepOeueaDX0DWWQOHue/o=
X-Google-Smtp-Source: AA6agR6HEhJaUjFKSYevrUyE8g5LRjdnG7aI4ZyLNFGJd+lVf+q7F3c8Mo3CKB5pUJrfTQB+aKPf7SlXftsl1qQJtnI=
X-Received: by 2002:a05:6402:378e:b0:43e:73f7:5c53 with SMTP id et14-20020a056402378e00b0043e73f75c53mr4209983edb.124.1660873582927; Thu, 18 Aug 2022 18:46:22 -0700 (PDT)
MIME-Version: 1.0
References: <166033385333.7724.14555622442470360665@ietfa.amsl.com> <CAH6gdPxVPGpzLwGWxpHEmUNJKVWZQ1pB7CXPeWxMt4tdQnUX9Q@mail.gmail.com> <CAMMTW_KKuY2DphishuXNpnW=yKr0_N4tTRVE3X=Hf5WfvFNANA@mail.gmail.com>
In-Reply-To: <CAMMTW_KKuY2DphishuXNpnW=yKr0_N4tTRVE3X=Hf5WfvFNANA@mail.gmail.com>
From: Ketan Talaulikar <ketant.ietf@gmail.com>
Date: Fri, 19 Aug 2022 07:16:11 +0530
Message-ID: <CAH6gdPxMBe6oXxWMdn=H-SmajE-G_grh+USV-iAFhtUUtodS9w@mail.gmail.com>
To: Vijay Gurbani <vijay.gurbani@gmail.com>
Cc: gen-art@ietf.org, draft-ietf-idr-bgp-ls-flex-algo.all@ietf.org, idr@ietf.org, last-call@ietf.org
Content-Type: multipart/alternative; boundary="000000000000ed64a605e68e4379"
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/4ubRm6wEBhZ2hTStrz2B4MNccxw>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-idr-bgp-ls-flex-algo-09
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 19 Aug 2022 01:47:14 -0000
Hi Vijay, The recent update below includes changes to address your comments. https://datatracker.ietf.org/doc/html/draft-ietf-idr-bgp-ls-flex-algo-10 Thanks, Ketan On Sun, Aug 14, 2022 at 7:00 AM Vijay Gurbani <vijay.gurbani@gmail.com> wrote: > Dear Ketan: Sounds good. Thank you for your time attending to my comments. > > - vijay > > On Sat, Aug 13, 2022 at 12:26 AM Ketan Talaulikar <ketant.ietf@gmail.com> > wrote: > >> Hi Vijay, >> >> Thanks for your review and please check inline below for responses. >> >> The changes discussed below would reflect in the next update of the >> document. >> >> On Sat, Aug 13, 2022 at 1:20 AM Vijay Gurbani via Datatracker < >> noreply@ietf.org> wrote: >> >>> Reviewer: Vijay Gurbani >>> Review result: Ready with Nits >>> >>> I am the assigned Gen-ART reviewer for this draft. The General Area >>> Review Team (Gen-ART) reviews all IETF documents being processed >>> by the IESG for the IETF Chair. Please treat these comments just >>> like any other last call comments. >>> >>> For more information, please see the FAQ at >>> >>> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>. >>> >>> Document: draft-ietf-idr-bgp-ls-flex-algo-?? >>> Reviewer: Vijay K. Gurbani >>> Review Date: 2022-08-12 >>> IETF LC End Date: 2022-08-17 >>> IESG Telechat date: Not scheduled for a telechat >>> >>> Summary: Draft is ready with nits for a Proposed Standard. >>> >>> Major issues: 0 >>> >>> Minor issues: 1 (please see below) >>> >>> Nits/editorial comments: 4 (please see below) >>> >>> Minor: >>> - Sec. 3.6: Note that Type is "TBD" here. Should this be 1046, as shown >>> in >>> Table 1? (Or is the use of 1046 still under discussion?) >>> >> >> KT> This allocation is currently under "Expert Review" - at this point, >> it is a suggested code point. This will hopefully be completed soon and we >> will update the document once done. >> >> >>> >>> Nits: >>> - I note that certain acronyms --- IGP, NLRI, ASLA --- are not defined. >>> I >>> suspect that these are well-known in the community, hence need no >>> definition. >>> Just in case they are not, you may consider expanding the rare ones on >>> first >>> use. >> >> >> KT> Ack. Fixed some of these acronyms that are not well-known on their >> first use. >> >> >>> - Sec. 1: s/Flexible algorithm is called so as/Flexible algorithm is so >>> called because/ >> >> >> KT> Fixed >> >> >>> - Sec. 2: s/Definition(s) (FAD) advertised by a node >>> is/Definition(s) (FAD) advertised by a node is (are)/ >>> Reason: symmetry in the sentence construction >>> >> >> KT> Fixed >> >> >>> - Sec. 3.6: Is Figure 7 missing the trailing "//" for sub-TLV tpes? >>> >> >> KT> Fixed. >> >> Thanks, >> Ketan >> >> >>> >>> Thanks. >>> >>> >>> >>>
- [Gen-art] Genart last call review of draft-ietf-i… Vijay Gurbani via Datatracker
- Re: [Gen-art] Genart last call review of draft-ie… Ketan Talaulikar
- Re: [Gen-art] Genart last call review of draft-ie… Vijay Gurbani
- Re: [Gen-art] Genart last call review of draft-ie… Ketan Talaulikar
- Re: [Gen-art] Genart last call review of draft-ie… Vijay Gurbani
- Re: [Gen-art] [Last-Call] Genart last call review… Lars Eggert