Re: [Gen-art] Review of draft-ietf-6tisch-minimal-17
Thomas Watteyne <thomas.watteyne@inria.fr> Wed, 04 January 2017 12:38 UTC
Return-Path: <thomas.watteyne@inria.fr>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5E547129546; Wed, 4 Jan 2017 04:38:31 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.499
X-Spam-Level:
X-Spam-Status: No, score=-9.499 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_SORBS_SPAM=0.5, RP_MATCHES_RCVD=-3.1] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CwNPphNEsPsp; Wed, 4 Jan 2017 04:38:28 -0800 (PST)
Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr [192.134.164.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 92DED129545; Wed, 4 Jan 2017 04:38:26 -0800 (PST)
X-IronPort-AV: E=Sophos;i="5.33,459,1477954800"; d="scan'208,217";a="206924822"
Received: from mail-ua0-f177.google.com ([209.85.217.177]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/AES128-GCM-SHA256; 04 Jan 2017 13:38:24 +0100
Received: by mail-ua0-f177.google.com with SMTP id 88so343280443uaq.3; Wed, 04 Jan 2017 04:38:24 -0800 (PST)
X-Gm-Message-State: AIkVDXK9E5utQWVGrn3JKlIq6BZNlTfH/qn0Vjjogul/VRkyZGPKBbYNByr1SEbUwHa4sneGMlNdcTpRShZGuQ==
X-Received: by 10.159.49.11 with SMTP id m11mr53383684uab.178.1483533503185; Wed, 04 Jan 2017 04:38:23 -0800 (PST)
MIME-Version: 1.0
Received: by 10.31.140.4 with HTTP; Wed, 4 Jan 2017 04:38:02 -0800 (PST)
In-Reply-To: <148140959184.3857.2236566242217564901.idtracker@ietfa.amsl.com>
References: <148140959184.3857.2236566242217564901.idtracker@ietfa.amsl.com>
From: Thomas Watteyne <thomas.watteyne@inria.fr>
Date: Wed, 04 Jan 2017 13:38:02 +0100
X-Gmail-Original-Message-ID: <CADJ9OA8vju=Y13u8EtfsrpT0Kcaf4X-TWzmgfJ=oKkWo+pdxWw@mail.gmail.com>
Message-ID: <CADJ9OA8vju=Y13u8EtfsrpT0Kcaf4X-TWzmgfJ=oKkWo+pdxWw@mail.gmail.com>
To: Brian Carpenter <brian.e.carpenter@gmail.com>
Content-Type: multipart/alternative; boundary="f403045e257e7850490545440f2f"
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/5SsxuNZyXIcDJCZSFjxcT61wPK8>
Cc: gen-art@ietf.org, "6tisch@ietf.org" <6tisch@ietf.org>, draft-ietf-6tisch-minimal.all@ietf.org
Subject: Re: [Gen-art] Review of draft-ietf-6tisch-minimal-17
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Jan 2017 12:38:31 -0000
Brian, Just a quick admin update that the authors have taken your comments into account, which will be integrated in -18. We will discuss the proposed resolutions at an interim meeting this Friday and publish it next week. Thomas On Sat, Dec 10, 2016 at 11:39 PM, Brian Carpenter < brian.e.carpenter@gmail.com> wrote: > Reviewer: Brian Carpenter > Review result: Almost Ready > > Gen-ART Last Call review of draft-ietf-6tisch-minimal-17 > > I am the assigned Gen-ART reviewer for this draft. The General Area > Review Team (Gen-ART) reviews all IETF documents being processed > by the IESG for the IETF Chair. Please treat these comments just > like any other last call comments. > > For more information, please see the FAQ at > <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>. > > Document: draft-ietf-6tisch-minimal-17.txt > Reviewer: Brian Carpenter > Review Date: 2016-12-11 > IETF LC End Date: 2016-12-20 > IESG Telechat date: 2017-01-05 > > Summary: Almost Ready > -------- > > Comment: > -------- > > Although I found some issues, this is a good document which is mainly > very clear. I was not in a position to check IEEE802.15.4 details. > > It's too late now, but judging by the shepherd's writeup, this draft > would have been an excellent candidate for an Implementation Status > section under RFC 6982. > > Major Issues: > ------------- > > I was very confused for several pages until I went back and read this > again: > > > This specification defines operational parameters and procedures > for > > a minimal mode of operation to build a 6TiSCH Network. The > 802.15.4 > > TSCH mode, the 6LoWPAN framework, RPL [RFC6550], and its Objective > > Function 0 (OF0) [RFC6552], are used unmodified. > > Then I realised that there is some very basic information missing at > the beginning > of the Introduction. That little phrase "the 6LoWPAN framework" seems > to be the clue. > What is the 6LoWPAN framework? Which RFCs? I'm guessing it would be > RFC4944, RFC6282 > and RFC6775, but maybe not. In any case, the very first sentence of > the Introduction > really needs to be a short paragraph that explains in outline, with > citations, how a > 6TiSCH network provides IPv6 connectivity over NBMA. With that, the > rest of the document > makes sense. > > But related to that, the Abstract is confusing in the same way: > > > Abstract > > > > This document describes a minimal mode of operation for a 6TiSCH > > Network. It provides IPv6 connectivity over a Non-Broadcast > Multi- > > Access (NBMA) mesh... > > "It" is confusing since it seems to refer to this document, which > hardly > mentions IPv6 connectivity. I suggest s/It/6TiSCH/. > > As far as I know a Security Considerations section is still always > required. I understand > that this document discusses security in detail, but that doesn't > cancel the > requirement (https://tools.ietf.org/html/rfc3552#section-5). > > Minor issues: > ------------- > > > 4.4. Timeslot Timing > ... > > The RX node needs to send the first bit after the > > SFD of the MAC acknowledgment exactly tsTxAckDelay after the end > of > > the last byte of the received packet. > > I don't understand "exactly". Nothing is exact - there is always clock > jitter. > Shouldn't there be a stated tolerance rather than "exactly"? > > > 4.5. Frame Formats > > > > The following sections detail the RECOMMENDED format of link-layer > > frames of different types. A node MAY use a different formats > (bit > > settings, etc)... > > Doesn't this create an interoperability issue for independent > implementations? > How can you mix and match implementations that use variants of the > frame format? > This seems particularly strange: > > > The IEEE802.15.4 header of BEACON, DATA and ACKNOWLEDGMENT frames > > SHOULD include the Source Address field and the Destination > Address > > field. > > How will it work if some nodes omit the addresses? > > > 4.6. Link-Layer Security > ... > > For early interoperability testing, value 36 54 69 53 43 48 20 6D > 69 > > 6E 69 6D 61 6C 31 35 ("6TiSCH minimal15") MAY be used for K1. > > Shouldn't this also say that this value MUST NOT be used in > operational networks? > > Nits: > ----- > > > 1. Introduction > > > > A 6TiSCH Network provides IPv6 connectivity... > > I would expect to see a reference to [RFC2460] right there. > > Outdated reference: draft-ietf-6lo-paging-dispatch has been published > as RFC 8025 > > -- _______________________________________ Thomas Watteyne, PhD Research Scientist & Innovator, Inria Sr Networking Design Eng, Linear Tech Founder & co-lead, UC Berkeley OpenWSN Co-chair, IETF 6TiSCH www.thomaswatteyne.com _______________________________________
- [Gen-art] Review of draft-ietf-6tisch-minimal-17 Brian Carpenter
- Re: [Gen-art] [6tisch] Review of draft-ietf-6tisc… Xavi Vilajosana Guillen
- Re: [Gen-art] Review of draft-ietf-6tisch-minimal… Thomas Watteyne
- Re: [Gen-art] Review of draft-ietf-6tisch-minimal… Thomas Watteyne
- Re: [Gen-art] Review of draft-ietf-6tisch-minimal… Brian E Carpenter
- Re: [Gen-art] [6tisch] Review of draft-ietf-6tisc… Tero Kivinen
- Re: [Gen-art] [6tisch] Review of draft-ietf-6tisc… Kristofer PISTER
- Re: [Gen-art] [6tisch] Review of draft-ietf-6tisc… PWK
- Re: [Gen-art] [6tisch] Review of draft-ietf-6tisc… Tero Kivinen
- Re: [Gen-art] Review of draft-ietf-6tisch-minimal… Brian E Carpenter