Re: [Gen-art] Genart telechat review of draft-ietf-anima-bootstrapping-keyinfra-28

Michael Richardson <mcr+ietf@sandelman.ca> Mon, 28 October 2019 22:06 UTC

Return-Path: <mcr+ietf@sandelman.ca>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1E0FC12099E; Mon, 28 Oct 2019 15:06:31 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.2
X-Spam-Level:
X-Spam-Status: No, score=-4.2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gMZNlZ3UD3B7; Mon, 28 Oct 2019 15:06:29 -0700 (PDT)
Received: from tuna.sandelman.ca (tuna.sandelman.ca [IPv6:2607:f0b0:f:3:216:3eff:fe7c:d1f3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1737C12094F; Mon, 28 Oct 2019 15:06:24 -0700 (PDT)
Received: from sandelman.ca (obiwan.sandelman.ca [IPv6:2607:f0b0:f:2::247]) by tuna.sandelman.ca (Postfix) with ESMTP id B263F3897A; Mon, 28 Oct 2019 18:03:41 -0400 (EDT)
Received: from localhost (localhost [IPv6:::1]) by sandelman.ca (Postfix) with ESMTP id CE9133BF0; Mon, 28 Oct 2019 18:06:23 -0400 (EDT)
From: Michael Richardson <mcr+ietf@sandelman.ca>
To: tom petch <daedulus@btconnect.com>
cc: Alissa Cooper <alissa@cooperw.in>, Dan Romascanu <dromasca@gmail.com>, "gen-art@ietf.org" <gen-art@ietf.org>, "draft-ietf-anima-bootstrapping-keyinfra.all@ietf.org" <draft-ietf-anima-bootstrapping-keyinfra.all@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>, "anima@ietf.org" <anima@ietf.org>
In-Reply-To: <048901d585ad$25f8dac0$4001a8c0@gateway.2wire.net>
References: <157095596011.20750.2703747454081790983@ietfa.amsl.com> <00f001d5833c$52aacf60$4001a8c0@gateway.2wire.net> <6CF1EF8F-EE0D-4BE6-B2C2-4C91883A881B@cooperw.in> <048901d585ad$25f8dac0$4001a8c0@gateway.2wire.net>
X-Mailer: MH-E 8.6; nmh 1.7+dev; GNU Emacs 24.5.1
X-Face: $\n1pF)h^`}$H>Hk{L"x@)JS7<%Az}5RyS@k9X%29-lHB$Ti.V>2bi.~ehC0; <'$9xN5Ub# z!G,p`nR&p7Fz@^UXIn156S8.~^@MJ*mMsD7=QFeq%AL4m<nPbLgmtKK-5dC@#:k
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-="; micalg="pgp-sha256"; protocol="application/pgp-signature"
Date: Mon, 28 Oct 2019 18:06:23 -0400
Message-ID: <26165.1572300383@localhost>
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/5kmDXuHPgizp-ZOd0DC7WPk1_Gg>
Subject: Re: [Gen-art] Genart telechat review of draft-ietf-anima-bootstrapping-keyinfra-28
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 28 Oct 2019 22:06:35 -0000

tom petch <daedulus@btconnect.com> wrote:
    > Looking some more at this I-D, I have more concerns about the YANG
    > module. My review is informal - I recommend that the WG Chair request a
    > formal review because I may be missing something particularly in
    > connection with the 'refine' statements.

    > The I-D has namespace
    > "urn:ietf:params:xml:ns:yang:ietf-voucher-request"; prefix "vch";
    > whereas RFC8366, which it augments, has namespace
    > "urn:ietf:params:xml:ns:yang:ietf-voucher"; prefix vch; Different
    > module, same prefix; this contradicts a SHOULD NOT in RFC8407.

okay, so I shoudl change it to "vcr" for VouCher Request then?
I think that this will have affects on the constrained-voucher document, but
that is easily fixed.

    > Further, this I-D defines import ietf-voucher { prefix v; i.e. does not
    > use the prefix defined in RFC8366.  This contradicts a MUST in RFC8407.

okay, got it, fixed it.

    > There is a discrepancy between the e-mail addresses of the authors of
    > the YANG module and of the I-D, for
    > Author: Kent Watsen Author:

Fixed.

    > Toerless Eckert I note that the e-mail addresses for the YANG module
    > are the same as those for the YANG module in RFC8366; I do not know
    > which are correct.

People moved to different companies since publication :-)

    >   contact "WG Web: <http://tools.ietf.org/wg/anima/> should be https:
    > and usually points to datatracker.ietf.org not tools

Fixed.

--
Michael Richardson <mcr+IETF@sandelman.ca>, Sandelman Software Works
 -= IPv6 IoT consulting =-