Re: [Gen-art] Genart last call review of draft-ietf-pce-stateful-path-protection-08
Dhruv Dhody <dhruv.ietf@gmail.com> Thu, 29 August 2019 10:17 UTC
Return-Path: <dhruv.ietf@gmail.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BE52C120145; Thu, 29 Aug 2019 03:17:51 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.999
X-Spam-Level:
X-Spam-Status: No, score=-1.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NHCriNywwRTo; Thu, 29 Aug 2019 03:17:50 -0700 (PDT)
Received: from mail-io1-xd2d.google.com (mail-io1-xd2d.google.com [IPv6:2607:f8b0:4864:20::d2d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5EE2312011C; Thu, 29 Aug 2019 03:17:47 -0700 (PDT)
Received: by mail-io1-xd2d.google.com with SMTP id t3so5730780ioj.12; Thu, 29 Aug 2019 03:17:47 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xCTZD+WL68zDTYu5c80XbQbDDce4+hobZSNt9Wtp+Sk=; b=RjxyiQSqz5Ifk5cuUs4VBB5khezxXdyvratGhf4ID4o/RoyHASgI2CMaCURVoKZEuw 5ppZHlTgKFJTJmDsl/ajAs5x00rSMex5xTWM8KCePFTrOD7ur3ppwnz/YM26DGslsRiK W4HARF+ZincKIeMhcks+riY11YsHg2z8sNuDUzKW6fAfSJd9hGLLoX3W1q/RQ//6r/Dg lwnmnqEAA7gsOv3sl8hOZ7xObCge4vK/von6PMGhNUTjKetz5wgXY3PyqMflLFXNnQPM LSfTvfI9uvxaBg1qiJwAfMy0XNr4qde0btktO0kO3VncT0LT8WruU5lqbMC2u6J46z/2 pEUg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xCTZD+WL68zDTYu5c80XbQbDDce4+hobZSNt9Wtp+Sk=; b=N4NkHjKZeFZpzwkBL2EPEYTHNfa7WAVgnnq/c1EV4UukVwD0Fz/DqFdyRGCD1gJJcy zwK6pequEkVrWwcsgfobLoIxY5X7CiDZ4Rb60DxIHSIkTMGoHzdyJi9deRXOqLZeBACu agepjuByDjQN58vOXkqxYK6jartTZeLWztkaCa93jPVoG1V7p8f7m0K0YkqexIM0OMom J/MRy7vFGYG5JZKoYndU1vNzpoVTdH0D3UiIOFdBlB9E4z9Pd1UhG/GYKR1Z3u44AO/Y UhHFAyZV9/yqWQinpBaHBKs028Ib9JgyWorqJdpXNWURFvtECzqs9/8VpRy66SCmwxlX 6alQ==
X-Gm-Message-State: APjAAAWpRUuof+s+iajr3zaLgrtL6m9GJEMtEnSf4PY8+32+tqjnCjnp AcxJgILOBR/of8IQMQzzCFhIIwaJxGPfLtlduyQ=
X-Google-Smtp-Source: APXvYqy/oQ/mSSQl5KOJ2gG5kC3kCwsWIytwdcU0vCTp8oYQkRqdH432hqZ9hHlr1+v++kpCuXQCqOh9TC2CiQaeYMM=
X-Received: by 2002:a6b:c98c:: with SMTP id z134mr10073177iof.276.1567073866369; Thu, 29 Aug 2019 03:17:46 -0700 (PDT)
MIME-Version: 1.0
References: <156704789212.1265.12949882127746399605@ietfa.amsl.com>
In-Reply-To: <156704789212.1265.12949882127746399605@ietfa.amsl.com>
From: Dhruv Dhody <dhruv.ietf@gmail.com>
Date: Thu, 29 Aug 2019 15:47:08 +0530
Message-ID: <CAB75xn5aTWMUy1JonEe6LSBjiG4_uYFy0rt5ea68E2mFjthUOQ@mail.gmail.com>
To: Pete Resnick <resnick@episteme.net>
Cc: General Area Review Team <gen-art@ietf.org>, draft-ietf-pce-stateful-path-protection.all@ietf.org, pce@ietf.org, "ietf@ietf.org Discussion" <ietf@ietf.org>
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/5ko9I1zgwIDN8omJFR8hZKBvsVg>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-pce-stateful-path-protection-08
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Aug 2019 10:17:52 -0000
Hi Pete, Thanks for your review and nits. Just snipping to two points... > OLD > | PT | Path Protection Association Flags |S|P| > NEW > | PT | Unassigned |S|P| > I feel it is important to keep the name "flags" in the figure to match with the text following the figure. Also this seems to be our usual practice in past documents as well. We can change to just "flags" if you would prefer that? For context -> The format of the Path Protection Association TLV (Figure 1) is as follows: 0 1 2 3 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ | Type = TBD2 | Length | +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ | PT | Path Protection Association Flags |S|P| +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ Figure 1: Path Protection Association TLV format Path Protection Association Flags (32 bits) - The following flags are currently defined - Protecting (P): 1 bit - This bit is as defined in Section 14.1 of [RFC4872] to indicate if the LSP is working or protection LSP. Secondary (S): 1 bit - This bit is as defined in Section 14.1 of [RFC4872] to indicate if the LSP is primary or secondary LSP. The S flag is ignored if the P flag is not set. Protection Type (PT): 6 bits - This field is as defined in Section 14.1 of [RFC4872] to indicate the LSP protection type in use. Unassigned bits are considered reserved. They MUST be set to 0 on transmission and MUST be ignored on receipt. > Section 6: > > At the top of the section, I suggest putting in the following: > > [Note to RFC Editor and IANA: Sections 3.1, 3.2, and 4.5 contain "TBD1" through > "TBD5" those should be replaced by the values that IANA assigns. Also, Section > 4.5 includes several occurrences of the phrase "(Early allocation by IANA)"; > please confirm that the value mentioned there is correct and delete that phrase > from the document before publication.] > I would suggest the authors to remove the phrase "(Early allocation by IANA)" in the document now as the referenced draft is in RFC-EDITOR queue and the early allocation tag is removed in the IANA page - https://www.iana.org/assignments/pcep/pcep.xhtml#pcep-objects Thanks! Dhruv
- [Gen-art] Genart last call review of draft-ietf-p… Pete Resnick via Datatracker
- Re: [Gen-art] Genart last call review of draft-ie… Dhruv Dhody
- Re: [Gen-art] Genart last call review of draft-ie… Pete Resnick
- Re: [Gen-art] Genart last call review of draft-ie… Mahend Negi