[Gen-art] Re: Genart last call review of draft-ietf-sidrops-rrdp-desynchronization-01

Job Snijders <job@fastly.com> Mon, 12 August 2024 17:10 UTC

Return-Path: <job@fastly.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E5968C14F5F1 for <gen-art@ietfa.amsl.com>; Mon, 12 Aug 2024 10:10:43 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.105
X-Spam-Level:
X-Spam-Status: No, score=-2.105 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=fastly.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id suN9z6hJcBGE for <gen-art@ietfa.amsl.com>; Mon, 12 Aug 2024 10:10:39 -0700 (PDT)
Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E8E6CC15152C for <gen-art@ietf.org>; Mon, 12 Aug 2024 10:10:39 -0700 (PDT)
Received: by mail-lf1-x131.google.com with SMTP id 2adb3069b0e04-52efbb55d24so8010840e87.1 for <gen-art@ietf.org>; Mon, 12 Aug 2024 10:10:39 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastly.com; s=google; t=1723482637; x=1724087437; darn=ietf.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=86hoWRZPIo6ZQX5AO55QQsVnybDTgkmjZ8fLm2najJA=; b=hNOrMcGNysxSUMOLu7ibyDRoHBivFv35d7mW0thMLW9Ho+EDC43K3JbEbHXxOIsld3 t3wXZIq6nu7nNq7REU6rW5wxFNnrL3H+BEOYeOTumRYO/IdD9/FWJak1sUqgbZ/1rcMF 8/WsPEBkFRY0UEUJXlRubejhzse6kT2rr8/OU=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723482637; x=1724087437; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=86hoWRZPIo6ZQX5AO55QQsVnybDTgkmjZ8fLm2najJA=; b=v+BlcelLV0zmUg0OyMGSqF/HMNNsYiHBwQcCPCDFtWHvWYN8tF2uSkomorAcJhFhEN d6u5Pf0EI9byot4rSzPZ/jb9jczUxyyi7+5zn67iW+KqMRHcKo0CHMuPizgJzLEeufJ+ N4QuVvNmf8ldrCSZkb4LirdLTbu4dW4mUx+521PFP1rgM5LAqYNIn3o5G2uy+fNsw+Mq pxBOVN3Y7Qpy++Boe2Ka6vuYYrYdmL54MHgJSGU9oFizPX0uHjsFCa/le/KZWk743j4+ 09C+EmT1L3br6Wn86kywwbN9+tlbNBaZ4GlOrTHKwJH+S7r1+Sa5oraGYxt8gBQkZsnf yxzQ==
X-Gm-Message-State: AOJu0Yw9s1CzDFlWElgynSq7qjy5IeFv5f7LAHygciXV5Z03YZivYEOY 8p4YdBnir5yBmFTNf74fEne/5De+FFOLy8YetXw+oOSFdDg3PDRX+LbgPO8P8F4=
X-Google-Smtp-Source: AGHT+IE2o8iszZq44ydiunUbuU5T3dHx+/lCIM3uY49Y18u94XLcd+vSyKVSbNu0UAwYkx0PRqWYxA==
X-Received: by 2002:a05:6512:1195:b0:52c:d5ac:d42 with SMTP id 2adb3069b0e04-53213647abemr766058e87.9.1723482637225; Mon, 12 Aug 2024 10:10:37 -0700 (PDT)
Received: from snel (mieli.sobornost.net. [45.138.228.4]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a80bb1cd2a8sm245091666b.117.2024.08.12.10.10.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Aug 2024 10:10:36 -0700 (PDT)
Date: Mon, 12 Aug 2024 19:10:35 +0200
From: Job Snijders <job@fastly.com>
To: Behcet Sarikaya <sarikaya@ieee.org>
Message-ID: <ZrpCC7m94O7aE-bI@snel>
References: <172348201655.758248.9977007369189728485@dt-datatracker-6df4c9dcf5-t2x2k>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <172348201655.758248.9977007369189728485@dt-datatracker-6df4c9dcf5-t2x2k>
X-Clacks-Overhead: GNU Terry Pratchett
Message-ID-Hash: QI6H4Y6PY6S6MFPXCJLGUYP7DLHJJD7G
X-Message-ID-Hash: QI6H4Y6PY6S6MFPXCJLGUYP7DLHJJD7G
X-MailFrom: job@fastly.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-gen-art.ietf.org-0; header-match-gen-art.ietf.org-1; header-match-gen-art.ietf.org-2; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: gen-art@ietf.org, draft-ietf-sidrops-rrdp-desynchronization.all@ietf.org, last-call@ietf.org, sidrops@ietf.org
X-Mailman-Version: 3.3.9rc4
Precedence: list
Subject: [Gen-art] Re: Genart last call review of draft-ietf-sidrops-rrdp-desynchronization-01
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/7-OW_LLI_U3lY9bYWPedFfsXtyo>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Owner: <mailto:gen-art-owner@ietf.org>
List-Post: <mailto:gen-art@ietf.org>
List-Subscribe: <mailto:gen-art-join@ietf.org>
List-Unsubscribe: <mailto:gen-art-leave@ietf.org>

Dear Behcet,

Thank you for your time reviewing this document.

On Mon, Aug 12, 2024 at 10:00:16AM -0700, Behcet Sarikaya via Datatracker wrote:
> Summary:The document describes an approach for RPKI Relying Parties to
> detect a particular form of RPKI Repository Delta Protocol (RRDP)
> session desynchronization and recover.
> 
> Major issues:
> 
> Minor issues:
> 
> Nits/editorial comments:
> The document is short, well-written but has a few nits.
> in section 3.1 it says
> Using its previously recorded state (Section 3.1)
>
> I don't understand (Section 3.1) here, it is already in Section 3.1.

The <xref> is a reference to the <sourcecode> element higher up in
section 3.1, I see that in the TXT rendering of this document it indeed
isn't entirely clear what the reference is too. I'll take it up with the
RFC Editor when we get there how to improve the reference and make it
clear what the previously recorded state is.

See
https://github.com/job/draft-sidrops-rrdp-desynchronization/blob/main/draft-ietf-sidrops-rrdp-desynchronization.xml#L183

points to
https://github.com/job/draft-sidrops-rrdp-desynchronization/blob/main/draft-ietf-sidrops-rrdp-desynchronization.xml#L151-L156

Thanks for spotting this

> The document is Informational and it is expected to become
> Informational RFC, then RFC 3967 rules should hold. This means that
> the document is describing a non-IETF protocol. I wonder if that is
> that the case?

The document provides new additional optional guidance on an existing
IETF protocol (RFC 8182). The document is Informational it doesn't
change the RRDP protocol, it relays implementation experience based on
operational experience.

> BTW, Relying Parties means essentially Service Providers.

Or academic researchers, or interested indirect stakeholders, or .. well
could be anyone really :-)

Kind regards,

Job