IETF Logo Mail Archive

Re: [Gen-art] Genart last call review of draft-ietf-mmusic-msrp-usage-data-channel-21

Brian E Carpenter <brian.e.carpenter@gmail.com> Mon, 13 July 2020 20:52 UTC

Return-Path: <brian.e.carpenter@gmail.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BB4053A098C; Mon, 13 Jul 2020 13:52:11 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.1
X-Spam-Level:
X-Spam-Status: No, score=-2.1 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, NICE_REPLY_A=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id H4EJB1hbZTx6; Mon, 13 Jul 2020 13:52:10 -0700 (PDT)
Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [IPv6:2607:f8b0:4864:20::42c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DFE8E3A0C39; Mon, 13 Jul 2020 13:52:01 -0700 (PDT)
Received: by mail-pf1-x42c.google.com with SMTP id u185so6571853pfu.1; Mon, 13 Jul 2020 13:52:01 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=fl8HK+tFXrrMMlc85OePMOJSCwqQ1T8MXAYEkMC84so=; b=bRm2CyPaXn7UTJ2Vkae4TGLlcptUL1ufURCun5asZdvrITePaaT7BeASF4fTTgKuCG 5L85/+UBluyAxUqD9CATrTlSfqFuPvxIELHHUHEPaXnBBE/c8Hbdu+ZX4YgXzdXlyzkE lBfu7672Qxn65XXw97IkQX5FJHKaALEtnZ3j5zFCGrS8XK600CjtKPgM5ETD/o55yhk3 XgCgv4Eoa+ruaQZowYn8EuwYXjIjWKzYS9uNlGh8MOzc6H7VF3kdJccrQw4LdL9uCTMZ rUXIdo4bKt52Eb1/Rm7yDhSPgJQbij/YTyNu7Rnrqp2vp/OhidR2sDFGRIEkOLVJyWS4 5pkQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=fl8HK+tFXrrMMlc85OePMOJSCwqQ1T8MXAYEkMC84so=; b=eTVEnwpqbkE+T2pOZFUsDu5YGKKo03s0/5ThSdfijALwR0mg/GjXm43j9ty4h+Fs7Y 1V0FU1cD5hZKl9hauparIb58v7VOYADtdvmFsSSny/S8LdW8HrLGnM5Uy2oahVjoXV7p +zLLwFvkdviLSjvO8mNArNsvwUIeYVLg0JdQrZr08PsvFy0rG6SxdUXDGv2ANmHe/Stc wgYHERyp2ukZnjrUylo7be/Bbue4JQPcRqPE7qvhGttF8pm2ulnd63Y4o1onO8NerQvI PCYHdtd3YCBMGB9jgY1YxvLwty9OhQejA3xmFROS0NaGcvLAqKGCDiOxHUwr2BIoCgma SKQg==
X-Gm-Message-State: AOAM533jIJDkg5EXtz98JAbWbogdmdDp23GsrkXpEWDKlApVnKZwXzr3 Xqo/CXu3Jl7aUaxBv8eV1Sf6wAjh
X-Google-Smtp-Source: ABdhPJz2gBQa9rFphFUJRyzJVSxxiIjQNtSypVG7A9ijDJxs2Kx7LUkd+9YtuDWmsoESWKOzVdKw3Q==
X-Received: by 2002:a65:6714:: with SMTP id u20mr771138pgf.121.1594673521102; Mon, 13 Jul 2020 13:52:01 -0700 (PDT)
Received: from [192.168.178.20] ([151.210.132.13]) by smtp.gmail.com with ESMTPSA id cv3sm402138pjb.45.2020.07.13.13.51.58 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 Jul 2020 13:52:00 -0700 (PDT)
To: Christer Holmberg <christer.holmberg@ericsson.com>, "gen-art@ietf.org" <gen-art@ietf.org>
Cc: "draft-ietf-mmusic-msrp-usage-data-channel.all@ietf.org" <draft-ietf-mmusic-msrp-usage-data-channel.all@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>, "mmusic@ietf.org" <mmusic@ietf.org>
References: <159459362316.14150.6160122631877971567@ietfa.amsl.com> <AM7PR07MB7012B935296554B783A0995393600@AM7PR07MB7012.eurprd07.prod.outlook.com>
From: Brian E Carpenter <brian.e.carpenter@gmail.com>
Message-ID: <1f035833-3efe-3444-3387-1c8feac48538@gmail.com>
Date: Tue, 14 Jul 2020 08:51:55 +1200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1
MIME-Version: 1.0
In-Reply-To: <AM7PR07MB7012B935296554B783A0995393600@AM7PR07MB7012.eurprd07.prod.outlook.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/71l8rbfrpAxIlo6CGEpnNLAOZXw>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-mmusic-msrp-usage-data-channel-21
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Jul 2020 20:52:12 -0000

Thanks Christer, that all looks good to me,

Regards
   Brian

On 13-Jul-20 20:58, Christer Holmberg wrote:
> Hi Brian,
> 
> Thank You for the review! Please see inline.
> 
> 
> Nits:
> -----
> 
>>> 4.1.  MSRP URI
>>> ....
>>>     transport  /= "dc"
>>>
>>> I see that RFC7977 takes a slightly different approach to updating the ABNF:
>>>
>>>     transport  =  "tcp" / "ws" / 1*ALPHANUM
>>>
>> The advantage of listing out
>>
>>  transport  =  "tcp" / "ws" / "dc" / 1*ALPHANUM
>>
>> would be that the reader sees the full list.
> 
> The MMUSIC WG has previously decided to take the approach of only writing the new value, using the "/=" format.
> 
> ---
> 
>>>                  ; Add "dc" to existing transports per [RFC4975]
>>>
>>> I suggest
>>>
>>>                 ; Add "dc" to existing transports per Section 9 of [RFC4975]
> 
> Will modify as suggested.
> 
> ---
> 
>>> 4.6.  Session Closing
>>>
>>>   The SDP answerer must ensure that no dcmap or dcsa attributes are
>>>   present in the SDP answer if no corresponding attributes are present
>>>   in the received SDP offer.
>>>
>>> Should that be MUST?
> 
> The reason for "must" is that is referring to generic data channel SDP O/A procedures.
> 
> I suggest to remove the paragraph.
> 
> ---
> 
>>> B2BUA
>>>
>>> Define the acronym please.
> 
> We normally don't do that in MMUSIC specifications. Also, it is on the IETF list of well-known acronyms.
> 
> Having said that, I am fine to enhance it on first occurrence: 'Back-to-Back User Agent (B2BUA)'
> 
> ---
> 
>>> 9.2.  Subprotocol Identifier MSRP
>>>
>>>   A reference to this document is added to the subprotocol identifier
>>>   "msrp" in the "WebSocket Subprotocol Name Registry"
>>>
>>> s/this document/RFCXXXX/
> 
> Will modify as suggested.
> 
> ---
> 
>>> 11.  CHANGE LOG
>>>
>>> Mark this section for deletion by the RFC Editor
> 
> I think the RFC Editor will delete it by default, but we can add explicit text.
> 
> Regards,
> 
> Christer
>

v2.23.0 | Report a Bug | By Email