Re: [Gen-art] Gen-ART Last Call review of draft-ietf-tsvwg-rfc4960-errata-06
Gorry Fairhurst <gorry@erg.abdn.ac.uk> Thu, 07 June 2018 10:33 UTC
Return-Path: <gorry@erg.abdn.ac.uk>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 797BF130EE7; Thu, 7 Jun 2018 03:33:05 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.899
X-Spam-Level:
X-Spam-Status: No, score=-1.899 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZlKUox8WoU0c; Thu, 7 Jun 2018 03:32:59 -0700 (PDT)
Received: from pegasus.erg.abdn.ac.uk (pegasus.erg.abdn.ac.uk [IPv6:2001:630:241:204::f0f0]) by ietfa.amsl.com (Postfix) with ESMTP id 29D78130ED2; Thu, 7 Jun 2018 03:32:59 -0700 (PDT)
Received: from Gs-MacBook-Pro.local (fgrpf.plus.com [212.159.18.54]) by pegasus.erg.abdn.ac.uk (Postfix) with ESMTPA id 4E6801B00204; Thu, 7 Jun 2018 11:32:52 +0100 (BST)
Message-ID: <5B1909D3.4050509@erg.abdn.ac.uk>
Date: Thu, 07 Jun 2018 11:32:51 +0100
From: Gorry Fairhurst <gorry@erg.abdn.ac.uk>
Reply-To: gorry@erg.abdn.ac.uk
Organization: University of Aberdeen
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:12.0) Gecko/20120428 Thunderbird/12.0.1
MIME-Version: 1.0
To: Michael Tuexen <Michael.Tuexen@macmic.franken.de>
CC: Christer Holmberg <christer.holmberg@ericsson.com>, Paul Kyzivat <pkyzivat@alum.mit.edu>, "draft-ietf-tsvwg-rfc4960-errata.all@ietf.org" <draft-ietf-tsvwg-rfc4960-errata.all@ietf.org>, General Area Review Team <gen-art@ietf.org>
References: <9c54eccb-82f2-e135-39af-6bf32824b648@alum.mit.edu> <D73AC219.30C7F%christer.holmberg@ericsson.com> <D73ADF2B.30D2E%christer.holmberg@ericsson.com> <21073937-e22d-2b13-ffc2-aec9e14fd3bb@erg.abdn.ac.uk> <D73AE907.30D50%christer.holmberg@ericsson.com> <D73AF870.30D78%christer.holmberg@ericsson.com> <F7AFF99B-5709-418B-BD70-5F3210E9EF0D@macmic.franken.de> <D73EAF20.30F9C%christer.holmberg@ericsson.com> <A587E359-6A0F-4803-82B4-B41D251B1239@macmic.franken.de>
In-Reply-To: <A587E359-6A0F-4803-82B4-B41D251B1239@macmic.franken.de>
Content-Type: text/plain; charset="UTF-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/8_kVafmZQlpCUb1wEZI9L648cqo>
Subject: Re: [Gen-art] Gen-ART Last Call review of draft-ietf-tsvwg-rfc4960-errata-06
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Jun 2018 10:33:06 -0000
+1, as Chair. I see we have caused a little confusion here - The WG will not repeat this list of changes again as a part of the new .bis document. There could always be potentially be further changes as the .bis document passes through the WG - of course - but we'd rather expect this spec is mature -- indeed there was suggestion the final Spec could progress to Full Standard (to be confirmed of course). Gorry On 07/06/2018, 11:19, Michael Tuexen wrote: >> On 7. Jun 2018, at 02:43, Christer Holmberg<christer.holmberg@ericsson.com> wrote: >> >> >> Hi, >> >>>> Not a comment on the document, but a question/suggestion: >>>> >>>> If you want to have a place holder for changes to be done in the bis >>>> (which seems to be the main purpose of the errata document), why not >>>> create a GitHub repo for the bis, and then document everything as GitHub >>>> issues? Then, when you start working on the bis, you can map each issue >>>> to >>>> a pull request etc. >>> We did use a github report using issues which working on this document. >>> >>> Replacing this document with an github issue tracker doesn't seem >>> attraktive to me. Github can go away at any time or gets replaced >>> by other tools and than the information would not be accessible >>> anymore. Please note that we document the changes and the reasoning >>> not for us, but for developers which are interested in it in the >>> future. >> Sure, but my understanding is that the future, i.e., the bis document, is >> coming soon, and I guess the bis document will anyway describe the changes >> (and the reasons) compared to RFC 4960. > Hi Christer, > > no it doesn't. It will be basically RFC 4960 + the diff from the errata > document applied. > > We did this in the past. See > RFC 2960 as the initial specification of SCTP. > RFC 4460 as an errata document > RFC 4960 as the updated specification of SCTP. > > As you see, RFC 4960, does not tell you what has changed or why. > If a developer is not interested in that and just wants to > implement SCTP, only the reading on RFC 4960 is needed. If > someone wants to understand the changes, he can read RFC 4460. > > Best regards > Michael >> Anyway, since I haven’t been involved in the work, I don’t want to argue >> about the way the WG is working. It was just a question/suggestion :) >> >> Regards, >> >> Christer >> >> >> >> >>>> Regards, >>>> >>>> Christer >>>> >>>> On 04/06/18 13:13, "Gen-art on behalf of Christer Holmberg" >>>> <gen-art-bounces@ietf.org on behalf of christer.holmberg@ericsson.com> >>>> wrote: >>>> >>>>> Hi Gorry, >>>>> >>>>> ... >>>>> >>>>>> The information in this document does not update RFC4640 or the Errata >>>>>> to that specification. The document is instead provided as input to >>>>>> preparation of a new document that is expected to be a standards-track >>>>>> replacement for RFC4960. If approved, the replacement document will >>>>>> incorporate the updates described here and any other changes needed to >>>>>> allow this to progress this specification along the standards track. >>>>> I am ok with the two first sentences. >>>>> >>>>> But, I don’t think you can make the last sentence. This document cannot >>>>> normatively define text for the replacement document, or assume that >>>>> everything will be incorporated: the WG will have to agree on what goes >>>>> into the replacement document once it has been added to the charter >>>>> etc, >>>>> using normal IETF procedures. >>>>> >>>>> Regards, >>>>> >>>>> Christer >>>>> >>>>> >>>>> >>>>>>>> On 03/06/18 21:59, "Gen-art on behalf of Paul Kyzivat" >>>>>>>> <gen-art-bounces@ietf.org on behalf of pkyzivat@alum.mit.edu> wrote: >>>>>>>> >>>>>>>>> [[INCOMPLETE, NOT READY TO SEND. PLEASE IGNORE]] >>>>>>>>> >>>>>>>>> I am the assigned Gen-ART reviewer for this draft. The General Area >>>>>>>>> Review Team (Gen-ART) reviews all IETF documents being processed by >>>>>>>>> the >>>>>>>>> IESG for the IETF Chair. Please treat these comments just like any >>>>>>>>> other >>>>>>>>> last call comments. For more information, please see the FAQ at >>>>>>>>> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>. >>>>>>>>> >>>>>>>>> Document: draft-ietf-tsvwg-rfc4960-errata-06 >>>>>>>>> Reviewer: Paul Kyzivat >>>>>>>>> Review Date: 2018-06-03 >>>>>>>>> IETF LC End Date: 2018-06-04 >>>>>>>>> IESG Telechat date: ? >>>>>>>>> >>>>>>>>> Summary: >>>>>>>>> >>>>>>>>> This draft is on the right track but has open issues, described in >>>>>>>>> the >>>>>>>>> review. >>>>>>>>> >>>>>>>>> Issues: >>>>>>>>> >>>>>>>>> Major: 1 >>>>>>>>> Minor: 2 >>>>>>>>> Nits: 1 >>>>>>>>> >>>>>>>>> 1) MAJOR: >>>>>>>>> >>>>>>>>> The format of this document disturbs me. According to the abstract: >>>>>>>>> >>>>>>>>> ... This >>>>>>>>> document provides deltas to RFC4960 and is organized in a time >>>>>>>>> ordered way. The issues are listed in the order they were >>>>>>>>> brought >>>>>>>>> up. Because some text is changed several times the last delta >>>>>>>>> in >>>>>>>>> the >>>>>>>>> text is the one which should be applied. >>>>>>>>> >>>>>>>>> This format makes the document hard to deal with. A developer who >>>>>>>>> wants >>>>>>>>> to implement sctp with some or all of the errata fixes will want to >>>>>>>>> work >>>>>>>>> from a variant of 4960 that incorporates all of those fixes - a >>>>>>>>> bis. >>>>>>>> But >>>>>>>>> it isn't clear how this document helps with that. I don't think you >>>>>>>>> can >>>>>>>>> start with 4960 and simply apply all the deltas sequentially, >>>>>>>>> because >>>>>>>>> overlapping changes won't work right. >>>>>>>>> >>>>>>>>> A developer won't be interested in the order in which errata were >>>>>>>>> reported. An actual bis document would be more useful to a >>>>>>>>> developer >>>>>>>>> than this format. Is that not being done because doing so would be >>>>>>>>> more >>>>>>>>> difficult? Or because it isn't yet certain that these are the >>>>>>>>> correct >>>>>>>>> fixes? >>>>>>>>> >>>>>>>>> I think you should give some serious consideration of the most >>>>>>>>> suitable >>>>>>>>> form for this document, in the context of how it is intended to be >>>>>>>>> used. >>>>>>>>> >>>>>>>>> 2) MINOR (maybe MAJOR): >>>>>>>>> >>>>>>>>> Discovering where one change is impacted by another change is hard. >>>>>>>>> >>>>>>>>> I dug into the details of the document to understand how many >>>>>>>>> places >>>>>>>>> there are actually overlaps between the changes in multiple >>>>>>>>> sections. >>>>>>>>> (It took a lot of work to do this.) I found five of these: >>>>>>>>> >>>>>>>>> - 3.1 / 3.23 >>>>>>>>> - 3.3 / 3.43 >>>>>>>>> - 3.5 / 3.10 >>>>>>>>> - 3.6 / 3.23 >>>>>>>>> - 3.24 / 3.32 >>>>>>>>> >>>>>>>>> (I don't guarantee that this list is exhaustive.) >>>>>>>>> >>>>>>>>> Of these, I think only one (3.1/3.23) explicitly indicates the >>>>>>>>> conflict, >>>>>>>>> and it only indicates it within 3.23. >>>>>>>>> >>>>>>>>> Most of the changes don't have any conflicts. And some of the >>>>>>>>> conflicts >>>>>>>>> could be removed by being more precise in indicating the change >>>>>>>>> being >>>>>>>>> made. In cases where this isn't possible, the presence of the >>>>>>>>> conflict >>>>>>>>> should be indicated in each section that has a conflict, with cross >>>>>>>>> references. IOW, shift the burden of detecting conflicts from the >>>>>>>>> reader >>>>>>>>> to the document. >>>>>>>>> >>>>>>>>> 3) MINOR: >>>>>>>>> >>>>>>>>> Errata Tracking: Apparently each subsection of section 3 covers one >>>>>>>>> erratum. But the errata numbers are not mentioned. Each section >>>>>>>>> ought >>>>>>>>> to >>>>>>>>> reference the errata number it responds to. >>>>>>>>> >>>>>>>>> 4) NIT: >>>>>>>>> >>>>>>>>> In section 3.35 (DSCP Changes) the change to section 10.1 isn't >>>>>>>>> properly >>>>>>>>> indicated. It shows 'Old text' twice rather than 'Old text' and >>>>>>>>> 'New >>>>>>>>> text'. >>>>>>>>> >>>>>>>>> _______________________________________________ >>>>>>>>> Gen-art mailing list >>>>>>>>> Gen-art@ietf.org >>>>>>>>> https://www.ietf.org/mailman/listinfo/gen-art >>>>>>>> _______________________________________________ >>>>>>>> Gen-art mailing list >>>>>>>> Gen-art@ietf.org >>>>>>>> https://www.ietf.org/mailman/listinfo/gen-art >>>>>> >>>>> _______________________________________________ >>>>> Gen-art mailing list >>>>> Gen-art@ietf.org >>>>> https://www.ietf.org/mailman/listinfo/gen-art
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Michael Tuexen
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Michael Tuexen
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Christer Holmberg
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Christer Holmberg
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Spencer Dawkins at IETF
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Gorry Fairhurst
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Michael Tuexen
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Michael Tuexen
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Christer Holmberg
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Alissa Cooper
- [Gen-art] Gen-ART Last Call review of draft-ietf-… Paul Kyzivat
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Christer Holmberg
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Christer Holmberg
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Gorry Fairhurst
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Christer Holmberg
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Christer Holmberg
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Gorry Fairhurst
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Christer Holmberg
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Spencer Dawkins at IETF
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Paul Kyzivat