Re: [Gen-art] Genart last call review of draft-ietf-nvo3-evpn-applicability-04

"Rabadan, Jorge (Nokia - US/Sunnyvale)" <jorge.rabadan@nokia.com> Thu, 01 September 2022 14:09 UTC

Return-Path: <jorge.rabadan@nokia.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 00534C152577; Thu, 1 Sep 2022 07:09:54 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.476
X-Spam-Level:
X-Spam-Status: No, score=-7.476 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.571, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=nokia.onmicrosoft.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sYHYpTyavdgL; Thu, 1 Sep 2022 07:09:51 -0700 (PDT)
Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2138.outbound.protection.outlook.com [40.107.243.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 13247C14CF00; Thu, 1 Sep 2022 07:09:47 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RjiYfOkdfqCH4ho/cY1g02F82xhbzURntHCG+AWDsuJdr8sW7BJvzwnqJLcuLGyAvDhM3xnJ5cLUulXJbysQNrx2oJiOQdAEFqudUAI0JDcYp6u0de7EREsWm4F7kZEJ4QaX7IjsWXrorjqzuFdU5iNNEhmUtI/DfAtvKvQ00th/GGl0ZUIp7eDP4nc7rsIziTHuvI4j22WX2TU79ckl9WpOD4jAYSrNOXilOA/bkcLALPNwaWp7vmrQ8X/RuSjuazoDaXh0Zk1aCmdrcpQwTB5RLDZ9WCjcul9GCuuti0JlqMqmuyt7jy+AA3eTiDhvxN8jJ7i9tAkHnFizQ6DH3A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gumgWMCIsjRvbY975e/A2kWUTDH0tqMK97rbpYXxJF8=; b=G+ffzgYiyaHUVzMNgFTMSzvgycoO8JNMv8Ja4JJooNauxHV+/TrsXvCNqpGukLTVVxJdTgdc2WcwF28gAcTtoKs+h0RoIeMr6ISnP2f/l/qI4GJsNq496nfwQOZ36TPOBdPN/pGc1c9ddEkFZoWj9KXdatRZFbT+4GAaAErPeLDRvHsmJHfxhTzwv37Ia8i3ArCr86bykt+Q76gfLyUohwJk5/4I8XKWQ9N08Nc0GNkbiYAGoA6HuKvx8sJ071pZKpJvZRkkp33c6/cOfRrS76PfOdLld3KhequSJEqBCUlrfBmhalLEVWjRpu2z99Zm9uNutLIIVouk6ZImEOPArA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nokia.com; dmarc=pass action=none header.from=nokia.com; dkim=pass header.d=nokia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nokia.onmicrosoft.com; s=selector1-nokia-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gumgWMCIsjRvbY975e/A2kWUTDH0tqMK97rbpYXxJF8=; b=Ea8uX0l0jYaeidtd+FuH1LIOXVetBSKCqX5vfp1muIbMmp9bQ/8TEAkzDY6ZmVcNImzT4Q8azAEFW/Aqaf9iVRmIRz2liKCBpUG2xq4yfDWUQOrYxDCgHFouPggisr0+BKXZo/xj9AixB1eYO67Qw7N1+VSpvOOkBGslY0faxXU=
Received: from BY3PR08MB7060.namprd08.prod.outlook.com (2603:10b6:a03:36d::19) by DM6PR08MB6267.namprd08.prod.outlook.com (2603:10b6:5:1ec::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Thu, 1 Sep 2022 14:09:45 +0000
Received: from BY3PR08MB7060.namprd08.prod.outlook.com ([fe80::3c57:d4d4:3c2f:354f]) by BY3PR08MB7060.namprd08.prod.outlook.com ([fe80::3c57:d4d4:3c2f:354f%4]) with mapi id 15.20.5588.010; Thu, 1 Sep 2022 14:09:45 +0000
From: "Rabadan, Jorge (Nokia - US/Sunnyvale)" <jorge.rabadan@nokia.com>
To: Reese Enghardt <ietf@tenghardt.net>, "gen-art@ietf.org" <gen-art@ietf.org>
CC: "draft-ietf-nvo3-evpn-applicability.all@ietf.org" <draft-ietf-nvo3-evpn-applicability.all@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>, "nvo3@ietf.org" <nvo3@ietf.org>
Thread-Topic: Genart last call review of draft-ietf-nvo3-evpn-applicability-04
Thread-Index: AQHYkVxM4MHta56FM0GPX9+bUktHNK2F1RKe
Date: Thu, 01 Sep 2022 14:09:45 +0000
Message-ID: <BY3PR08MB7060B36B7B6771357CE862ECF78F9@BY3PR08MB7060.namprd08.prod.outlook.com>
References: <165712785477.26568.6015388138744672009@ietfa.amsl.com>
In-Reply-To: <165712785477.26568.6015388138744672009@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nokia.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 2d39d871-a047-466f-d12c-08da8c239f60
x-ms-traffictypediagnostic: DM6PR08MB6267:EE_
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 5ZAV/5bp60/lE8Ykd/2/+J4qHbbVOggJZjyz1qavMd/Eo+MljjvOV8MD9wBfU0L4k66uijbqxfacTTlmfqnwsU7yqFpIvIpjDz/x5FvideoM2wgsr9rCQhA1hLqWkVWXlxppISkdat0ukOlHk0KYo6Brf9IQjjZnuNr0/0QDhK9bTjsXUetUdscSOvJP3NGUf8icz4qLgUDabOP0hioRagS4QsiSNFuwMzYBBrdLLrmxqjcHyfUFqhM6EDUNjj74nwOAl6KUroOJjc8rkOQ47ba/MMdkqVHjJMlRT5WF+1NM8UAyUfsYE9hqfcJL69H36l948s79SnyJxeM6njm/lIMeiZ93YW6OWjXrMPqXXjrjH/pyUFC9r7gTVXJ5Q4/tcB4X9lgBp03HBPGs1kBnbbl2EfjF3WInJ3gh356KEHfP5L77NF6y6mWrqo9JLn82MbsxsjyKHhjv8co9hbW6NdpYGkQymR4YQeDf+A/HnPaGHyJLDdeZ2pjqzTo7rL3NpC1rX//YPiTetL7nDIMQ5vlrMv9V5pWroyNBHjVzEOIqRtLZdp5FMgr7pASqYyQOIFje+kk/HEcUPPULHJtP6WWV5dL7r7J+9t33q6wnneCdsAH6weyr7NkNBjqoG8q/bNf40dgHkTlG6IU1ZmBJKjxXCc8/+8q2umv1i3nCl+C/s+5el/pVv65Tvt049c9D+Ss2qB9Xx6z0xEAmZcu3+9pvNRMQutE3ZWqnT2mmqruAIqOFMtrNIYKjnKhg1OPFB2pF8PPRQlQwChp89kqZs1Hh/T4tBHwRncYHeLyEeB4=
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY3PR08MB7060.namprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(136003)(376002)(39860400002)(346002)(366004)(396003)(83380400001)(186003)(91956017)(110136005)(71200400001)(9326002)(9686003)(54906003)(7696005)(8936002)(33656002)(26005)(6506007)(53546011)(2906002)(82960400001)(38070700005)(38100700002)(316002)(122000001)(55016003)(66556008)(66946007)(478600001)(66446008)(64756008)(8676002)(4326008)(5660300002)(166002)(41300700001)(52536014)(76116006)(66476007)(86362001); DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 09YjwzAg6nUcL6tfkx59Ef4JkB81pApOEgVEO90WS5ZBg6Vyf8G0vAhFjKp8e5UJKWLi0Cfk3iljmuYd1p5CtNicdYal/arWBd5YjAC03ygBvJX8Ww1pta3jJo4hYghcGqQO6WRO8op4BNeGM1NK3uKju1RGerGp+v2zkZVowkncavQuYSEZyjHcPNpjYOO2QbDIQT4An+KtuyCVCkoHouESNgvhkTsLihYU/8HzpyCG+y0IrL8407kvgoIZwxR0qmDZV5SyJpWgLmSKbIQpr8oBVbPCakpFHnJgk0Y/zBseVHIQRco0qpjSr97EZ17F75FuIBW/h+BeSDmg3gAmS+E9WE8iSi36YtXZ28DxkSNXyjnKXifo6q8xlnaP7PKlq/9hnw2JZU3YIOUHV8INhWgZiUALoYRyz/R6FlR+wMiAcJvwDhvBATHjHemm3LLA7nqbNFQGLh24pm/2CnspIu8wb5vUegwS1FF3LR1Sfm9Z89o9ey+UCBPXq74OQwUwyAq+XgcbH8D63g4VALZQGslCw2jafy4mgw4/C7br6Ho9dkBLvx3NrnYxOae+NXiTcdaJp+LVOT10kqaThBso9m6PjOpLPb1X7TCcsJZO6QWN7lRnUDZsooWL+SCumnG+3wEBUuYH70/Kh+zKkIaaD3b4OU2Csej6hrG+4cEpuoxjng3gTniyeJARtv0n6SQ7tG+krN9EDcR6t29W3FszGdHKoOCTgvqwQ/2Tk0dcyUl2Gto8XdySTuCkJp562F1WgfNuzbGB3Dw67KczCxb83u1aVg9dKuKj7t27d47Ut39PN5TcreeDzzt19J+i+MTy4I/LRgOZQwbHMeB2TFxXOWX4eTKbxMcmRjO74QML4D+9HnvBEpTQOy71+XLnc8aDBNv7U3rhEb5O3t1ulmvovSc0wKjgeElMpPAjyvYHWNd2YXeWMG8SGoj8EED1mrdpsCLb98RK949uWEXCm2Sz57WDWvjQnQZ2mn6VW/ohXC8ERpdtIh0bW6wTLatP39lkV7IMh8uUJqqzYtkkgpKpQiiRrM1b9eNB2QwEax6geustrbYaP0JZvkQoeCXT6Hd5pdDhf1Zq0fq2afX6IScS4XoZreNOWBtORpkFxECptYejqUfNfVgRMxIrcX74j2UZfGRJFmzl/cwYsZ6Gh3V2teR2VvbN9PvPF1M+5YTs1zp+DgZXceaSw0BDTV3f6nkVbBqTVcvf1DSu5vjMzOyh/MoRsfeNJBLHCyd4zQt5aoi4rYRn10WiXcSLWAN8cwk4jp/Ut38x+nZg14tG7TuHobfnM1dkBkWRHtCaW5sJogL9kZMBL8cw9qun3mWMizxYCePmL5YlP7vvK48n4mGV93bHKrJZS2mllUFtOqgvY1M3Mo2leQQ+P2AiA45+6jYFNBtQoVR4CB8zwDd375fnjy8mMlJrGVqhYeOyMDnPoD4o+GFUNzLaOPe1P+KM+5lymSiO82zUZHtyrUaFupKQOk26uukISf8p9OjSq/wYKXzPZPyEpcA0kIJjPvh3HAc3iaE16YbOPbOUVIR94RKXkDmvVHzunJIfxwrWn43//LoetCbfZe6xEm1Ey4HfLH52+jsnBvzLYxhTHKMK0D0WV6FUPKUvUbZTIHdZg1TVzQg=
Content-Type: multipart/alternative; boundary="_000_BY3PR08MB7060B36B7B6771357CE862ECF78F9BY3PR08MB7060namp_"
MIME-Version: 1.0
X-OriginatorOrg: nokia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY3PR08MB7060.namprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2d39d871-a047-466f-d12c-08da8c239f60
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Sep 2022 14:09:45.1856 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5d471751-9675-428d-917b-70f44f9630b0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: tLNQa+uoGI4nzPqdNex4nDJk+2MS5NwUSv1mfDkYwcWpGKBat2PHuqTP/hAfMApGKsB4If/BenqI0gucV+t10A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR08MB6267
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/94bNEjAOLi5rSlepztwfVdb6ANg>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-nvo3-evpn-applicability-04
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Sep 2022 14:09:54 -0000

Hi Reese,

Thanks very much for reviewing. We took all your comments in the new published version (05).
Please see details in-line with [jorge].

Thanks again.
Jorge

From: Reese Enghardt via Datatracker <noreply@ietf.org>
Date: Wednesday, July 6, 2022 at 7:17 PM
To: gen-art@ietf.org <gen-art@ietf.org>
Cc: draft-ietf-nvo3-evpn-applicability.all@ietf.org <draft-ietf-nvo3-evpn-applicability.all@ietf.org>, last-call@ietf.org <last-call@ietf.org>, nvo3@ietf.org <nvo3@ietf.org>
Subject: Genart last call review of draft-ietf-nvo3-evpn-applicability-04
Reviewer: Reese Enghardt
Review result: Ready with Nits

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-nvo3-evpn-applicability-04
Reviewer: Reese Enghardt
Review Date: 2022-07-06
IETF LC End Date: 2022-07-11
IESG Telechat date: Not scheduled for a telechat

Summary: The document is well-written, though dense, and it does a good job of
breaking down a complex topic. I only found a few nits to make the document
more accessible.

Major issues: None.

Minor issues:

Abstract:
Please expand NVO3 networks on first use.
[jorge] done.

Please consider adding a sentence to already state in the abstract/introduction
that this document does not introduce any new procedures or signaling in EVPN.
[jorge] done.


If EVPN gets updated in future RFCs, does this document apply to these updates?
Not sure if it's worth saying anything about this, but I started wondering
about this question when seeing the table of EVPN route types in Section 4.1.
[jorge] it’s a good point, however I don’t think there is a need to indicate anything about it. This document describes the applicability of the existing specs to NVO3 networks. Future EVPN extensions may or may not apply to NVO3 networks, and that will have to be detailed in the other new specifications.


Section 2:
Please expand CLOS on first use.
[jorge] I don’t think CLOS is an abbreviation, but the name used for non-blocking switching architectures like the ones in DCs, with the name coming from Charles Clos… that’s my understanding.

Please add a definition for Tenant System, in addition to expanding the acronym.
[jorge] done

For the BT definition, not having read RFC7432, I got slightly confused
initially, as "Bridge Table" sounded to me like it's a sort-of lookup table on
a single NVE, but if it's the instantiation of a BD, it would potentially span
multiple NVEs. Having read the doc, it seems like a BT spans multiple NVEs and
potentially is the same on all NVEs in the same BD. If this is true, please
consider adding a clarifying sentence to the BT definition.
[jorge] I can see the confusion, since sometimes we use BD when we should use BT. BD really spans multiple NVEs, and BT is the instantiation in an NVE. I added this sentence to clarify things, let me know if it is ok:
“Although a BD spans multiple NVEs, and a BT is really the instantiation of a BD in an NVE, this document uses BT and BD interchangeably.”


Section 4.2:
Figure 1 uses the terms "single-active" and "all-active", but the document only
defines/explains them in Section 4.7.5 - Is this intentional? Even though
Figure 1 uses "single-active" and "all-active", I am not seeing these terms
used in any example later on when the terms are explained. Please consider
either elaborating on how the terms relate to the Figure 1 example or removing
these terms from Figure 1.
[jorge] I added this sentence, hope it helps:
   o  The terms Single-Active and All-Active in Figure 1 refer to the
      mode in which the TS2 and TS3 are multi-homed to the NVEs in BD1.
      In All-Active mode, all the multi-homing links are active and can
      send or receive traffic.  In Single-Active mode, only one link (of
      the set of links connected to the NVEs) is active.


Section 4.2.2:
Please consider expanding PMSI on first use.
[jorge] I added it to the terminology section.


Nits/editorial comments:

Section 4:
"The intend is" -> "The intent is"
[jorge] fixed, thanks.