Re: [Gen-art] Gen-ART Last Call review of draft-ietf-mpls-oam-ipv6-rao-02

Brian E Carpenter <brian.e.carpenter@gmail.com> Mon, 26 January 2015 22:05 UTC

Return-Path: <brian.e.carpenter@gmail.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BF46F1B2AA9 for <gen-art@ietfa.amsl.com>; Mon, 26 Jan 2015 14:05:41 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2
X-Spam-Level:
X-Spam-Status: No, score=-2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id V0e0DuRK3v_u for <gen-art@ietfa.amsl.com>; Mon, 26 Jan 2015 14:05:39 -0800 (PST)
Received: from mail-pd0-x22a.google.com (mail-pd0-x22a.google.com [IPv6:2607:f8b0:400e:c02::22a]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5D46C1A0025 for <gen-art@ietf.org>; Mon, 26 Jan 2015 14:05:38 -0800 (PST)
Received: by mail-pd0-f170.google.com with SMTP id p10so14482137pdj.1 for <gen-art@ietf.org>; Mon, 26 Jan 2015 14:05:37 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:organization:user-agent:mime-version:to:cc :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=6iFFqDj/sk1lc+5i+AaO5pFeukCZwYEdbi9AtCZXbos=; b=pwYuXCvId/tIpCERuzUFgx1Pq1faboShzkvwwxSPX7iS1l4HgNb6u6TqyXD7dN8fQf S6p5rfaWK2lOfMp9t00vwBJJ+VL2Qo6A80VsKw6/YPDCcN1nTLLUjJ/IyjluguFMGwGF D9lLzo0Vhzm3HQZFH0P79QumTg5IvURAvR7ntDTZYzfdSxN87XWnMAEUFPf+rxZhbBVv YFosvrCWjF5mYLgULH/Oh6XLssBq1xw9L3sx+/7p3rwruuO1GfzSdMkDBAOVfzWJ5xea D0SjNtUf56p10v1ZazYPhLbNBSkd8DHSa107NhlMKHdR67sl9pPZV5QCEwmzjNZq5s1l vaFQ==
X-Received: by 10.67.8.2 with SMTP id dg2mr12304662pad.15.1422309937693; Mon, 26 Jan 2015 14:05:37 -0800 (PST)
Received: from ?IPv6:2001:df0:0:2006:c0da:ac17:5f6d:8e76? ([2001:df0:0:2006:c0da:ac17:5f6d:8e76]) by mx.google.com with ESMTPSA id gr7sm10596254pbc.75.2015.01.26.14.05.34 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Jan 2015 14:05:36 -0800 (PST)
Message-ID: <54C6BA2B.3050600@gmail.com>
Date: Tue, 27 Jan 2015 11:05:31 +1300
From: Brian E Carpenter <brian.e.carpenter@gmail.com>
Organization: University of Auckland
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: "Carlos Pignataro (cpignata)" <cpignata@cisco.com>
References: <54C54401.5060708@gmail.com> <76237E2D-D01D-43E7-A933-F16F53CA55AA@cisco.com> <54C5645B.4020508@gmail.com> <3657689F-67C2-4D6E-BA98-239356FBF86E@cisco.com>
In-Reply-To: <3657689F-67C2-4D6E-BA98-239356FBF86E@cisco.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <http://mailarchive.ietf.org/arch/msg/gen-art/9oxbyOMTdAUpIR3TAYds_onitUk>
Cc: General Area Review Team <gen-art@ietf.org>, "draft-ietf-mpls-oam-ipv6-rao.all@tools.ietf.org" <draft-ietf-mpls-oam-ipv6-rao.all@tools.ietf.org>
Subject: Re: [Gen-art] Gen-ART Last Call review of draft-ietf-mpls-oam-ipv6-rao-02
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 26 Jan 2015 22:05:41 -0000

Looks good to me, thanks.

   Brian

On 27/01/2015 09:36, Carlos Pignataro (cpignata) wrote:
> Hi, Brian,
> 
> On Jan 25, 2015, at 4:47 PM, Brian E Carpenter <brian.e.carpenter@gmail.com<mailto:brian.e.carpenter@gmail.com>> wrote:
> 
> Hi Carlos,
> 
> On 26/01/2015 08:49, Carlos Pignataro (cpignata) wrote:
> Hi, Brian,
> 
> Thanks for your review! Please see inline.
> 
> On Jan 25, 2015, at 2:29 PM, Brian E Carpenter <brian.e.carpenter@gmail.com<mailto:brian.e.carpenter@gmail.com>> wrote:
> 
> I am the assigned Gen-ART reviewer for this draft. For background on
> Gen-ART, please see the FAQ at
> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.
> 
> Please resolve these comments along with any other Last Call comments
> you may receive.
> 
> Document: draft-ietf-mpls-oam-ipv6-rao-02.txt
> Reviewer: Brian Carpenter
> Review Date: 2015-01-26
> IETF LC End Date: 2015-02-04
> IESG Telechat date:
> 
> Summary: Almost ready
> --------
> 
> Minor issues:
> -------------
> 
> 1. Hop-by-hop options, and therefore Router Alert, are well known to
> cause a serious performance issue or are simply ignored by many
> routers (as warned in http://tools.ietf.org/html/rfc7045#section-2.2).
> A pointer to that warning would be appropriate.
> 
> 
> I do not believe this concern is very applicable to the MPLS OAM RAO. The whole point of RAO in an MPLS LSP is to be intercept the packet and punt it to a slow path, and it is not injected back. The MPLS OAM Router Alert option is invisible to the MPLS Label-switched hops, and when the LSP finishes, it is only processed once.
> 
> I am also not sure I understand the suggested action behind this comment. Are you suggesting we add a pointer to that Section, or that exact paragraph to the Security Considerations?
> 
> Well, maybe what you could do is add a statement that this type of RAO
> is not subject to the problem of being ignored, because the appropriate
> router will process it (on the slow path) by design. The generic problem
> is that HbH options might be ignored even if the designer assumes otherwise,
> which is why we added the warning in RFC 7045, and you're saying that
> problem doesn't apply here.
> 
> Sounds good — I added the following paragraph (and Informational reference). All, can you please review?
> 
>    IPv6 packets containing the MPLS OAM Router Alert Option are
>    encapsulated with an MPLS Header and not expected to be inspected by
>    every label switched hop within an MPLS LSP.  Consequently, this
>    value of the Router Alert Option will be processed by the appropriate
>    router and is not subject to the problem of being ignored as
>    described in Section 2.2 of [RFC7045].
> 
> 
> 
> 2. I'm a bit surprised to realise that new definitions of Router Alert
> options are not routinely notified to the 6MAN WG.
> 
> We had run this through 6MAN, both on list and presenting twice in IETF meetings.
> 
> I must have been asleep, sorry!
> 
> 
> No worries, thanks for the review!
> 
> — Carlos.
> 
>   Brian
> 
> Thanks!
> 
> Carlos.
>