Re: [Gen-art] Genart last call review of draft-ietf-core-hop-limit-05

Jaime Jiménez <jaime@iki.fi> Sun, 22 September 2019 13:28 UTC

Return-Path: <jaime@iki.fi>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5419F1200B4; Sun, 22 Sep 2019 06:28:42 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.82
X-Spam-Level:
X-Spam-Status: No, score=-1.82 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_NEUTRAL=0.779, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=messagingengine.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 46Jq0mEXh2jT; Sun, 22 Sep 2019 06:28:40 -0700 (PDT)
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 445D3120018; Sun, 22 Sep 2019 06:28:36 -0700 (PDT)
Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id EDD7320EF7; Sun, 22 Sep 2019 09:28:34 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Sun, 22 Sep 2019 09:28:34 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=BooIsQ GlJc6eNbQx9aNSI25O3TN2Zq8wlOuhUSFHll8=; b=SoACC4M6T8t3EpyshJdjdt d249fm0BmP1vAoEPe2fwzKtM4QzRLCBcs6pJTvzBMqpJC0zSCIwS5biENmlfMAGO Ujb+ZnOt4MDAChWbB6dmAR8DzN6/R5mTnWaBiUYnnDnCWjmBr9w1f0sGhQ8AXra/ elt70spqRAU3DT/P6TTB4rfCbUl+R2Mo5oMnN0F9nrfr/tRG0tgjMReVIZG4Us9P oofp07vfGAkNGh8N+VD2I69RMP5B2VMp0+KAerTw7Rbgu9BGwRblwUsx6/g6W9lN 6DOWKrc34b4ELNYvN2IpAQkuE8gsFgvVlUUFQvNXC+AfftTM3eO8nAnpdj1zUt8A ==
X-ME-Sender: <xms:AneHXUvxN-EU7c525dGg1e5-ZkyUnzB_WTPjjFVQDGgSCGBDEoWlXA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrvdeigdeigecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepfffhvffukfhfgggtuggjfgesthdtre dttdervdenucfhrhhomheplfgrihhmvgculfhimhornhgviicuoehjrghimhgvsehikhhi rdhfiheqnecuffhomhgrihhnpehivghtfhdrohhrghenucfkphepudelkedrvdegrdeird dvvddtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehjrghimhgvsehikhhirdhfihenucev lhhushhtvghrufhiiigvpedt
X-ME-Proxy: <xmx:AneHXVZm6XA42bSw4x3FRWFhxOiBEJIy_DAxIGd-13n4lZzu9w66Dg> <xmx:AneHXYQWV_lPAByC1mLcPvmlvI2Ga7XCYSUVDOTlmpvrUpC0Ssg8qA> <xmx:AneHXQw_2xNbCF1lXRcXRJmaztdXl-LP-LxCGfE577GMRG6LimH_wA> <xmx:AneHXUkX4gmDVuJiLLnlz1XQrDyA8eaUCCEtVUdnqaGeZTQTGJTx7A>
Received: from EMB-918HFH01 (unknown [198.24.6.220]) by mail.messagingengine.com (Postfix) with ESMTPA id D630080060; Sun, 22 Sep 2019 09:28:32 -0400 (EDT)
Date: Sun, 22 Sep 2019 16:28:30 +0300
From: Jaime Jiménez <jaime@iki.fi>
To: Roni Even <ron.even.tlv@gmail.com>
Cc: gen-art@ietf.org, draft-ietf-core-hop-limit.all@ietf.org, ietf@ietf.org, core@ietf.org
Message-ID: <20190922132830.kemraqhnzcjxprt2@EMB-918HFH01>
References: <156915425127.1340.18230115848839912205@ietfa.amsl.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <156915425127.1340.18230115848839912205@ietfa.amsl.com>
User-Agent: NeoMutt/20180716
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/9rHoR8abDCmlYApZ6cEI3zE68H4>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-core-hop-limit-05
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 22 Sep 2019 13:28:42 -0000

Dear Roni,

I believe the CUNR bit mask is defined in 5.4.6 https://tools.ietf.org/html/rfc7252#page-39
I assume it has to be added for every new option defined. 

Ciao!

On Sun, Sep 22, 2019 at 05:10:51AM -0700, Roni Even via Datatracker wrote:
> Reviewer: Roni Even
> Review result: Ready with Nits
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-ietf-core-hop-limit-??
> Reviewer: Roni Even
> Review Date: 2019-09-22
> IETF LC End Date: 2019-09-27
> IESG Telechat date: Not scheduled for a telechat
> 
> Summary:
> The document is ready for publication as a standard track RFC with nits
> 
> Major issues:
> 
> Minor issues:
> 
> Nits/editorial comments:
> 
> In section 6.2 I am not sure why you have CUNR , I did not see these values in
> RFC7252 section 12.2 https://tools.ietf.org/html/rfc7252#section-12.2  or in
> the registry
> 
>          +--------+---+---+---+---+------------------+-----------+
>          | Number | C | U | N | R | Name             | Reference |
>          +--------+---+---+---+---+------------------+-----------+
>          |  TBA2  |   |   |   |   | Hop-Limit        | [RFCXXXX] |
>          +--------+---+---+---+---+------------------+-----------+
>              C=Critical, U=Unsafe, N=NoCacheKey, R=Repeatable
> 
>