Re: [Gen-art] Genart last call review of draft-ietf-sfc-multi-layer-oam-23

Greg Mirsky <gregimirsky@gmail.com> Mon, 15 May 2023 22:34 UTC

Return-Path: <gregimirsky@gmail.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8D18DC1CAB3B; Mon, 15 May 2023 15:34:41 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.085
X-Spam-Level:
X-Spam-Status: No, score=-1.085 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_HTML_ATTACH=0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KKgSG1ZKt8MV; Mon, 15 May 2023 15:34:38 -0700 (PDT)
Received: from mail-yb1-xb36.google.com (mail-yb1-xb36.google.com [IPv6:2607:f8b0:4864:20::b36]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id F30F2C1BED33; Mon, 15 May 2023 15:34:32 -0700 (PDT)
Received: by mail-yb1-xb36.google.com with SMTP id 3f1490d57ef6-ba7730e47a4so4082361276.3; Mon, 15 May 2023 15:34:32 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684190072; x=1686782072; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=QUYxozxQfBxYXbKqIPbVazXszO2LnemY1qgHPMXczNg=; b=EoxnS98msDS2P6ZpSftxUkIK82kG20iqCeC+Th0iH5Xt9J6pJpBt0qqHsZPw0pU8qn hRcVJQ+4cRE1G4nrVETVusqFZcie7KWStQG4sjCoWQkWdCeknmXIPgXwB7YF/Uh01CIs 12CmMiQIbRCMTZnWFnPivu8DhJ9PDC4inHKqIhEP7VugjkUItsIJ/Qpbvcy0Eb1cjAJu +bFoM+fn+OR2KmnXshGjOxj+/tkL1LJ22sqUky81lbbiwKm1t0cIPADXPzaPn4DIIwaP v3hgCXDC4JHzCyyoX2IHjVSMy0gXCg8SX7Bw/SJL+ld0UltYq6L4PWoA4rBP0i74WCdo HSyg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684190072; x=1686782072; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QUYxozxQfBxYXbKqIPbVazXszO2LnemY1qgHPMXczNg=; b=jSdxYdestlAmJ4OKdF/uebWGWjuBur4LZAPDVVpo2fdFyr7UTZqfFIwLrQnfzeR3AW efeVzrbvmqt+mgqQGekPQiW5YkDpCKaoDjNrFC+eF5hDox867MhkHS8kJK3t0r+oszQb Td/9TBKp58e8XosQeB/ahNPBUKWfq8FpgBAil2EmSIZtUpNPKrbnTzCaRdJJiPPeMfFN 5tDQWor76HMg2HvSHM1rnWapxLYNBe5W4O4W49r2yn3zWK/fhxPgvQxaZwPBEh1IuXCl 3J93LpkGg+y3R7rs5aCjiRQwwSQLpZrHpHtqzIsinZ3ldLcESuGAfH9SNrmzgfMfLMG/ tBhA==
X-Gm-Message-State: AC+VfDzon2cIVvWF8PzHi5BoXkhxgOh4R0PEebh6LJOnFQ9MRbIUIZX4 qwSZHVPfrn3Cq3ybIYjjceiEdl/JPagfLX87LnRLSMwR
X-Google-Smtp-Source: ACHHUZ5MSQ2CpRaZLIpWqJgvChija7DsK2RD3t9zwUmDldh7dIw/B2Z4Sqf4jADml0ai8gTG37b3VYkNxz+jMqQhQi4=
X-Received: by 2002:a25:adc5:0:b0:ba8:f98:c20e with SMTP id d5-20020a25adc5000000b00ba80f98c20emr780633ybe.26.1684190071593; Mon, 15 May 2023 15:34:31 -0700 (PDT)
MIME-Version: 1.0
References: <168416527869.53196.15333590507548997462@ietfa.amsl.com>
In-Reply-To: <168416527869.53196.15333590507548997462@ietfa.amsl.com>
From: Greg Mirsky <gregimirsky@gmail.com>
Date: Mon, 15 May 2023 15:34:20 -0700
Message-ID: <CA+RyBmVQx38GBV18qC2WRkPxqY90vupmoQuJj_gHALbowpdKZg@mail.gmail.com>
To: Behcet Sarikaya <sarikaya@ieee.org>
Cc: gen-art@ietf.org, draft-ietf-sfc-multi-layer-oam.all@ietf.org, last-call@ietf.org, sfc@ietf.org
Content-Type: multipart/mixed; boundary="000000000000f3f5a605fbc30e78"
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/B8sFsK3c74r_i4AGTzDn2WW6-4w>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-sfc-multi-layer-oam-23
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 15 May 2023 22:34:41 -0000

Hi Behcet,
thank you for your review and thoughtful suggestions. I've updated the
draft accordingly. Please find diff and the new working version attached.
Also, several notes below are inlined under the GIM>> tag.

Regards,
Greg

On Mon, May 15, 2023 at 8:41 AM Behcet Sarikaya via Datatracker <
noreply@ietf.org> wrote:

> Reviewer: Behcet Sarikaya
> Review result: Ready with Nits
>
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
>
> For more information, please see the FAQ at
>
> <https://wiki.ietf.org/en/group/gen/GenArtFAQ>.
>
> Document: draft-ietf-sfc-multi-layer-oam-??
> Reviewer: Behcet Sarikaya
> Review Date: 2023-05-15
> IETF LC End Date: 2023-05-17
> IESG Telechat date: Not scheduled for a telechat
>
> Summary:
> This document defines  Service Function Chaining (SFC) Operation,
> Maintenance
> and Management (OAM) protocol. It defines in Section 6 ICMP like Echo
> Request/Reply for SFC to do Operation, Maintenance and Management mainly
> for
> Fault Management as SFC messages which constitutes the bulk of SFC OAM
> protocol. As shepherd write-up explains it grew out of 3 documents all
> lead by
> Greg Mirsky when he was with ZTE. Major issues:
>
> Minor issues:
> Author list has 6 people as also indicated in shepherd write-up. The
> document
> already contains two names in the contributor list. Strongly recommend
> having
> one more in the contributor list.
>
GIM>> This document is the result of merging three documents (one SFC WG
and two individual drafts). Six authors listed on the front page
contributed to at least two documents. We've tried to manage the situation
fairly and with reason. I hope that is understandable and can be accepted.

>
> Nits/editorial comments: please add the and as shown below:
> This mechanism enables on-demand Continuity Check and
>    Connectivity Verification among other operations over SFC in networks
>   and addresses functionalities discussed in Sections 4.1, 4.2, and 4.3 of
>    [RFC8924].
>
GIM>> I updated the text. Please let me know if it reflects your view
correctly.

>
> The draft name contains multi-layer which is not mentioned elsewhere in the
> draft.
>
GIM>> The draft went through several revisions, and that is reflected in
some disconnect between its identifier and scope. I hope that is
acceptable.

>
> draft-ietf-sfc-nsh-tlv -> RFC 9263
>
GIM>> Done, thank you.

>
> draft-ietf-sfc-oam-packet normative reference is in RFC Editor Queue
>
GIM>> Thank you for pointing that out. Will update it accordingly after the
publication.

>
> Behcet
>
>
>