Re: [Gen-art] [spring] Genart last call review of draft-ietf-spring-sr-replication-segment-14

Rishabh Parekh <rishabhp@gmail.com> Fri, 09 June 2023 17:02 UTC

Return-Path: <rishabhp@gmail.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 47EB7C15257D; Fri, 9 Jun 2023 10:02:24 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.094
X-Spam-Level:
X-Spam-Status: No, score=-2.094 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id feoL9hfSTsoi; Fri, 9 Jun 2023 10:02:19 -0700 (PDT)
Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D5CC5C152577; Fri, 9 Jun 2023 10:02:16 -0700 (PDT)
Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-973bf581759so341449366b.0; Fri, 09 Jun 2023 10:02:16 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686330135; x=1688922135; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Ohpjh6OXZzOy+h+M+2q6416cbFTc28BMEDdhRCQK20Q=; b=hhZREAYJZ99KwrbFeEL42qkB0bD3uqnopAgVsVn/B/MPps1iw+CkHsqHGl7aF8BQiB +JOonF9cfRX34H4C6izwDZx2WBjJza1UMtw4lAsfoucqn5KxX/URvyM9eFb3uXq3e4nc w67HkaYDrW+K44luqq/eVVgLd7glpR5G4hN+NtMW2YDfV/iNZrRBl1e943T3xlYUTsWp Hli7sdSSgQeTeaqT06LTt/5bsSCC+1MHC+orD7xoG49qzsPKNJ+pzHu31627ppKTX0GZ pRr8OxwnYr3LR4LO6D0qYaozeaU0UOuiKtEnZQjZBOdkmUDXrzX6k1j2tkPc1HLa3fRs 0ADA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686330135; x=1688922135; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Ohpjh6OXZzOy+h+M+2q6416cbFTc28BMEDdhRCQK20Q=; b=f+GAxEuL/wwSfyUvfBR4zlHrKsnojQi7WWvbZzKCO81jZBVly91c5xMLtIlOc7tvgV UfFnXm+YfGT+cxFoVrKyU08tzFna3vpOaBmO3uHVrDGd99QWyK8EeHfrILd1OeOzWg/6 GmTcxaRvGDqujOsYZiEWdGl/qTepFMe5OSBEJj+geQ+q3IIVAi4BZs4KXtT24r6Ec7jz 02SLhCMTlYkt6EwfhQeBtaexzUTVGJ2gUa25kuBiZfbznXlUeW7qMWMYM35m/UTRVTTS 7gA4CqLv+ZpAwDd5UjTPm3dAbwYe+aoJ86T5EiK+pjtgTrsW1znG5nBaoe4sLeArvBij LEsg==
X-Gm-Message-State: AC+VfDwH/sRJVrj4tRAB49nNjR0ZxoeMEfCoYBwsIhqBnyISO8UUd1t4 flR1/J9exNPB7nQIBgdTVnp0D9qxhKmB0TmDJsWvix33
X-Google-Smtp-Source: ACHHUZ5hduhrgGkLl5hmI2cQBMr/CAx4WvVv5VJ8QnzYEYgWEK8gw+QcmxKpStmU6AdicCBqWsjOkgmzf65sKbIhKuA=
X-Received: by 2002:a17:907:d1b:b0:953:8249:1834 with SMTP id gn27-20020a1709070d1b00b0095382491834mr2872184ejc.16.1686330134787; Fri, 09 Jun 2023 10:02:14 -0700 (PDT)
MIME-Version: 1.0
References: <168632650880.62569.14866459241619472156@ietfa.amsl.com>
In-Reply-To: <168632650880.62569.14866459241619472156@ietfa.amsl.com>
From: Rishabh Parekh <rishabhp@gmail.com>
Date: Fri, 09 Jun 2023 10:02:02 -0700
Message-ID: <CABjMoXa3y5eKtkiNZZOsyqnqZ7R7kX8FToOs+OKGaSwJku+uRA@mail.gmail.com>
To: Thomas Fossati <thomas.fossati@arm.com>
Cc: gen-art@ietf.org, draft-ietf-spring-sr-replication-segment.all@ietf.org, last-call@ietf.org, spring@ietf.org
Content-Type: multipart/alternative; boundary="000000000000a87b7305fdb5549a"
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/BeM8iP57KU-gElDdbLtQPJ2G2GM>
Subject: Re: [Gen-art] [spring] Genart last call review of draft-ietf-spring-sr-replication-segment-14
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Jun 2023 17:02:24 -0000

Thomas,
Thanks for the review. We will address your editorial comments in next
revision.

-Rishabh

On Fri, Jun 9, 2023 at 9:03 AM Thomas Fossati via Datatracker <
noreply@ietf.org> wrote:

> Reviewer: Thomas Fossati
> Review result: Ready
>
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
>
> For more information, please see the FAQ at
>
> <https://wiki.ietf.org/en/group/gen/GenArtFAQ>.
>
> Document: draft-ietf-spring-sr-replication-segment-14
> Reviewer: Thomas Fossati
> Review Date: 2023-06-09
> IETF LC End Date: 2023-06-19
> IESG Telechat date: Not scheduled for a telechat
>
> Summary:
>
> The premise is I am not a routing expert and I only had a high level
> understanding of segment routing before reading this document.  That
> said, I have very much enjoyed the clarity and precision of the material
> presented and I think the authors have done a really good job, thank
> you!  (BTW, I have found the terminology section especially useful to
> navigate the rest of the draft.)
>
> The instructions to IANA are concise and clear.
>
> >From a Gen-ART perspective I reckon the document is ready.
>
> Major issues: None
>
> Minor issues: None
>
> Nits/editorial comments:
>
> * §1.1, 3rd bullet: s/period/period./
> * §2.1, 4th para: s/may be leaf node/may be the leaf node/
> * §2.2, 3rd para: s/Again note/Again, note/
> * §2.2, 4th para: s/this document/this document./
> * §2.2, 5th para: s/may be leaf node/may be the leaf node/
> * §2.2.1, 2nd para: s/contains following/contains the following/
> * §2.2.1, Replication State info model: s/maybe be empty/may be empty/
> * §2.2.1: s/in a SRH. As per psuedo-code/in an SRH. As per pseudo-code/
> * §2.2.2: s/apriori/a priori/
> * §2.2.3: s/this same restrictions/this same restriction/
> * §4: s/catalog/catalogue/
>
>
> _______________________________________________
> spring mailing list
> spring@ietf.org
> https://www.ietf.org/mailman/listinfo/spring
>