Re: [Gen-art] Gen-ART review of draft-ietf-ospf-te-metric-extensions-09

Jari Arkko <jari.arkko@piuha.net> Wed, 07 January 2015 11:51 UTC

Return-Path: <jari.arkko@piuha.net>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 733591A89A5 for <gen-art@ietfa.amsl.com>; Wed, 7 Jan 2015 03:51:59 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.91
X-Spam-Level:
X-Spam-Status: No, score=-1.91 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, T_RP_MATCHES_RCVD=-0.01] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rr2drUP-U9Fg for <gen-art@ietfa.amsl.com>; Wed, 7 Jan 2015 03:51:56 -0800 (PST)
Received: from p130.piuha.net (p130.piuha.net [IPv6:2a00:1d50:2::130]) by ietfa.amsl.com (Postfix) with ESMTP id 0919C1A89F5 for <gen-art@ietf.org>; Wed, 7 Jan 2015 03:51:56 -0800 (PST)
Received: from localhost (localhost [127.0.0.1]) by p130.piuha.net (Postfix) with ESMTP id 6B5472CEF9; Wed, 7 Jan 2015 13:51:54 +0200 (EET) (envelope-from jari.arkko@piuha.net)
X-Virus-Scanned: amavisd-new at piuha.net
Received: from p130.piuha.net ([127.0.0.1]) by localhost (p130.piuha.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id slXB2QhWdtCA; Wed, 7 Jan 2015 13:51:50 +0200 (EET)
Received: from [127.0.0.1] (p130.piuha.net [IPv6:2a00:1d50:2::130]) by p130.piuha.net (Postfix) with ESMTP id 5CD622CC4D; Wed, 7 Jan 2015 13:51:42 +0200 (EET) (envelope-from jari.arkko@piuha.net)
Content-Type: multipart/signed; boundary="Apple-Mail=_F6EC002D-1723-4351-A7B1-8656B29A23A4"; protocol="application/pgp-signature"; micalg="pgp-sha512"
Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\))
From: Jari Arkko <jari.arkko@piuha.net>
In-Reply-To: <CABkgnnVd0_WjgAcgJQ1R2Da=zLL1XnOV9mHmP5-dyQ3zoJ7wvA@mail.gmail.com>
Date: Wed, 07 Jan 2015 13:51:38 +0200
Message-Id: <BBB9BC55-F3F0-45B1-9C6C-161AA8460C13@piuha.net>
References: <CABkgnnVd0_WjgAcgJQ1R2Da=zLL1XnOV9mHmP5-dyQ3zoJ7wvA@mail.gmail.com>
To: Martin Thomson <martin.thomson@gmail.com>
X-Mailer: Apple Mail (2.1878.6)
Archived-At: http://mailarchive.ietf.org/arch/msg/gen-art/CXJKxNO1NBiWt2OieYXNFoXC5Kg
Cc: "gen-art@ietf.org" <gen-art@ietf.org>, draft-ietf-ospf-te-metric-extensions.all@tools.ietf.org
Subject: Re: [Gen-art] Gen-ART review of draft-ietf-ospf-te-metric-extensions-09
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Jan 2015 11:51:59 -0000

Thanks for your review. Do the authors have any comments on these observations?

Jari

On 29 Dec 2014, at 22:13, Martin Thomson <martin.thomson@gmail.com> wrote:

> I am the assigned Gen-ART reviewer for this draft. For background on
> Gen-ART, please see the FAQ at
> < http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.
> 
> Please wait for direction from your document shepherd
> or AD before posting a new version of the draft.
> 
> Document: draft-ietf-ospf-te-metric-extensions-09
> Reviewer: Martin Thomson
> Review Date: 2014-12-29
> IETF LC End Date: 2014-12-24 (nice)
> IESG Telechat date: 2015-01-08
> 
> Summary: Good for PS with some minor issues.
> 
> Observations:
> 
> I find it a little disappointing that measurement techniques are so
> nebulously defined.  Values are measured over "a period" using "some
> method, which might be RFC 6374".  The "A" bit threshold is "a
> configured value".  That means that a consumer of this information has
> to take a lot on faith.  I have to assume that this is because we
> can't do better.
> 
> Minor issues:
> Please ensure that all the field descriptions include some textual
> indication of the size of the field.  Type and length are always 16
> bits each, so those can be assumed from RFC 3630.
> 
> As above, please specify the specific IEEE 754 floating point format,
> i.e., "single precision".  Otherwise you have to look at the figures
> to work out how many bits to use for the value and figures should be
> strictly informational.
> 
> Nits:
> Section 10 is missing a period.
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art