Re: [Gen-art] Genart last call review of draft-ietf-mpls-base-yang-15
Tarek Saad <tsaad@juniper.net> Fri, 21 August 2020 19:37 UTC
Return-Path: <tsaad@juniper.net>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9BF923A1082; Fri, 21 Aug 2020 12:37:17 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.098
X-Spam-Level:
X-Spam-Status: No, score=-2.098 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=juniper.net header.b=P2wG/lTk; dkim=pass (1024-bit key) header.d=juniper.net header.b=HaWdl8Fp
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1EIuSc5ZQ36I; Fri, 21 Aug 2020 12:37:15 -0700 (PDT)
Received: from mx0b-00273201.pphosted.com (mx0b-00273201.pphosted.com [67.231.152.164]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 30A263A1080; Fri, 21 Aug 2020 12:37:12 -0700 (PDT)
Received: from pps.filterd (m0108163.ppops.net [127.0.0.1]) by mx0b-00273201.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 07LJXWoo001244; Fri, 21 Aug 2020 12:37:11 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=PPS1017; bh=z1O9kM52rdVwJnnnwLSoZYN5gr4UHYgSGofYMgoIy78=; b=P2wG/lTk7HNK3/z97oCtBsZ5Qy9ycrzW1QGor92FIJ5sY2DIywqlHPnNucJm7wSc2TAi oLuebPClektmm6LNSyQsLSGn6bQHVQ/rrRJE4HAmGogkH9QSQb23IKiTZJ9w7/Tu2OWX Lc5IiIsLN4S8iwZII0mCB2+/v+vzoo3o2b0nVIbmi5CpiyXjdmWBszEdwEyEOYP89FDi +wuVTNKF5TRJOnslhxaokDcRibpevrM8GfCVkFF9zWUF1kLLsMX2YkKQQlWG89LQ5TUz HF3tyqcnZjp+O3+3V/xJmrOIrYc460FmOpOWW/bqAYF3KM81X+jSQ4g4LQ3vrYzQ0zMs 9A==
Received: from nam02-bl2-obe.outbound.protection.outlook.com (mail-bl2nam02lp2059.outbound.protection.outlook.com [104.47.38.59]) by mx0b-00273201.pphosted.com with ESMTP id 3311rscr9b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 21 Aug 2020 12:37:10 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X1MN+kcMGqgWp6b6iQNM1ffbKY8MXET0mhlIDKxDzG1PA4ay1UCQf8Ie3eZhobIYaV4avRiOk/chpTDaqyHZJaQVuiY9AyFNrlod887K8TqRew/6NvCx9ZMLfRB60f2xglVKhrn+E/7de3Cmu8J5EYl+bCqOAzCvW3prEQX1cDP41Cn3kMV9FvsRTZ6cggnU9Zx87tszxc5Ot9QuGSR88d8Uj7RD/28+y3uHmtDxo1y9VLLfilJUJUZsS16LXLqMYojeT+vmKAFqsklLdK65voQIP/HJslFW3qGmtILS1tWRFSxB1Ke5ABoqvXF6WWyWbaFYtt93baEC6En4KLA0yQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z1O9kM52rdVwJnnnwLSoZYN5gr4UHYgSGofYMgoIy78=; b=TzYFxc2U9Js6h04Bj/XyfD8TdpX2L3fwBMekiDTmTJa+XRqWaaFr+SJpQd3mH/ZaTG8kXP0azoQi2pbVBXhijzBH58CuVX9Mwy5U1skmhD9UABxhbEPvUBPxvDV8z5JlJX7oqOezbVRdA5+nhOYEwBqI2KGbHr1bz/DYVzMiY1rZ/W/yTw/0orAo7etDYRzIzJr8vrT5GwxtK11bSRiAV5/1GPyyKQ2/vhNChJWC1s4iduyJTWtMZW+GX1b+6CQSpxOC5xkCwTviMnXEtFc6oJUejRTtcaEba5O27GMBjDE73b7PFN+4q38NkdNR+vNOkjj8hIq8h3axUB5soQ8x/A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=juniper.net; dmarc=pass action=none header.from=juniper.net; dkim=pass header.d=juniper.net; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z1O9kM52rdVwJnnnwLSoZYN5gr4UHYgSGofYMgoIy78=; b=HaWdl8FpcQi7+kogE0v6l92k8avZDOqCQsEyzfi5cyio7q/iu+Hip9FPGh0x01Lz29QFWMKyJX972lcFu94XyE55gR6KDXksldUr4FNBUBzdRXcj6vReB27Eq5IyI6B78O8BsMjYxfYwlcLUpgdhdYRzWQPxci3ilT2D/sXCwW8=
Received: from BYAPR05MB4136.namprd05.prod.outlook.com (2603:10b6:a02:85::18) by BYAPR05MB6534.namprd05.prod.outlook.com (2603:10b6:a03:ea::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3305.16; Fri, 21 Aug 2020 19:37:08 +0000
Received: from BYAPR05MB4136.namprd05.prod.outlook.com ([fe80::380d:349c:196f:a61d]) by BYAPR05MB4136.namprd05.prod.outlook.com ([fe80::380d:349c:196f:a61d%4]) with mapi id 15.20.3326.010; Fri, 21 Aug 2020 19:37:08 +0000
From: Tarek Saad <tsaad@juniper.net>
To: Gyan Mishra <hayabusagsm@gmail.com>, "gen-art@ietf.org" <gen-art@ietf.org>
CC: "draft-ietf-mpls-base-yang.all@ietf.org" <draft-ietf-mpls-base-yang.all@ietf.org>, "mpls@ietf.org" <mpls@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>
Thread-Topic: Genart last call review of draft-ietf-mpls-base-yang-15
Thread-Index: AQHWdy91J6VKCl6OckCbs0LuKd6aEqlCs3mA
Date: Fri, 21 Aug 2020 19:37:07 +0000
Message-ID: <D2B489A5-8ED3-4AA0-A213-217B4D32DDB9@juniper.net>
References: <159795487231.23645.8624000777631081432@ietfa.amsl.com>
In-Reply-To: <159795487231.23645.8624000777631081432@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
msip_labels: MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_Enabled=true; MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_ContentBits=0; MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_SiteId=bea78b3c-4cdb-4130-854a-1d193232e5f4; MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_ActionId=72ac2e81-b610-467a-a0ff-00002c5dd323; MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_SetDate=2020-08-21T14:43:13Z; MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_Method=Standard; MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_Name=Juniper Business Use Only;MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_Enabled=true;
user-agent: Microsoft-MacOutlook/16.40.20081000
authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=juniper.net;
x-originating-ip: [66.129.241.14]
x-ms-publictraffictype: Email
x-ms-office365-filtering-ht: Tenant
x-ms-office365-filtering-correlation-id: 04ee3977-529e-49d3-2df7-08d846099761
x-ms-traffictypediagnostic: BYAPR05MB6534:
x-microsoft-antispam-prvs: <BYAPR05MB6534FD9FAEB6BB0E1AD033D2B75B0@BYAPR05MB6534.namprd05.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: HlK6RRHlXEkHHq1C98IsZVj2S/JxTsGBtTuLh/KA13Gd1RwY4u9nzgG7R33ueQNnFh6HThV4NG1Q9pi1zqHx4TjCWbRbrLJGzta5TzQovMzvPlqty34qi6riGX4dD6AzChWJSOH9lghwYDij910/kbotTNestYrLa8oRHyKy4hnBnNgiGJBwKAsFUbf/Y/lzv49UdaVp9JRd/Sc1JAUuSQp8c3TTWK4XYhBc34pp05dXAAkLOqg7fMc3i49p5xXb7jeK/pfi11f01PI+f/Qu86+B3WDT7wCx4I3kBGtr8Gz+6f27UlyNjRfS3vRX9I+6JmyMXv74G+Lk6rJZYtLNFT8IEqHH/I9UxOSvzkMkYkfr7WPFPN553aVn3J0UAMoDqn3f2jZ7ex+Kvpc1qfAp4g==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR05MB4136.namprd05.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(346002)(396003)(366004)(39860400002)(376002)(5660300002)(6512007)(6486002)(83380400001)(66946007)(8936002)(54906003)(4326008)(71200400001)(66446008)(316002)(2906002)(66476007)(36756003)(76116006)(86362001)(186003)(26005)(66556008)(8676002)(2616005)(110136005)(478600001)(6506007)(33656002)(64756008); DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata: gQ+fv8FrFWsB/8o+3xBgl6gotyDmiGjKMO4EIuWVT9ZhPZykhNoS26SDlsufadwHDQ4mwHW6RbxO5C+9CXH2L/CQE6EO7PGu0tTHVq+O3l1CqujWOMdzKaBl4LIgDX56v64w2BNb6fGBWtaS4TRpgFhSPTVoyUF44ozbFN0NhsFXjQAQp4db3o46Ed9teamXMAXGlJgSf4YTpcYHbhaSbnKrXnUmGDs05c2FH/okHrQ6Fkfx0xsWkeKPJaPmAj33+WZyTfr5hH//szELMDPELAO7pnkHsHD5xxqFZjDl9a2o9HSsvkRCAWYcjv017JSXKsBqsrll9Q7Baq2SQgVZbznpo8W97E2ePLUJi/Kg1CmyU+jCNldBdt5EiBrBwVksdg0OSQIybmr2MUNGwV1SR8jw0hqA0OnLpAicDGj6WQfHnUwHCjLtKoTiDVSFbxuTRYZ7ycWQ++3VLaGztoZdQW0gS+9y4SoMiZP7djBF2Mye1oxutKSn15b6EsdevhgilxEDl5tTTbbAzT7SLcBpbHdjknG+wmBjbLRx27lHxxHSpX4MZHKKoWb03VF2RGsp4zRzy0vMDtByxW7iV4sljWrybyDOSK73FKmC9vxiOHVXwudhyWDqUm6KWe73MBM1P4fpwL8SXSHaoZTqT/Pm3Q==
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-ID: <874B711C8D8586449DCFD5438A097497@namprd05.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: juniper.net
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR05MB4136.namprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 04ee3977-529e-49d3-2df7-08d846099761
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Aug 2020 19:37:07.8864 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: bea78b3c-4cdb-4130-854a-1d193232e5f4
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: RFLmHIFakK2DbXkKYFSlgDQQMTTT0an9rspjUJOHR6QtTdkCsJsg5JaqzOU3+jLDlwH1zYYfrOrSkW1A0NfuEw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR05MB6534
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-08-21_09:2020-08-21, 2020-08-21 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_spam_notspam policy=outbound_spam score=0 phishscore=0 mlxscore=0 suspectscore=0 priorityscore=1501 adultscore=0 bulkscore=0 spamscore=0 clxscore=1011 malwarescore=0 mlxlogscore=999 impostorscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008210182
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/CyY6sSpH70Znx1bUpVlN77QKeYM>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-mpls-base-yang-15
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Aug 2020 19:37:18 -0000
Hi Gyan, Thanks for your review and feedback. Please see inline for response. On 8/20/20, 4:21 PM, "Gyan Mishra via Datatracker" <noreply@ietf.org> wrote: [External Email. Be cautious of content] Reviewer: Gyan Mishra Review result: Ready with Issues I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair. Please treat these comments just like any other last call comments. For more information, please see the FAQ at <https://urldefense.com/v3/__https://trac.ietf.org/trac/gen/wiki/GenArtfaq__;!!NEt6yMaO-gk!S8w6fBzg5hjb7UcNsQdv20qrXxR22KyMBmCTkOJGQW6T-3ejGFC0tAbCed7y0Q$ >. Document: draft-ietf-mpls-base-yang-?? Reviewer: Gyan Mishra Review Date: 2020-08-20 IETF LC End Date: 2020-08-19 IESG Telechat date: Not scheduled for a telechat Summary: The draft is well written and provides a very basic augmentation of the Yang core data modeling for routing management (NDMA) defined in RFC 8349 which provides the framework for managing routing subsystems. This drafts provides a new MPLS base model framework for managing MPLS routing subsystems, reflecting the mpls protocol specifications defined in RFC 3031 for future extensibility to Segment Routing architecture RFC 8200 and beyond. Major issues: The base mpls model defined in very BASIC as defined in the draft and does not reflect the data modeling of all attributes and features of the MPLS architecture defined in RFC 3031. I understand this draft defines the topmost transport label for MPLS forwarding however it does not fully represent all data models representing the LDP protocol. [TS]: Yes, the MPLS base model is agnostic to the signaling protocol that used to populate the MPLS RIBs. As illustrate in Figure 1, we expect other models to be augmenting MPLS base model. If the goal of this draft is to reflect RFC 3031 in its entirety it does not appear to do so. If the goal of the draft is to provide just the basics of the MPLS address family framework for future extensibility for MPLS specification as well and this draft is not the "end all be all" for the MPLS protocol specification and is just an introduction of the mpls base Yang model then I think this draft is ready for publication. [TS]: Yes, this model serves as base augmentation for other MPLS models. Examples what I believe is missing in defining RFC 30301 in this MPLS base Yang model. Defining the Label stack and depth of the stack Since this topmost MPLS label can be LDP, Static or RSVP data model is mentioned but not in the context of label stack with multiple lables and that the topmost label based on LFIB forwwarding table could be either TE or LDP tompost label. Also mention of BOS -Bottom of Stack bit for the label stack. [TS]: The MPLS label stack type is defined in RFC8294 (see rt-types:mpls-label-stack) and is being used by MPLS base model. Implicit null label value 3 & Explicit Null label value 0 & QOS related to EXP marking related to uniform & pipe mode. I did not see any mention of EXP bits. [TS]: these types are all are already defined in RFC8294 (please refer to traffic-class instead of EXP). See below: +--ro mpls-label-stack +--ro entry* [id] +--ro id uint8 +--ro label? rt-types:mpls-label +--ro ttl? uint8 +--ro traffic-class? uint8 Also LDP Downstream on demand versus Downstream unsolicited label distribution [TS]: As mentioned, these are outside the scope of this model. method MPLS LIB and FEC binding for LSP and data structure for LFIB entry local label & remote label learned via label mapping message. LDP label advertise, allocate, accept policy for /32 FEC binding to be only the loopback of iBGP peer FEC Destination. Label Imposition, Label Swapping & Label Disposition. MPLS LDP multicast extension mLDP - P2MP LSP Also BGP LU labeled unicast BGP being used for Label distribution and label binding for inter-as for topmost label binding inter-as stitching RFC 8277. Also context related to LDPv6 RFC 7552. Also softwire mesh framework RFC 5565 v6 edge over v4 core or v4 edge over v6 core and core transport being v4 or v6 and not both. [TS]: MPLS bindings (local/remote) for V4 and V6 prefixes will be found in the augmentation of entries of the respective IPv4 and IPv6 RIBs defined in RFC 8349. Regards, Tarek (on behalf of co-authors) Minor issues: None Nits/editorial comments: The draft is well written and serves a critical need to extend the Yang data modeling capabilities from existing IPv4 & IPv6 address families to MPLS address family framework. A XML file was not provided on the datatracker so I was not able to run idnits against the draft. Juniper Business Use Only
- [Gen-art] Genart last call review of draft-ietf-m… Gyan Mishra via Datatracker
- Re: [Gen-art] Genart last call review of draft-ie… Tarek Saad
- Re: [Gen-art] Genart last call review of draft-ie… Gyan Mishra
- Re: [Gen-art] Genart last call review of draft-ie… Alissa Cooper