Re: [Gen-art] Genart last call review of draft-ietf-ospf-te-link-attr-reuse-12

Peter Psenak <ppsenak@cisco.com> Fri, 29 May 2020 10:50 UTC

Return-Path: <ppsenak@cisco.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3D9683A0ABD; Fri, 29 May 2020 03:50:58 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.601
X-Spam-Level:
X-Spam-Status: No, score=-9.601 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ex6c9nD57YOy; Fri, 29 May 2020 03:50:56 -0700 (PDT)
Received: from aer-iport-4.cisco.com (aer-iport-4.cisco.com [173.38.203.54]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E0C623A0AB9; Fri, 29 May 2020 03:50:55 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1683; q=dns/txt; s=iport; t=1590749456; x=1591959056; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=cxvTsfRXUKjXmYmmazI1Pdm0uTSeh3HjkcwQE/Upe1Y=; b=gmaeZocWsnUGW6FWOHfBOHUHJw9xIML6iyQ8OnBxdGoREYi3+Xc0wbaL xk2Wc7/29Ts5I1VvbV0eGNvwBqcQvZNPdbHDLrxWepL1b0I0SoeYTTyKR Ms8d8J37hgeAkf6fk3v61VJp+RKHxf517wDv87DL24xvw7Luz8j3qAZ0B g=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0B0AQDB6NBe/xbLJq1mGwEBAQEBAQEBBQEBARIBAQEDAwEBAUCBSoMYVAEgEoRRiQGICZtyCwEBAQ4jDAQBAYREAoIiJTgTAgMBAQsBAQUBAQECAQYEbYVZDIVyAQEBAQIBIxVBEAsUBAICJgICVwYBDAgBAYMiAYJcIA+vCXaBMoVRg2CBOgaBDiqMX4FBP4ERJ4JpPoJnAoE8gz2CYASPDIo1mX6CXoJ6hTaQMwcegmWJBYRljUGQXIlzlCOBaiKBVjMaCBsVgyVPGQ2QTBeIY4VEPwNnAgYIAQEDCYsvgkUBAQ
X-IronPort-AV: E=Sophos;i="5.73,448,1583193600"; d="scan'208";a="26563866"
Received: from aer-iport-nat.cisco.com (HELO aer-core-2.cisco.com) ([173.38.203.22]) by aer-iport-4.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 29 May 2020 10:50:48 +0000
Received: from [10.60.140.51] (ams-ppsenak-nitro2.cisco.com [10.60.140.51]) by aer-core-2.cisco.com (8.15.2/8.15.2) with ESMTP id 04TAomW1025928; Fri, 29 May 2020 10:50:48 GMT
To: Linda Dunbar <linda.dunbar@futurewei.com>, gen-art@ietf.org
Cc: last-call@ietf.org, lsr@ietf.org, draft-ietf-ospf-te-link-attr-reuse.all@ietf.org
References: <159068537978.29606.17882487660677527802@ietfa.amsl.com>
From: Peter Psenak <ppsenak@cisco.com>
Message-ID: <be900a0e-2f9f-e9f9-ad87-63121ae9703c@cisco.com>
Date: Fri, 29 May 2020 12:50:48 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.7.0
MIME-Version: 1.0
In-Reply-To: <159068537978.29606.17882487660677527802@ietfa.amsl.com>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Outbound-SMTP-Client: 10.60.140.51, ams-ppsenak-nitro2.cisco.com
X-Outbound-Node: aer-core-2.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/EBruhPlvBUSdGhzSebY0QvIpGFI>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-ospf-te-link-attr-reuse-12
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 29 May 2020 10:50:58 -0000

Hi Linda,

On 28/05/2020 19:02, Linda Dunbar via Datatracker wrote:
> Reviewer: Linda Dunbar
> Review result: Not Ready
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-ietf-ospf-te-link-attr-reuse-??
> Reviewer: Linda Dunbar
> Review Date: 2020-05-28
> IETF LC End Date: 2020-05-29
> IESG Telechat date: Not scheduled for a telechat
> 
> Summary: this document introduces a new link attribute advertisement in OSPFv2
> and OSPFv3 to address general link properties needed for new applications, such
> as Segment Routing.
> 
> Major issues:
> The document has good description on the TLV structure of the Application
> specific Advertisements, but fails to describe what are the NEW Link attributes
> needed by Segment Routing. Page 7 (section 5) has a really good description on
> all the link properties added to OSFP (RFC4203, RFC 7308, RFC7471, RFC3630) to
> achieve TE. I can see Segment Routing would need each node to advertise its own
> SID and the SIDs of adjacent nodes. Can't they be encoded (or extended) in
> OSPF's NODE ID?

we are not defining any new attributes.

We are allowing an existing link attributes to be used by other 
applications, including, but not limited to SRTE.

thanks,
Peter

> 
> Minor issues:
> 
> Nits/editorial comments:
> 
> Best regards,
> 
> Linda Dunbar
> 
> 
> 
>