[Gen-art] Post-telechat review of draft-ietf-lime-yang-connectionless-oam-16
Elwyn Davies <elwynd@folly.org.uk> Thu, 09 November 2017 19:44 UTC
Return-Path: <elwynd@folly.org.uk>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2FF49129ACC; Thu, 9 Nov 2017 11:44:47 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.6
X-Spam-Level:
X-Spam-Status: No, score=-2.6 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8tB1GZoDUX77; Thu, 9 Nov 2017 11:44:44 -0800 (PST)
Received: from b-painless.mh.aa.net.uk (b-painless.mh.aa.net.uk [81.187.30.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 620BF126B71; Thu, 9 Nov 2017 11:44:44 -0800 (PST)
Received: from 8.8.7.3.6.c.b.1.f.9.8.9.a.2.c.c.1.0.0.0.f.b.0.0.0.b.8.0.1.0.0.2.ip6.arpa ([2001:8b0:bf:1:cc2a:989f:1bc6:3788]) by b-painless.mh.aa.net.uk with esmtp (Exim 4.89) (envelope-from <elwynd@folly.org.uk>) id 1eCsUU-0001P1-0e; Thu, 09 Nov 2017 19:27:54 +0000
To: "gen-art@ietf.org" <gen-art@ietf.org>, draft-ietf-lime-yang-connectionless-oam.all@ietf.org
From: Elwyn Davies <elwynd@folly.org.uk>
Message-ID: <66fd2fda-98cf-7123-7bcf-13c7a1e1744f@folly.org.uk>
Date: Thu, 09 Nov 2017 19:27:42 +0000
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Content-Language: en-GB
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/F4rUsYS53ycMoEsjVk_ME7_a15U>
Subject: [Gen-art] Post-telechat review of draft-ietf-lime-yang-connectionless-oam-16
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Nov 2017 19:44:47 -0000
Hi. Some remaining comments from the earlier gen-art reviews that perhaps ought to be addressed plus some additional introduced nits. Apologies for the long delay - I failed to notice that -16 had been published and gen-art reviewers don't get new version notifications. Minor Issues: Sources of imported models: It would be useful to list the RFCs/I-Ds that define the models that are imported as a new section before the YANG definitions. Currently draft-ietf-netmod-schema-mount, draft-ietf-rtgwg-ni-model and draft-ietf-rtgwg-routing-types that are under development are not mentioned; the existing standards of RFC 6021 and RFC 7223 should also be referenced (7223 is). They should all be normative. [The references are present but they need to be linked to the module names and listed separately from the YANG specification.] Nits: s1, bullet 1: s/networks/network/ s1, end of para 7: s/OAM protcols/OAM protocols/ s1, last para: s/Connectionless Communicatioms/connectionless communications/ s2.2, TP definition: s/diagnostic test/diagnostic tests/ s3, para 10 (top of page 6): s/test- point/test-point/ s3, last para: The term 'proactive' has not yet been defined. A forward reference to s3.2 is needed (e.g., "proactive (see Section 3.2)"). s3.2, last para: s/be extended to specific OAM technology/is extended to cover a specific OAM technology/ s3.3, para 2: OLD: OAM neighboring test points are referred to a list of neighboring test points in adjacent layers up and down the stack for the same interface that are related to the current test point. NEW: Each OAM test point may have an associated list of neighboring test points in other layers up and down the protocol stack for the same interface and are therefore related to the current test point. ENDS ss3.6 and 3.7: The use of single quotes and associated spacing in these sections is not correct, and there are some other language corrections. The corrected version is suggested here: NEW: 3.6. Path Discovery Data This is a generic grouping for the path discovery data model that can be retrieved by any data retrieval methods including RPC operations. Path discovery data output from methods, includes 'src-test-point' container, 'dst-test-point' container, 'sequence-number'leaf, 'hop- cnt' leaf, session statistics of various kinds, path verification and path trace related information. Path discovery includes data to be retrieved on a 'per-hop' basis via a list of 'path-trace-info- list' items which includes information such as 'timestamp' grouping, 'ingress-intf-name', 'egress-intf-name' and 'app-meta-data'. The path discovery data model is made generic enough to allow different methods of data retrieval. None of the fields are made mandatory for that reason. Note that a set of retrieval methods are defined in [I-D.ietf-lime-yang-connectionless-oam-methods]. 3.7. Continuity Check Data This is a generic grouping for the continuity check data model that can be retrieved by any data retrieval methods including RPC operations. Continuity check data output from methods, includes 'src-test- point' container, 'dst-test-point' container, 'sequence-number' leaf, 'hop-cnt' leaf and session statistics of various kinds. The continuity check data model is made generic enough to allow different methods of data retrieval. None of the fields are made mandatory for that reason. Noted that a set of retrieval methods are defined in [I-D.ietf-lime-yang-connectionless-oam-methods]. ENDS s5: The import items should have a description indicating the modules from which they come including the relevant RFC numbers. Note this is in addition to a section in the introductory text summarisng what modules are imported (as noted in minor issues). s5, "container path=trace-info" description: s/like/such as/ s5. "grouping timestamp": It would be good to add references (including section numbers) to the description showing where the various timestamps are defined in the IEE PTP doc and the NTP RFC. s5, "container timestamp-64bit": I believe there is a typo in the description: OLD: "Only applies when Truncated NTP or 64bit NTP Timestamp."; NEW: "Only applies when Truncated PTP or 64bit NTP Timestamp.";