Re: [Gen-art] Genart last call review of draft-ietf-idr-rfc8203bis-06

Alissa Cooper <alissa@cooperw.in> Thu, 08 October 2020 00:14 UTC

Return-Path: <alissa@cooperw.in>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 210E43A0A42; Wed, 7 Oct 2020 17:14:35 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.098
X-Spam-Level:
X-Spam-Status: No, score=-2.098 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=cooperw.in header.b=rLPWPt0H; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=G/XMwAZ0
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bxdf8ozIbAu1; Wed, 7 Oct 2020 17:14:33 -0700 (PDT)
Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2A0023A0A3A; Wed, 7 Oct 2020 17:14:30 -0700 (PDT)
Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 05F335A6; Wed, 7 Oct 2020 20:14:27 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Wed, 07 Oct 2020 20:14:28 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cooperw.in; h= content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; s=fm1; bh=Z /1awXIjkwBk5QdkrVNf/ndT8xCyBfje5nfyKajAXO4=; b=rLPWPt0HcSq6i86oN xK/eqgGFzaQBKr+ChF2krcDlaFkmlbj4Di82ZdbaGKSQcDlfJnBk496f9pwPiWbK PntbvDFd9Kk2j1B/LD6g7c0xjnxHmyQXQQy5ZNzyxzbrfdE+aFP/+FO0k6+zlD3g f3cZCp6GlkH3qhiwsthio/sVjIZpcETOOBT1xFR0RUtSFg2JSLbQHc9tPkgAeHiN ska4DM6hxqHYmW9CHT57Zkyho3fe106fQnpOGXC5PTAT8xws97tcW5NsHovtR8OT 7iMfX4KYzTL2n/3+Mv+J2Sz8hRLZkdv7+NJWEkqAzuvbQWgyZZUJG5OKV7ZVSfYT 5Z4ew==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=Z/1awXIjkwBk5QdkrVNf/ndT8xCyBfje5nfyKajAX O4=; b=G/XMwAZ07lrccTtvSrvUlklAEv078DU8kAUS2dXYsaEVBo1yLLNtgWIW8 MxTtJ9TPDjnNUC/CSrHe3B9A2UMNcuNmXXJZdx/1YOtnEnzMShnn7Jgb+uBW9wze DdTtl/FwpSG06d+wVh0w1Nqhdtsr8pH5Y3V1gllt/Pmm9eHtJaIRF0bsR/lXGYo/ aLNICDgxNSh0VvXDgS+tV3EWQdU5FmYfpKt5e+NqkTrMDRrv7gdSjuVe3JOVLwxM gBkTkNeGpvrAraQFFs3MGjFji+imvGCJsKgWbE0+gHeOXPt/3Qx6WnOPBxnHPs+R DLw/PHBGJP5ho4/Q8nBwXjse2vY1w==
X-ME-Sender: <xms:41l-X8CfxIFo4LbZLXKMSTTqUVoyGUAN8goHCGe8iJf66KiEfSJFYw> <xme:41l-X-igNPULu2FDJOI6D_IlOXdg10v1Qir728V400mXi-Dji9T2n46W4NKwU4GfS nH0kUy0lpQKEQoWLA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrgeejgdefudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpegtggfuhfgjfffgkfhfvffosehtqhhmtdhhtddvnecuhfhrohhmpeetlhhishhs rgcuvehoohhpvghruceorghlihhsshgrsegtohhophgvrhifrdhinheqnecuggftrfgrth htvghrnhepfeduhffgtefgtedvvdffiedutdekffegvdejjedtieehfefgleefuedtledv gffgnecuffhomhgrihhnpehivghtfhdrohhrghenucfkphepuddtkedrhedurddutddurd elkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegr lhhishhsrgestghoohhpvghrfidrihhn
X-ME-Proxy: <xmx:41l-X_lKOS0YVwKzXjKSM0zC3skp5C8pWfkZBr9zreEYJ_0KBVv5XQ> <xmx:41l-XywOMAvI-EONd-g6Vo-Q6gfyVVnRj5MTuBwWKYsJwUTAHPJSVQ> <xmx:41l-XxRVBWX-ElHh6--lKlE4G7c8UXh13q8sYubvQ9sTikt7ytGtzw> <xmx:41l-X8dwNsrpaq9po7dXV8w4AHcNvg25NjmyuuEbtalQRktasG-TpA>
Received: from alcoop-m-c46z.fios-router.home (pool-108-51-101-98.washdc.fios.verizon.net [108.51.101.98]) by mail.messagingengine.com (Postfix) with ESMTPA id 04619306467D; Wed, 7 Oct 2020 20:14:26 -0400 (EDT)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\))
From: Alissa Cooper <alissa@cooperw.in>
In-Reply-To: <159469756416.23871.9871951323378623271@ietfa.amsl.com>
Date: Wed, 7 Oct 2020 20:14:26 -0400
Cc: Review Team <gen-art@ietf.org>, last-call@ietf.org, draft-ietf-idr-rfc8203bis.all@ietf.org, idr@ietf.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <D5C6D774-EF74-4312-B23E-3EE16825117B@cooperw.in>
References: <159469756416.23871.9871951323378623271@ietfa.amsl.com>
To: Dale Worley <worley@ariadne.com>
X-Mailer: Apple Mail (2.3608.120.23.2.4)
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/FXYZxUeTehDGQqopIC0g22EJRlY>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-idr-rfc8203bis-06
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Oct 2020 00:14:35 -0000

Dale, thanks for your review. I entered a DISCUSS ballot. I think some of the questions you raise about Appendix B deserve some further discussion.

Thanks,
Alissa


> On Jul 13, 2020, at 11:32 PM, Dale Worley via Datatracker <noreply@ietf.org> wrote:
> 
> Reviewer: Dale Worley
> Review result: Ready with Nits
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document:  draft-ietf-idr-rfc8203bis-06
> Reviewer:  Dale R. Worley
> Review Date:  2020-07-13
> IETF LC End Date:  2020-07-14
> IESG Telechat date:  not known
> 
> Summary:
> 
>    This draft is basically ready for publication, but has nits that
>    should be fixed before publication.
> 
> * Minor issues:
> 
> 3.  Operational Considerations
> 
> See the comments about Appendix B.
> 
> Appendix B.  Changes to RFC 8203
> 
> xThis appendix should describe upward-compatibility considerations.
> The body says that the Communication should be limited to 128 octets
> if feasible.  But there could be situations where the sender sends a
> longer Communication without knowing that the receiver implements
> 8203bis, and the receiver in fact does not.  How to recover from that
> situation?  E.g., will the NOTIFICATION be rejected with a specific
> error message?  Can the sender detect the problem by the subsequent
> behavior of the receiver?  Is it even well-defined that the receiver
> will reject the message?  Can the situation be compensated by
> immediately sending another NOTIFICATION without the Communication?
> 
> Indeed these considerations probably should be put in section 3.
> 
> * Nits/editorial comments:
> 
> Abstract
> 
> It seems like it would be useful to note here "This document updates
> RFC 4486 and obsoletes RFC 8203 by defining an Extended BGP
> Administrative Shutdown Communication >>>of up to 255 octets<<< to
> improve communication using multibyte character sets." since the
> length extension is the only significant change this document
> introduces.
> 
> 1.  Introduction
> 
>   via offline methods such email or telephone calls.  This document
> 
> Insert "such >>>as<<< email".
> 
> 2.  Shutdown Communication
> 
>      This field is not NULL terminated.
> 
> The best phrasing is "NUL terminated", as the name of the character is
> NUL.  (See RFC 20.)  However, it is common to say "null terminated",
> which is valid because "null" is a common adjective (i.e., not a
> proper adjective) that describes the variety of termination.  But
> "NULL terminated", though not infrequently used, isn't reallly
> correct.  (Unless the RFC Editor says otherwise!)
> 
> 6.  Security Considerations
> 
>   UTF-8 "Shortest Form" encoding is
>   REQUIRED to guard against the technical issues outlined in [UTR36].
> 
> It might be useful to repeat this restriction in the description of
> the Communication field in section 2.
> 
> [END]
> 
> 
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art