[Gen-art] Genart last call review of draft-ietf-sfc-multi-layer-oam-23

Behcet Sarikaya <sarikaya2012@gmail.com> Mon, 15 May 2023 16:09 UTC

Return-Path: <sarikaya2012@gmail.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DA05EC16B5C3; Mon, 15 May 2023 09:09:48 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.845
X-Spam-Level:
X-Spam-Status: No, score=-6.845 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jx5VWi-Sqq2n; Mon, 15 May 2023 09:09:48 -0700 (PDT)
Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 47BC5C16B5C2; Mon, 15 May 2023 09:09:48 -0700 (PDT)
Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-307d20548adso3018689f8f.0; Mon, 15 May 2023 09:09:48 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684166986; x=1686758986; h=cc:to:subject:message-id:date:from:reply-to:mime-version:from:to:cc :subject:date:message-id:reply-to; bh=JyxozIEI9hnCR9hj8bnFQKtwdsRMoisw6nLm7/V9xxg=; b=YPaNK/59jxT4yHF7F8cRGdklZszjwr79ZHUQrR21a7SXdSI3Iz4ltflZ8d/goCSNLq kVJeThvtKq+0qJmEP+UpSMEXgijdd4EE3AoKE2itBBQMaGBh4EJ2Ca39bNuIGZ0PyaC4 1LhTbFC208exaJWhu0BjjYdCEsyBHW+VNEu0eisZtnkSQiNr84OxXPT8pu3gmcl+DOJc u3+KsgdHhKz/ZU1ZNw0IhzugUMby4l2k3Si34j5jndRemwC/dqeTQDozfbbMrqTbRms0 k0m4xolj9XyQ1uDoThJztd6RVGF7/CV7LCvvag66wzhuVDjQP0I1fs6gUu24d3uJcFIr 66fw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684166986; x=1686758986; h=cc:to:subject:message-id:date:from:reply-to:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JyxozIEI9hnCR9hj8bnFQKtwdsRMoisw6nLm7/V9xxg=; b=bn7BJfSqik0fHfxFMLfcTMG6V8y8Wdq6kYbA0vR/JmokxHYomg60ueGky46PHEfY+b dzDzgJWjukjVhebeTAeywb3JXpJd9yASn95dZ/Lrtfcr8ZrebX4HIpY7IaAIlia2RsEG 0kaU2xEsac1sQZ42zxvEY4fJZ1dP6ww+KP6kCGmgr17151hqu/evV91hu7UdalISoYOM e0ZzGOwyRaFzb5eDarkdAbQWLe6ZaytSnI4leTK02wSret8BTatyFeIOUYWy+JntHxXh bFmnZHPVT0vXTHjM1Z/Ajg0e62GLXzNuGBwtGycXVEbsTKnBENn/yQd4tAbo2fRe7Atu +CBg==
X-Gm-Message-State: AC+VfDy1di4XsDLCCLQ4W+nLBuxcFRceZ5YUT3gjX7BILtgJvpY0Q1oI /ytUXkETLejdcSoXuOj+E3qKDguvkiH5Bhr+EmLMF/5lKkslEg==
X-Google-Smtp-Source: ACHHUZ7jVDnBmIcxjYl3jALH/D7KSgYI8J4T6EugvKnM7u2wCX1tbIhhNhS9x21XHRFnHCEPyOfBUjFdbyDTJB0Tw88=
X-Received: by 2002:adf:e391:0:b0:307:8800:bbda with SMTP id e17-20020adfe391000000b003078800bbdamr23497432wrm.49.1684166985347; Mon, 15 May 2023 09:09:45 -0700 (PDT)
MIME-Version: 1.0
Reply-To: sarikaya@ieee.org
From: Behcet Sarikaya <sarikaya2012@gmail.com>
Date: Mon, 15 May 2023 11:09:33 -0500
Message-ID: <CAC8QAcf3Z0BH3WFAkJ+CvwL-5t7vTVdXU=i_ku7GnvWDxmMK5Q@mail.gmail.com>
To: gen-art@ietf.org
Cc: draft-ietf-sfc-multi-layer-oam.all@ietf.org, Last Call <last-call@ietf.org>, sfc@ietf.org, andrew-ietf@liquid.tech
Content-Type: multipart/alternative; boundary="000000000000e7787505fbbdae0d"
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/FXey4J0akAdcGt3d8YEvhl-mW1w>
Subject: [Gen-art] Genart last call review of draft-ietf-sfc-multi-layer-oam-23
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 15 May 2023 16:09:48 -0000

Reviewer: Behcet Sarikaya
Review result: Ready with Nits

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://wiki.ietf.org/en/group/gen/GenArtFAQ>.

Document: draft-ietf-sfc-multi-layer-oam-??
Reviewer: Behcet Sarikaya
Review Date: 2023-05-15
IETF LC End Date: 2023-05-17
IESG Telechat date: Not scheduled for a telechat

Summary:
This document defines  Service Function Chaining (SFC) Operation, Maintenance
and Management (OAM) protocol. It defines in Section 6 ICMP like Echo
Request/Reply for SFC to do Operation, Maintenance and Management mainly for
Fault Management as SFC messages which constitutes the bulk of SFC OAM
protocol. As shepherd write-up explains it grew out of 3 documents all lead by
Greg Mirsky when he was with ZTE.

Major issues:none

Minor issues:
Author list has 6 people as also indicated in shepherd write-up. The document
already contains two names in the contributor list. Strongly recommend having
one more in the contributor list.

Nits/editorial comments: please add the and as shown below:
This mechanism enables on-demand Continuity Check and
   Connectivity Verification among other operations over SFC in networks
  and addresses functionalities discussed in Sections 4.1, 4.2, and 4.3 of
   [RFC8924].

The draft name contains multi-layer which is not mentioned elsewhere in the
draft.

draft-ietf-sfc-nsh-tlv -> RFC 9263

draft-ietf-sfc-oam-packet normative reference is in RFC Editor Queue

Behcet