[Gen-art] review of draft-ietf-curdle-gss-keyex-sha2-08.txt (details)

Francis Dupont <Francis.Dupont@fdupont.fr> Wed, 09 January 2019 15:13 UTC

Return-Path: <Francis.Dupont@fdupont.fr>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B117E1277D2; Wed, 9 Jan 2019 07:13:54 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.001
X-Spam-Level:
X-Spam-Status: No, score=-0.001 tagged_above=-999 required=5 tests=[SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6Y9vtybq7La1; Wed, 9 Jan 2019 07:13:52 -0800 (PST)
Received: from givry.fdupont.fr (givry.fdupont.fr [IPv6:2001:41d0:1:6d55:211:5bff:fe98:d51e]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 573AF124BE5; Wed, 9 Jan 2019 07:13:52 -0800 (PST)
Received: from givry.fdupont.fr (localhost [IPv6:::1]) by givry.fdupont.fr (8.14.7/8.14.7) with ESMTP id x09EYtsE086115; Wed, 9 Jan 2019 15:34:55 +0100 (CET) (envelope-from dupont@givry.fdupont.fr)
Message-Id: <201901091434.x09EYtsE086115@givry.fdupont.fr>
From: Francis Dupont <Francis.Dupont@fdupont.fr>
To: gen-art@ietf.org
Cc: draft-ietf-curdle-gss-keyex-sha2.all@ietf.org
Date: Wed, 09 Jan 2019 15:34:55 +0100
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/FehTar066YkkPsM_JzG7YvR8hCs>
Subject: [Gen-art] review of draft-ietf-curdle-gss-keyex-sha2-08.txt (details)
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 09 Jan 2019 15:13:55 -0000

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>;.

Document: draft-ietf-curdle-gss-keyex-sha2-08
Reviewer: Francis Dupont
Review Date: 2019-01-08
IETF LC End Date: 2019-01-08
IESG Telechat date: Not scheduled for a telechat

Summary: Ready

Major issues: None

Minor issues: None

Nits/editorial comments:
 - section 2 page 2: please add RFC 8174 with RFC 2119
  (note this can (should?) be done by the RFC Editor)

 - 7.3 page 10: I have a mixed feeling about the "must". As the problem
 is real some could want a MUST but the attack is both an example (so
 the defense too) and against a feature which is not the subjet of
 the document. I have no good proposal so I leave this to the security
 directorate.

(spelling)

 - 3 page 3 and 5.2 page 9 table titles: refences -> references

 - 5.2 page 4: Helman -> Hellman

 - 5.1 page 4: trasmitted -> transmitted

 - 5.1 page 5: estalishment -> establishment

Regards

Francis.Dupont@fdupont.fr