Re: [Gen-art] Gen-art Last Call/Telechat Review of draft-ietf-ipfix-mib-variable-export-09

Elwyn Davies <elwynd@dial.pipex.com> Mon, 30 November 2015 23:37 UTC

Return-Path: <elwynd@dial.pipex.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4BC0C1B3331; Mon, 30 Nov 2015 15:37:59 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -101.899
X-Spam-Level:
X-Spam-Status: No, score=-101.899 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, USER_IN_WHITELIST=-100] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id B-qSDcrKYkDU; Mon, 30 Nov 2015 15:37:55 -0800 (PST)
Received: from b.painless.aa.net.uk (b.painless.aa.net.uk [IPv6:2001:8b0:0:30:5054:ff:fe5e:1643]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id F29981B332F; Mon, 30 Nov 2015 15:37:54 -0800 (PST)
Received: from 3.d.2.f.0.5.f.2.8.e.e.e.b.6.c.5.1.0.0.0.f.b.0.0.0.b.8.0.1.0.0.2.ip6.arpa ([2001:8b0:bf:1:5c6b:eee8:2f50:f2d3]) by b.painless.aa.net.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.77) (envelope-from <elwynd@dial.pipex.com>) id 1a3Y10-0001bX-Cu; Mon, 30 Nov 2015 23:37:50 +0000
To: Paul Aitken <paitken@brocade.com>
References: <56474E2E.6070001@dial.pipex.com> <d35611da87c0412c9690b647af2978dc@EMEAWP-EXMB12.corp.brocade.com> <5657276E.5090800@dial.pipex.com> <565CB8CE.1040301@brocade.com>
From: Elwyn Davies <elwynd@dial.pipex.com>
Message-ID: <565CDDCB.4030001@dial.pipex.com>
Date: Mon, 30 Nov 2015 23:37:47 +0000
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <565CB8CE.1040301@brocade.com>
Content-Type: multipart/alternative; boundary="------------040905040709030502040600"
Archived-At: <http://mailarchive.ietf.org/arch/msg/gen-art/Fgk0r67Vrl67qf4d_0pB6DjoD6E>
Cc: General area reviewing team <gen-art@ietf.org>, Colin McDowall <cmcdowal@Brocade.com>, "draft-ietf-ipfix-mib-variable-export.all@ietf.org" <draft-ietf-ipfix-mib-variable-export.all@ietf.org>
Subject: Re: [Gen-art] Gen-art Last Call/Telechat Review of draft-ietf-ipfix-mib-variable-export-09
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 30 Nov 2015 23:37:59 -0000

Hi.

Thanks for the response.

I think that the suggested text for s5.7.2 is fine.

To be clear, on s5.4.2 and s8, the point I was trying to get across is 
that the variable length encoding is a MAY/RECOMMENDED. Accordingly 
agents can alternatively use a fixed length encoding.  I was suggesting 
that it would probably be worth mentioning in s8 that the collector MUST 
be prepared to accept the fixed length encoding as well as variable 
length encoding.  Possibly this is the default situation (I am not 
familiar with the innards of IPFIX) but I thought collector implementers 
needed to be reminded of the need to support fixed length encoding as 
well as variable length encoding for the relevant fields so that they 
are liberal in what they accept!

I have no problem with -11 or AUTH48 as long as the text gets in. 
Depends if you have sent it to the RFC Editor already I guess.

Cheers,
Elwyn

On 30/11/2015 20:59, Paul Aitken wrote:
> Elwyn,
>
>> Hi Colin and Paul.
>>
>> Thanks for your responses.  I think -10 clears up most of the points 
>> below.  There is one point and a query that don't seem to be addressed:
>>
>>> s5.4.2, last para and Figure 5:  It would be helpful to remind 
>>> people that the
>>> value 0xffff/65535 indicates variable length encoding  per RFC 7011 
>>> Section
>>> 3.2 and that the RECOMMENDED use of variable length encoding for
>>> mibObjectIdentifier fields is indicated in subsequent figures by 
>>> placing 65535
>>> in the relevant length fields.  ******Presumably Collector 
>>> implementations  MUST
>>> accept a specific length encoding in the usual IETF spirit! It might 
>>> be worth
>>> being explicit about this (this might usefully be said in Section 
>>> 8).******
>>
>> PJ: done.
>>
>> Thoughts on an addendum to s8?
>
> Collectors must accept both fixed and variable length per the MUST in 
> section 7 of RFC 7011.
>
> I didn't see a need to re-state that here, though there's no harm in 
> doing so. See the suggested text below.
>
>
>> s5.7.2: is there any need to explain how withdrawal is achieved?  I 
>> am not an
>> IPFIX expert so I am not aware how the withdrawal might be achieved.
>>
>> Does this need to be explained or a reference added?
>
> It's explained in section 8.1 of RFC 7011 (IPFIX Protocol 
> Specification). I think it would be reasonable to expect that 
> implementers should already be familiar with that.
>
> Again, there's no need and no harm in adding a note. See the suggested 
> text below.
>
> Please let us know whether you're happy with these additions, and 
> whether you'd like to see a -11 or are happy for them to be inserted 
> in the AUTH48.
>
> Suggested texts:
>     5.7.2 Template Withdrawal and Reuse
> IPFIX Template Withdrawal is discussed in Section 8.1 of RFC 7011.
>
>     Data Records containing mibObjectValue Information Elements MUST NOT
>     be exported if their corresponding Data Template or MIB Field Options
>     Template has been withdrawn, since the MIB Field Options Template
>     MUST be exported in the same IPFIX Message as the Data Template which
>     it annotates, except as allowed by the caveat ofSection 5.7.1 
> <https://tools.ietf.org/html/draft-ietf-ipfix-mib-variable-export-10#section-5.7.1>.
>
>     MIB Field Options Template IDs MUST NOT bewithdrawn or  reused while they are
>     required by any existing Data Templates.
>
> (Alternatively, the new paragraph could be added to the end of the 
> section instead.)
>    8.The Collecting Process's Side
>     The specifications insection 9 of [RFC7011] <https://tools.ietf.org/html/rfc7011#section-9>  also apply to Collectors
>     that implement this specification.  In addition, the following
>     specifications should be noted.
>
>     A Collecting Process that implements this specification MUST store
>     the data records containing the OID Object Type Definitions with the
>     same retention policy as templates.
>
>     A Collecting Process that implements this specification SHOULD have
>     access to MIB modules in order to look up the received MIB Object
>     Identifiers and find the full type definition and name of MIB OID
>     fields used in received templates.
>
>     It should be noted that since reduced size encoding MAY be used by
>     the Exporting Process, the Collecting Process cannot assume a
>     received size for a field is the maximum size it should expect for
>     that field.
>  Since mibObjectIdentifier fields may be exported using variable 
> length mibObjectIdentifier fields, the Collecting Process MUST support 
>  Variable-Length Information Element encoding per Section 7 of RFC 7011.
>
>     If a Collecting Process receives a MIB Object Identifier that it
>     cannot decode, it MAY log a warning.
>
>     A Collecting Process MUST support the 3 options for handling columnar
>     objects detailed inSection 5.8 
> <https://tools.ietf.org/html/draft-ietf-ipfix-mib-variable-export-10#section-5.8>.
>
> P.
>